From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by mx.groups.io with SMTP id smtpd.web11.2698.1632392800527163683 for ; Thu, 23 Sep 2021 03:26:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=xuRMa5GG; spf=pass (domain: nuviainc.com, ip: 209.85.221.44, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f44.google.com with SMTP id w17so15624391wrv.10 for ; Thu, 23 Sep 2021 03:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zmU1uHQX5IbjbMwKn2wD3mAaC7d04VDgqIP76r/0VdU=; b=xuRMa5GG8tM3VtyNM5GbNGOwBCbIZ3QwnrE3+52llNmV/IMCXSEv+ORVS6YQGZ8jXQ +zNMd/fhnbtDe3eNnftyGGwGC8fmIQfIBCTtA30U2SWaP+txsaIHC1eEKJH5kC/FrVAX Vwue6DOFo+SrGel0eriT4+q763kFwoGwI0SZhgBrZKrCedggaCXFYZZblEkd1GElRxQ8 AuUdpZfxyBwzodXLjYLK8k6RveZWgsx/Y/9BmQkcfhDxFL/wLSFJiyNfcRhW0ZpFy44H a/THAVBlCN+6/X/MIXSwmihT9t4nlTsziRKaNhZIuTY4WSiPY8T79FvILHznwqQKAbG/ ktdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zmU1uHQX5IbjbMwKn2wD3mAaC7d04VDgqIP76r/0VdU=; b=gkZSyuYRh7PtsKJN90ScMVVQ6vc3fPmKVmCcKW9aekCpP85ApEhy5HLvS/Vq1R5JjN m3FLS09tfKzV90qtyLYCtSmZNqUr7NKhuCwjnGF55jp1KgdX+7qMYgaxCjh+8WJsdzJc ibzxgilqNe4jV/9vcaqI79e6wEbeLfcZOgJssX1jWfErTGqaxgsTLI8bpvUh+iOmpe/o dSIlmBOICOevpRQUo2MmkDUwSEq+LUrP7c/hNK6IogXz957VwSSyDqd70sUUV00uCriU Hb9Ud1G7DzMmHnVBoLif02c7JD5ENlqq/wgbbDTsndBcY6Ndip5ZZjlAzN57zwPKCE4W t67w== X-Gm-Message-State: AOAM5337x1yD/PHwxzEgXWrzXGEJHYDZYopZITevOb9IlrqB6dNiBRcb A/6j+1AKvdoA0mVtCdnqr+KBtQ== X-Google-Smtp-Source: ABdhPJw8WMe53X6SifJxonRQbn30H85u+wcOx5gV2rboeSPakqjmVJs0G+Vq0H+tCyj5Xc2zZHsCZw== X-Received: by 2002:a7b:cd93:: with SMTP id y19mr3687859wmj.110.1632392798911; Thu, 23 Sep 2021 03:26:38 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id u13sm4956412wrt.41.2021.09.23.03.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 03:26:38 -0700 (PDT) Date: Thu, 23 Sep 2021 11:26:36 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: Ard Biesheuvel , edk2-devel-groups-io , Ard Biesheuvel , Grzegorz Jaszczyk , Grzegorz Bernacki , Samer El-Haj-Mahmoud , Alon Rotman Subject: Re: [edk2-platforms PATCH 0/4] Marvell readmes Message-ID: <20210923102636.q3nmgnzuqtxgzlsa@leviathan> References: <20210921110056.659697-1-mw@semihalf.com> <20210922121451.f7iyi76uca77wimp@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Marcin, On Wed, Sep 22, 2021 at 14:46:10 +0200, Marcin Wojtas wrote: > > Marcin, when you find the time, could you please do a pass over these > > files with Leif's critique in mind? > > > For all 3 platforms, how about the following update: > - extend the "Summary" section with supported features or interfaces > (or add an extra heading for that). > - "Build" section -> add link to external wiki/.md file To be clear - I don't mind the actual example build command line, and maybe listing the expected/available command line options (-D). > - "ARM System Ready certification." - leave intact > > Please let me know if that will work for you. Sure, sounds good. Best Regards, Leif