From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.2713.1632393047468436566 for ; Thu, 23 Sep 2021 03:30:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=kGjIHt0b; spf=pass (domain: nuviainc.com, ip: 209.85.221.47, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f47.google.com with SMTP id t28so2371219wra.7 for ; Thu, 23 Sep 2021 03:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=f1RyIoJeA7TeY1hpWUideS2vbdeO/sdnlOqOiBUZu8Y=; b=kGjIHt0bI5PpeBpxqjvBtCYRCLC0dnSgCqG+A9qV2W8WdSFFUkj1tgCyOHvveBoSsI KMOByedfREX9Olbn4i9TSn3aswnN4Bz5YdYMnOPo7m02zZnDkGJMzA5qVPO0+xAAP5Si gQgtWzrGCMAAy6WuEOWM0TLuh1kCYjtkmazTHcYPEVdp21I+Sp6PjqAtif4R4CZ8iPF8 JujnhyQkhLBTPtn7mHHC7D0qGHiYB79/yCHwmy6Vtq9pBZtnAC2EtaqdsdHxG5v4jhoq +I+w74vs5rb9Rb8I/4GVQ28FFOA+XBWmI9q5jyCa1K5Ij8ktN0XVBL7+J/zNukSx1oHt x1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=f1RyIoJeA7TeY1hpWUideS2vbdeO/sdnlOqOiBUZu8Y=; b=OkTo0Hgnytekaj5NwvFOawLK53RgYjS0dIFp02g0A1tgS13+i4lu0T3raXD9CGfW/d SHQotEF+IZDTbMdh8L82ejfEjmSzUwuaNRN97rswiKuvoQ6Aj3tKuUN+fuE4ivqF4UXK OOfhxoCEtAntjrNDcL8XkpRekksjUNL8KxOIZ/Il+F+g39NdUPCchhal0v2VDd96Mls3 JWAiVciSKaRcXrKrx4ui6Myn1OfALq8Dm0qd6UyM42/EafOV4dfzejew4ncrnJrujkq+ wQF+swGTxk0tngW1elqlZ6J8R6ZYH3blbHp6/eDZ7ybzeA+r1Qvdt2JFDWHR+mgmC+Ft b3WA== X-Gm-Message-State: AOAM530y0R5r5HfEHYED8Vyp05mRqziT+4OdsxFaxp60ckdTyDvhLqs2 ZFE5tUFs/dhWjk4dncV6+6cEqQ== X-Google-Smtp-Source: ABdhPJwVcPkjGmF6fXv2KZncKjynR+SguIDuuvaMRWHXdVb8PJq4+XwzR9tueHjvSMP/Pdu7XDrxVw== X-Received: by 2002:a1c:f302:: with SMTP id q2mr3690444wmq.56.1632393045990; Thu, 23 Sep 2021 03:30:45 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id h125sm4959027wmh.9.2021.09.23.03.30.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 03:30:45 -0700 (PDT) Date: Thu, 23 Sep 2021 11:30:43 +0100 From: "Leif Lindholm" To: Rebecca Cran Cc: devel@edk2.groups.io, Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [PATCH 1/1] Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math Message-ID: <20210923103043.mwguttbkzkldhclo@leviathan> References: <20210922223709.15665-1-rebecca@nuviainc.com> MIME-Version: 1.0 In-Reply-To: <20210922223709.15665-1-rebecca@nuviainc.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Not just an improvement, but an actual bugfix. I would propose a subject line change though: Qemu: SbsaQemu: Set the DSDT revision value to 2 to use 64-bit math -> Platform/Qemu: fix SbsaQemu DSDT format version If you're OK with the change, I can fold that in. Reviewed-by: Leif Lindholm On Wed, Sep 22, 2021 at 16:37:09 -0600, Rebecca Cran wrote: > Set the DSDT revision value to 2 by using the define from Acpi60.h > EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION. This > causes the AML interpreter to use full 64-bit integers and math. > > Signed-off-by: Rebecca Cran > --- > Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > index e056d6cdb02e..1bf9fbb99e75 100644 > --- a/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > +++ b/Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl > @@ -6,6 +6,7 @@ > * SPDX-License-Identifier: BSD-2-Clause-Patent > **/ > > +#include > #include > > #define LINK_DEVICE(Uid, LinkName, Irq) \ > @@ -25,8 +26,9 @@ > Address, Pin, Link, Zero \ > } > > -DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "LINARO", "SBSAQEMU", > - FixedPcdGet32 (PcdAcpiDefaultOemRevision)) { > +DefinitionBlock ("DsdtTable.aml", "DSDT", > + EFI_ACPI_6_0_DIFFERENTIATED_SYSTEM_DESCRIPTION_TABLE_REVISION, > + "LINARO", "SBSAQEMU", FixedPcdGet32 (PcdAcpiDefaultOemRevision)) { > Scope (_SB) { > // UART PL011 > Device (COM0) { > -- > 2.31.1 >