From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.5766.1632474916919174455 for ; Fri, 24 Sep 2021 02:15:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=jK7D3AJP; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632474916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RnjG9MjfQK4C1Obii6y0knPoa4E+o3smmJtjte02MvI=; b=jK7D3AJPoYLWkddtLs/hxkFpXmGwlEWf7tgH4uzFh6MLft/Ypt//HgBjMb+z0M+x+C5MIu hjPmsbb6zRHndJsxHecw7nX3KP5BU9gUwDHHXkHK+ipRXgSDEwgluIPg46Z5l0CQ13Xk31 YWfQrs1RHo/4c0Y11nSgiPGGpp0fpog= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-81-xHzCKqlOOL2v5zh6vdNMQg-1; Fri, 24 Sep 2021 05:15:11 -0400 X-MC-Unique: xHzCKqlOOL2v5zh6vdNMQg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E9034100D680; Fri, 24 Sep 2021 09:15:09 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 68E16652A5; Fri, 24 Sep 2021 09:15:09 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 41561180063A; Fri, 24 Sep 2021 11:15:06 +0200 (CEST) Date: Fri, 24 Sep 2021 11:15:06 +0200 From: "Gerd Hoffmann" To: devel@edk2.groups.io, jiewen.yao@intel.com Cc: "Xu, Min M" , Brijesh Singh , Ard Biesheuvel , "Justen, Jordan L" , Erdem Aktas , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector Message-ID: <20210924091506.opmarh7xppat5kpr@sirius.home.kraxel.org> References: <20210923084821.yxizus3loa2p6hms@sirius.home.kraxel.org> <7c9aeb95-5c33-bd8d-4f0c-40133f4c7c3d@amd.com> <20210924052825.2qljhtvweonbov5q@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 24, 2021 at 07:32:33AM +0000, Yao, Jiewen wrote: > Hi Gerd > Having config-a and config-b is proposed by original RedHat rep in EDKII - Laszlo. > We reach the agreement to separate those 2 configuration and AMD SEV is taking same approach. > > Are you saying you want to reset the high level plan and unify config-a and config-b into one binary? There isn't that much of a difference between the normal and amd sev build. It has additional drivers and the grub boot loader added, smm support turned off, network stack removed. The differences between config-a and config-b are much larger according to the design document. config-b has a completely different initialization code path, skipping the PEI phase. I see that as a major problem when it comes to long-term maintenance, and so far nobody could explain the reason for this. I'll go read the links to old discussions sent by Min, maybe I find something there. Having a config-b with network stack disabled, driver for RTMR trusted boot added, maybe some other little tweaks but otherwise a boot workflow identical to config-a is reasonable in my eyes. Merging it with AmdSev should also be relatively easy then. take care, Gerd