From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"Xu, Min M" <min.m.xu@intel.com>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector
Date: Fri, 24 Sep 2021 13:17:52 +0200 [thread overview]
Message-ID: <20210924111752.pnrwuzlocmbfn6ic@sirius.home.kraxel.org> (raw)
In-Reply-To: <694ad227-bf3b-fd37-716d-f715df8ab9ba@amd.com>
On Fri, Sep 24, 2021 at 05:38:21AM -0500, Brijesh Singh wrote:
>
> On 9/24/21 5:11 AM, Yao, Jiewen wrote:
> > You are right. My statement for page table is wrong. Both TDX and SEV need them.
> >
> > That is NOT our original design. But I can understand why it is changed today.
> >
> > I compare https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FTDVF%2FOvmfPkg%2FResetVector%2FX64%2FTdxMetadata.asm&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cc5ee156422614a843cf408d97f43bc9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637680751169724127%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GI6%2BzLASgUtBT9kS%2B%2BVDfzLlImYhZJeETpNfDMIimAk%3D&reserved=0 and https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAMDESE%2Fovmf%2Fblob%2Fsnp-v8%2FOvmfPkg%2FResetVector%2FX64%2FOvmfMetadata.asm&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cc5ee156422614a843cf408d97f43bc9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637680751169724127%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Dq2pLkdBsYXFbYM5nmy43yv4DWn7IDUceMpQg2%2F0jYo%3D&reserved=0.
> >
> > There are 8 entries in TDX, and 10 entries in SEV.
> > 2 of them are same, page table and TEMP RAM.
> > 6 entries are TDX unique. 8 entries are SEV unique.
>
> In the SEV patches you are seeing more sections because I tried to keep
> it in sync with the MEMFD [1] so that its much more readable.
We could add just a single range for stack + heap + pagetables (+more?)
and comments saying which MEMFD areas are covered by that range, to keep
the table small.
take care,
Gerd
next prev parent reply other threads:[~2021-09-24 11:18 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 9:05 [PATCH V7 0/1] Add Intel TDX support in OvmfPkg/ResetVector Min Xu
2021-09-21 9:05 ` [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector Min Xu
2021-09-22 7:49 ` Gerd Hoffmann
2021-09-23 0:38 ` Min Xu
2021-09-23 8:48 ` Gerd Hoffmann
2021-09-23 11:39 ` Yao, Jiewen
2021-09-23 12:54 ` Brijesh Singh
2021-09-23 13:18 ` Yao, Jiewen
2021-09-23 13:19 ` [edk2-devel] " Min Xu
2021-09-23 13:38 ` Yao, Jiewen
2021-09-23 14:03 ` Brijesh Singh
2021-09-23 14:15 ` Min Xu
2021-09-23 14:19 ` Yao, Jiewen
2021-09-24 5:37 ` Gerd Hoffmann
2021-09-24 7:36 ` Yao, Jiewen
2021-09-24 9:24 ` Gerd Hoffmann
2021-09-24 9:55 ` Yao, Jiewen
2021-09-24 5:28 ` Gerd Hoffmann
2021-09-24 6:55 ` Min Xu
2021-09-24 10:07 ` Gerd Hoffmann
2021-09-24 10:33 ` Yao, Jiewen
2021-09-24 14:02 ` Gerd Hoffmann
2021-09-24 16:40 ` Yao, Jiewen
2021-09-27 8:05 ` Gerd Hoffmann
2021-09-27 10:05 ` Yao, Jiewen
2021-09-27 14:59 ` Gerd Hoffmann
2021-09-28 0:21 ` Yao, Jiewen
2021-09-24 7:32 ` Yao, Jiewen
2021-09-24 9:15 ` Gerd Hoffmann
2021-09-24 4:54 ` Gerd Hoffmann
2021-09-24 7:39 ` Yao, Jiewen
2021-09-24 9:34 ` Gerd Hoffmann
2021-09-24 10:11 ` Yao, Jiewen
2021-09-24 10:38 ` Brijesh Singh
2021-09-24 11:17 ` Gerd Hoffmann [this message]
2021-09-24 11:29 ` Brijesh Singh
2021-09-24 10:14 ` Brijesh Singh
2021-09-24 10:58 ` Brijesh Singh
2021-09-25 0:03 ` Min Xu
2021-09-25 3:21 ` Brijesh Singh
2021-09-25 23:17 ` [edk2-devel] " Min Xu
2021-09-25 23:30 ` Yao, Jiewen
2021-09-27 8:44 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924111752.pnrwuzlocmbfn6ic@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox