From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.6736.1632482280620845546 for ; Fri, 24 Sep 2021 04:18:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gf8lIL7t; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632482279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v3dKeoiJ1FkZ5BHlMo5WHwA6HV/kYMD3Hml8x2d7hOk=; b=Gf8lIL7t+gETuhzeDW/rxZJtWtG2DVPDoLFDZ3ljjHmczfnJfoHgrXNQYK1cMOoUoiK5zx vOX/qq23ka/aV7qTR66+E0yiAVyZwINt2MyGXm/ycoiXCaoZOtYN/gR7A+hxNJbi7jImDe ytk5l945/D8glUHjcIYbP4w+M31gvl8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-597-ul3fF4tJMJaesdzPOnGs-w-1; Fri, 24 Sep 2021 07:17:56 -0400 X-MC-Unique: ul3fF4tJMJaesdzPOnGs-w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C61791006AB1; Fri, 24 Sep 2021 11:17:54 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62A396A256; Fri, 24 Sep 2021 11:17:54 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id AD1AC180063A; Fri, 24 Sep 2021 13:17:52 +0200 (CEST) Date: Fri, 24 Sep 2021 13:17:52 +0200 From: "Gerd Hoffmann" To: Brijesh Singh Cc: "Yao, Jiewen" , "devel@edk2.groups.io" , "Xu, Min M" , Ard Biesheuvel , "Justen, Jordan L" , Erdem Aktas , James Bottomley , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V7 1/1] OvmfPkg: Enable TDX in ResetVector Message-ID: <20210924111752.pnrwuzlocmbfn6ic@sirius.home.kraxel.org> References: <20210923084821.yxizus3loa2p6hms@sirius.home.kraxel.org> <7c9aeb95-5c33-bd8d-4f0c-40133f4c7c3d@amd.com> <20210924045416.3vb7qxcetgtdggbs@sirius.home.kraxel.org> <20210924093420.xu7kmfnygy4lx7um@sirius.home.kraxel.org> <694ad227-bf3b-fd37-716d-f715df8ab9ba@amd.com> MIME-Version: 1.0 In-Reply-To: <694ad227-bf3b-fd37-716d-f715df8ab9ba@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 24, 2021 at 05:38:21AM -0500, Brijesh Singh wrote: > > On 9/24/21 5:11 AM, Yao, Jiewen wrote: > > You are right. My statement for page table is wrong. Both TDX and SEV need them. > > > > That is NOT our original design. But I can understand why it is changed today. > > > > I compare https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2-staging%2Fblob%2FTDVF%2FOvmfPkg%2FResetVector%2FX64%2FTdxMetadata.asm&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cc5ee156422614a843cf408d97f43bc9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637680751169724127%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GI6%2BzLASgUtBT9kS%2B%2BVDfzLlImYhZJeETpNfDMIimAk%3D&reserved=0 and https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAMDESE%2Fovmf%2Fblob%2Fsnp-v8%2FOvmfPkg%2FResetVector%2FX64%2FOvmfMetadata.asm&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cc5ee156422614a843cf408d97f43bc9b%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637680751169724127%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Dq2pLkdBsYXFbYM5nmy43yv4DWn7IDUceMpQg2%2F0jYo%3D&reserved=0. > > > > There are 8 entries in TDX, and 10 entries in SEV. > > 2 of them are same, page table and TEMP RAM. > > 6 entries are TDX unique. 8 entries are SEV unique. > > In the SEV patches you are seeing more sections because I tried to keep > it in sync with the MEMFD [1] so that its much more readable. We could add just a single range for stack + heap + pagetables (+more?) and comments saying which MEMFD areas are covered by that range, to keep the table small. take care, Gerd