From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.28428.1632732164163728628
 for <devel@edk2.groups.io>;
 Mon, 27 Sep 2021 01:42:44 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B3BcfP+V;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1632732163;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=J9BpNLZSPZuwcdM6fI2IbZCeb+kPVx9FjMq50h/IQB0=;
	b=B3BcfP+VkakrSMDTDHr+/EjrHNA8i5aH8Vv6iL/Ul5PM7iW28e2SbTZWECDEAcFZJB3Viw
	nZsNdGXWgDxIL6XReLi85NfVuuGhk8nZajFKICqwROtRvG2ymAu6PXQzhYT4F2wL32Lsm0
	/jSRvaXUqyL4UxXaMEqfZGnC+TX04e4=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-393-aEcTAjYUNUeQbFfkTe-U6Q-1; Mon, 27 Sep 2021 04:42:39 -0400
X-MC-Unique: aEcTAjYUNUeQbFfkTe-U6Q-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 321801B2C981;
	Mon, 27 Sep 2021 08:42:38 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.134])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id D3BF85D9D5;
	Mon, 27 Sep 2021 08:42:37 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 04158180092D; Mon, 27 Sep 2021 10:42:36 +0200 (CEST)
Date: Mon, 27 Sep 2021 10:42:35 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector
Message-ID: <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org>
References: <cover.1632707635.git.min.m.xu@intel.com>
 <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +_Bfv:
> +  DD TDX_BFV_RAW_DATA_OFFSET
> +  DD TDX_BFV_RAW_DATA_SIZE
> +  DQ TDX_BFV_MEMORY_BASE
> +  DQ TDX_BFV_MEMORY_SIZE
> +  DD TDX_METADATA_SECTION_TYPE_BFV
> +  DD TDX_METADATA_ATTRIBUTES_EXTENDMR

Size is still added twice, doesn't make sense given that they are either
equal or RAW_DATA_SIZE is zero.  One size field being 32bit and the other
being 64bit is pointless too (see also my mail to Jiewen).

> +  DD TDX_METADATA_SECTION_TYPE_TEMP_MEM

There are a bunch of TEMP_MEM entries, some of them are next to each
other in MEMFD, so you can squash them into one entry.

Can you move the metadata changes to a separate patch please?

take care,
  Gerd