From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Ard Biesheuvel <ardb+tianocore@kernel.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector
Date: Tue, 28 Sep 2021 06:42:54 +0200 [thread overview]
Message-ID: <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB5064BEEAC041F4F7E43AEAE8C5A89@PH0PR11MB5064.namprd11.prod.outlook.com>
Hi,
> > Can you move the metadata changes to a separate patch please?
> Yes, the metadata changes will be in a separate patch in the next version.
Can you also add a comment block documenting the format? Not only those
parts which are used for TDVF, but everything? The description in
tdx-virtual-firmware-design-guide-rev-1.pdf seems to be incomplete,
specifically the option to use the table for TD memory allocation
(as mentioned by Jiewen) is not covered. And possibly there is more
which is missing ...
thanks,
Gerd
next prev parent reply other threads:[~2021-09-28 4:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 2:05 [PATCH V8 0/3] Add Intel TDX support in OvmfPkg/ResetVector Min Xu
2021-09-27 2:05 ` [PATCH V8 1/3] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector Min Xu
2021-09-27 2:05 ` [PATCH V8 2/3] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm Min Xu
2021-09-27 2:05 ` [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector Min Xu
2021-09-27 8:42 ` Gerd Hoffmann
2021-09-28 2:30 ` Min Xu
2021-09-28 4:42 ` Gerd Hoffmann [this message]
2021-09-28 7:35 ` [edk2-devel] " Min Xu
2021-09-28 15:23 ` Brijesh Singh
2021-09-30 7:31 ` Min Xu
2021-09-30 17:39 ` Brijesh Singh
2021-10-08 1:13 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox