From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.9631.1632804181089669837
 for <devel@edk2.groups.io>;
 Mon, 27 Sep 2021 21:43:01 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=KUquFMCH;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1632804180;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Htqi54C55N7TA+nysyX9S/QY/JPZT0fZWYKOqieMXY4=;
	b=KUquFMCH3SDXS7ZP54k5N79ug6JJ1B8Xx6q03dH5kXWSFWvfGUVgi+w7nMm0u81PsrHZZu
	5enTLkH8WplaCsVjf/hBRcD+r+VhaXxzD+0D4fwNdnPLCOXNDUBd2YVPYutZfDUqj5OdwD
	LLG01Xy3zmXncvCE6tnrQ0psYj9p8wI=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-325-8lqfYAmqNT-L4XEyicC9Uw-1; Tue, 28 Sep 2021 00:42:58 -0400
X-MC-Unique: 8lqfYAmqNT-L4XEyicC9Uw-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC2EA8145E5;
	Tue, 28 Sep 2021 04:42:56 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.134])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DAFE76613;
	Tue, 28 Sep 2021 04:42:56 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 99AC418003B6; Tue, 28 Sep 2021 06:42:54 +0200 (CEST)
Date: Tue, 28 Sep 2021 06:42:54 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: "Xu, Min M" <min.m.xu@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V8 3/3] OvmfPkg: Enable TDX in ResetVector
Message-ID: <20210928044254.kdqpd76ltmcllqkr@sirius.home.kraxel.org>
References: <cover.1632707635.git.min.m.xu@intel.com>
 <729034c8d47013be1e87a68ba1b6c3a7b79a4b2a.1632707635.git.min.m.xu@intel.com>
 <20210927084235.pj7x2agzzzjqz7be@sirius.home.kraxel.org>
 <PH0PR11MB5064BEEAC041F4F7E43AEAE8C5A89@PH0PR11MB5064.namprd11.prod.outlook.com>
MIME-Version: 1.0
In-Reply-To: <PH0PR11MB5064BEEAC041F4F7E43AEAE8C5A89@PH0PR11MB5064.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> > Can you move the metadata changes to a separate patch please?
> Yes, the metadata changes will be in a separate patch in the next version.

Can you also add a comment block documenting the format?  Not only those
parts which are used for TDVF, but everything?  The description in
tdx-virtual-firmware-design-guide-rev-1.pdf seems to be incomplete,
specifically the option to use the table for TD memory allocation
(as mentioned by Jiewen) is not covered.  And possibly there is more
which is missing ...

thanks,
  Gerd