From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web10.12688.1632829419569259467
 for <devel@edk2.groups.io>;
 Tue, 28 Sep 2021 04:43:40 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RLFRLBvk;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1632829418;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=KnoyAAQzWSs1VdFxEV2pGfSYSVRwzLqp4fU3CuA+wZg=;
	b=RLFRLBvkO6CNB/LXi+pjUox2yUIlB+uuwe6Mt5jPEf/rhS2DrbRw4fE5NDj7YaNgp8g1Ef
	tXMoZ9SBda2MmXaJMK1xU9MgFY4kGRN7YahOGuKuEF/L0QpgUxXQz958+5uvBU1pJvxbUp
	J7wdzT6ix0nhIihP6w8hKDq+ZFAAkic=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-373-I9GCQCdsOoCXfzNYYK2a2g-1; Tue, 28 Sep 2021 07:43:35 -0400
X-MC-Unique: I9GCQCdsOoCXfzNYYK2a2g-1
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B706C1023F4D;
	Tue, 28 Sep 2021 11:43:33 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.134])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4EAF0652A2;
	Tue, 28 Sep 2021 11:43:33 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 3E97C18003B6; Tue, 28 Sep 2021 13:43:31 +0200 (CEST)
Date: Tue, 28 Sep 2021 13:43:31 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, abner.chang@hpe.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Leif Lindholm <leif@nuviainc.com>,
	Sami Mujawar <sami.mujawar@arm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Daniel Schaefer <daniel.schaefer@hpe.com>,
	Sunil V L <sunilvl@ventanamicro.com>
Subject: Re: [edk2-devel] [PATCH V2 6/9] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg
Message-ID: <20210928114331.4hw5uj66qkifltna@sirius.home.kraxel.org>
References: <20210928083107.7418-1-abner.chang@hpe.com>
 <20210928083107.7418-7-abner.chang@hpe.com>
MIME-Version: 1.0
In-Reply-To: <20210928083107.7418-7-abner.chang@hpe.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> -#  VALID_ARCHITECTURES           = ARM AARCH64
> +#  VALID_ARCHITECTURES           = ARM AARCH64 RISCV64

> -#ifdef MDE_CPU_AARCH64
> +#if defined(MDE_CPU_AARCH64) || defined(MDE_CPU_RISCV64)

That isn't just relocation.  Please split into two patches: One moving
around the file unmodified, and one adding riscv support.

thanks,
  Gerd