From: Sunil V L <sunilvl@ventanamicro.com>
To: Abner Chang <abner.chang@hpe.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <leif@nuviainc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Daniel Schaefer <daniel.schaefer@hpe.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>,
Michael D Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg
Date: Mon, 4 Oct 2021 15:35:51 +0530 [thread overview]
Message-ID: <20211004100551.GA67597@sunil-ThinkPad-T490> (raw)
In-Reply-To: <20210930004548.3033-1-abner.chang@hpe.com>
The patch set for edk2 looks fine to me.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks
Sunil
On Thu, Sep 30, 2021 at 08:45:36AM +0800, Abner Chang wrote:
> In V3: Address comments on V2.
> In V2: Remove HPE license on the files that just moved around or
> the changes in the file are just code removal.
>
> edk2 BZ #: 3665
> edk2 platform corresponding changes will be submitted after
> this pactch set is reviewed.
>
> This pacthes set is to migrate some modules from ArmVirtPkg
> to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
> those modules without the dependency with Arm*Pkg.
>
> The modules moved from ArmVirtPkg to OvmfPkg are,
> - FdtClientDxe
> - PciPcdProducerLib
> - HighMemDxe
> - QemuFwCfgLib
> - FdtPciHostBridgeLib
> - VirtioFdtDxe
>
> Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
> This change also remove the dependency on ArmPkg of OvmfPkg.
> - PcdPciIoTranslation
> - PcdPciIoTranslation
> - PcdPciMmio32(64)Translation
>
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>
> Abner Chang (12):
> ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg
> MdePkg: Add PcdPciIoTranslation PCD
> ArmPkg: Use PcdPciIoTranslation PCD from MdePkg
> ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg
> ArmVirtPkg/HighMemDxe: Relocate HighMemDxe to OvmfPkg
> OvmfPkg/HighMemDxe: Add RISC-V in the supported arch.
> ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg
> OvmfPkg/QemuFwCfgLibMMIO: Add RISC-V arch support
> MdePkg: Add PcdPciMmio32(64)Translation PCDs
> ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to
> OvmfPkg/Fdt
> OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported arch.
> ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt
>
> ArmPkg/ArmPkg.dec | 15 ++++++--------
> ArmVirtPkg/ArmVirtPkg.dec | 3 ---
> EmbeddedPkg/EmbeddedPkg.dec | 1 +
> MdePkg/MdePkg.dec | 12 +++++++++++
> ArmVirtPkg/ArmVirtCloudHv.dsc | 18 ++++++++---------
> ArmVirtPkg/ArmVirtKvmTool.dsc | 18 ++++++++---------
> ArmVirtPkg/ArmVirtQemu.dsc | 20 +++++++++----------
> ArmVirtPkg/ArmVirtQemuKernel.dsc | 20 +++++++++----------
> ArmVirtPkg/ArmVirtXen.dsc | 2 +-
> EmbeddedPkg/EmbeddedPkg.dsc | 1 +
> ArmVirtPkg/ArmVirtCloudHv.fdf | 6 +++---
> ArmVirtPkg/ArmVirtKvmTool.fdf | 6 +++---
> ArmVirtPkg/ArmVirtXen.fdf | 2 +-
> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 6 +++---
> .../ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf | 2 +-
> .../ArmVirtGicArchLib/ArmVirtGicArchLib.inf | 1 +
> .../ArmVirtPL031FdtClientLib.inf | 1 +
> .../ArmVirtPsciResetSystemLib.inf | 1 +
> .../ArmVirtTimerFdtClientLib.inf | 1 +
> .../KvmtoolRtcFdtClientLib.inf | 1 +
> .../NorFlashKvmtoolLib/NorFlashKvmtoolLib.inf | 1 +
> .../NorFlashQemuLib/NorFlashQemuLib.inf | 1 +
> .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 +
> ArmVirtPkg/XenioFdtDxe/XenioFdtDxe.inf | 1 +
> .../Drivers}/FdtClientDxe/FdtClientDxe.inf | 1 -
> .../FdtPciHostBridgeLib.inf | 11 +++++-----
> .../FdtPciPcdProducerLib.inf | 5 ++---
> .../Fdt}/HighMemDxe/HighMemDxe.inf | 7 ++++---
> .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf | 2 +-
> .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf | 6 +++---
> .../Include/Protocol/FdtClient.h | 0
> .../Drivers}/FdtClientDxe/FdtClientDxe.c | 0
> .../FdtPciHostBridgeLib/FdtPciHostBridgeLib.c | 0
> .../FdtPciPcdProducerLib.c | 0
> .../Fdt}/HighMemDxe/HighMemDxe.c | 3 ++-
> .../Fdt}/VirtioFdtDxe/VirtioFdtDxe.c | 0
> .../Library/QemuFwCfgLib/QemuFwCfgLibMmio.c | 7 ++++---
> Maintainers.txt | 6 ++++++
> 38 files changed, 106 insertions(+), 83 deletions(-)
> rename {ArmVirtPkg => EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.inf (92%)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf (77%)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf (87%)
> rename {ArmVirtPkg => OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.inf (83%)
> rename {ArmVirtPkg => OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.inf (92%)
> rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf => OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.inf (86%)
> rename {ArmVirtPkg => EmbeddedPkg}/Include/Protocol/FdtClient.h (100%)
> rename {ArmVirtPkg => EmbeddedPkg/Drivers}/FdtClientDxe/FdtClientDxe.c (100%)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c (100%)
> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c (100%)
> rename {ArmVirtPkg => OvmfPkg/Fdt}/HighMemDxe/HighMemDxe.c (95%)
> rename {ArmVirtPkg => OvmfPkg/Fdt}/VirtioFdtDxe/VirtioFdtDxe.c (100%)
> rename ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c => OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibMmio.c (93%)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-10-04 10:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 0:45 [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg Abner Chang
2021-09-30 0:45 ` [PATCH V3 01/12] ArmVirtPkg/FdtClintDxe: Move FdtClientDxe to EmbeddedPkg Abner Chang
2021-09-30 0:45 ` [PATCH V3 02/12] MdePkg: Add PcdPciIoTranslation PCD Abner Chang
2021-09-30 0:45 ` [PATCH V3 03/12] ArmPkg: Use PcdPciIoTranslation PCD from MdePkg Abner Chang
2021-09-30 0:45 ` [PATCH V3 04/12] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg Abner Chang
2021-09-30 0:45 ` [PATCH V3 05/12] ArmVirtPkg/HighMemDxe: Relocate HighMemDxe " Abner Chang
2021-09-30 0:45 ` [PATCH V3 06/12] OvmfPkg/HighMemDxe: Add RISC-V in the supported arch Abner Chang
2021-09-30 0:45 ` [PATCH V3 07/12] ArmVirtPkg/QemuFwCfgLib: Relocate QemuFwCfgLib to OvmfPkg Abner Chang
2021-09-30 0:45 ` [PATCH V3 08/12] OvmfPkg/QemuFwCfgLibMMIO: Add RISC-V arch support Abner Chang
2021-09-30 0:45 ` [PATCH V3 09/12] MdePkg: Add PcdPciMmio32(64)Translation PCDs Abner Chang
2021-09-30 0:45 ` [PATCH V3 10/12] ArmVirtPkg/FdtPciHostBridgeLib: Relocate FdtPciHostBridgeLib to OvmfPkg/Fdt Abner Chang
2021-09-30 0:45 ` [PATCH V3 11/12] OvmfPkg/FdtPciHostBridgeLib: Add RISC-V in the supported arch Abner Chang
2021-09-30 0:45 ` [PATCH V3 12/12] ArmVirtPkg/VirtioFdtDxe: Relocate VirtioFdtDxe to OvmfPkg/Fdt Abner Chang
2021-09-30 2:39 ` [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg Yao, Jiewen
2021-09-30 7:12 ` Gerd Hoffmann
2021-10-03 8:11 ` Daniel Schaefer
2021-10-04 10:05 ` Sunil V L [this message]
2021-10-05 9:30 ` [edk2-devel] " Ard Biesheuvel
2021-10-05 15:00 ` Abner Chang
[not found] ` <16AB2A90260D3DD8.20282@groups.io>
2021-10-06 9:27 ` Abner Chang
2021-10-08 3:14 ` 回复: " gaoliming
2021-10-08 3:39 ` Abner Chang
2021-10-11 1:22 ` 回复: " gaoliming
2021-10-12 4:16 ` Abner Chang
2021-10-14 9:51 ` Ard Biesheuvel
2021-10-14 10:13 ` Abner Chang
2021-10-14 10:57 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004100551.GA67597@sunil-ThinkPad-T490 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox