From: Sunil V L <sunilvl@ventanamicro.com>
To: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: devel@edk2.groups.io, Abner Chang <abner.chang@hpe.com>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH v1 1/5] U540, U500: Add filesystem drivers
Date: Mon, 4 Oct 2021 15:49:35 +0530 [thread overview]
Message-ID: <20211004101935.GA83401@sunil-ThinkPad-T490> (raw)
In-Reply-To: <20211003172359.1622768-2-daniel.schaefer@hpe.com>
Looks good to me.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks
Sunil
On Mon, Oct 04, 2021 at 01:23:55AM +0800, Daniel Schaefer wrote:
> Not DiskIoDxe because we don't have a disk, just for loading from
> Ramdisks.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
>
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 ++++++-
> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 4 +++-
> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 7 ++++++-
> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 4 +++-
> 4 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index 124f0d02cc..cdc1b9ee8f 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -1,7 +1,7 @@
> ## @file
> # RISC-V EFI on SiFive VC707 (U500) RISC-V platform
> #
> -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -507,6 +507,11 @@
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
>
> + #
> + # FAT filesystem + GPT/MBR partitioning + UDF filesystem
> + #
> + FatPkg/EnhancedFatDxe/Fat.inf
> + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>
> ShellPkg/Application/Shell/Shell.inf {
> <LibraryClasses>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
> index dac6f85272..f262e4fe17 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf
> @@ -1,7 +1,7 @@
> # @file
> # Flash definition file on SiFive VC707 (U500) RISC-V platform
> #
> -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -178,6 +178,8 @@ INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
> +INF FatPkg/EnhancedFatDxe/Fat.inf
> +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>
> !ifndef $(SOURCE_DEBUG_ENABLE)
> INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> index db7905774a..be70ef5294 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> @@ -1,7 +1,7 @@
> ## @file
> # RISC-V EFI on SiFive Freedom U540 HiFive Unleashed RISC-V platform
> #
> -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -506,6 +506,11 @@
> MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
>
> + #
> + # FAT filesystem + GPT/MBR partitioning + UDF filesystem
> + #
> + FatPkg/EnhancedFatDxe/Fat.inf
> + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>
> ShellPkg/Application/Shell/Shell.inf {
> <LibraryClasses>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
> index 5622e589d6..c0ce09fcee 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf
> @@ -1,7 +1,7 @@
> # @file
> # Flash definition file on SiFive Freedom U540 HiFive Unleashed RISC-V platform
> #
> -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> @@ -178,6 +178,8 @@ INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf
> INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf
> INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf
> INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf
> +INF FatPkg/EnhancedFatDxe/Fat.inf
> +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf
>
> !ifndef $(SOURCE_DEBUG_ENABLE)
> INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-10-04 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 17:23 [PATCH v1 0/5] Improvements for booting to Linux on RISC-V Daniel Schaefer
2021-10-03 17:23 ` [PATCH v1 1/5] U540, U500: Add filesystem drivers Daniel Schaefer
2021-10-04 10:19 ` Sunil V L [this message]
2021-10-03 17:23 ` [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure Daniel Schaefer
2021-10-04 10:39 ` Sunil V L
2021-10-03 17:23 ` [PATCH v1 3/5] U540, U500: Add initrd command to boot Linux Daniel Schaefer
2021-10-04 10:45 ` Sunil V L
2021-10-04 11:07 ` Daniel Schaefer
2021-10-03 17:23 ` [PATCH v1 4/5] U540: BuildCpuHob with 48 to indicate size memory space Daniel Schaefer
2021-10-04 11:02 ` Sunil V L
2021-10-04 11:26 ` Abner Chang
2021-10-03 17:23 ` [PATCH v1 5/5] Signal EndOfDxe in boot manager Daniel Schaefer
2021-10-04 11:07 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004101935.GA83401@sunil-ThinkPad-T490 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox