From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mx.groups.io with SMTP id smtpd.web08.7309.1633342781503316446 for ; Mon, 04 Oct 2021 03:19:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=YcfQn3cW; spf=pass (domain: ventanamicro.com, ip: 209.85.210.169, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pf1-f169.google.com with SMTP id m5so1326187pfk.7 for ; Mon, 04 Oct 2021 03:19:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fUMxcx+u5/hn2ugWKcdPNPqXU1oigWR10T+6HK6PHPY=; b=YcfQn3cWGXW2H5ODIz0sglx5T0dtVXIbKlRoXrh/u+VlTJd8CBD7qYcRwb+LHanaOm BoodpngBqU/ejMTrw4V4AOwuV4igQT/7cmpwGCvl+uquv/2PlU5pdAggH98mZYx/r5OA zIPJsUMLZSjSK5iDHXBdsmE7GnEg1RnDf8g7Z+QwlyRb72zy8W8jX3ao4jL7OlQ1w5/I rkqKjL50UFs/tOQr2Px/Qq5aPbFSa4nkzD/fSpR4m5xJyyqmHjbDc+x7nWDpGolp7M8l zXGXtOhDk64TBEyPryS8tsz+J37MmKZwEjETMIm5ZA6NVXca3uF1FcLRgAANeZlzV3Ud L7wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fUMxcx+u5/hn2ugWKcdPNPqXU1oigWR10T+6HK6PHPY=; b=DQ/5D67TUDnNRPcTRJ7CSou2PirUNlx9pashWo8X21u08jPlR/zxTOFCbfNlvix+QJ qI4zoiFNZGmLucvzh6ozP6c9PSnl9kkwUiWIei5WHDoeF8v3lr+wd3mbVUdO11UEqLSp jYw/jSJ9PlLA5bD3bfKnLvQz/VtoaSBFFtIvkKoP+xvar8mb4vz7x3g7+2REaUmiz8eX fUSLEeus9vrwDIZdbp8Sx0tXsQkUJcuPouTvPwvgpRldQwT0Tw5ANEc0Qd7Md/0Zid5n KkwPz5xAKh2SnOAq+opRSryF4q0KxUM2zTYZAj5rGmlms7xjGSHBnkFKnNBACK2hWlo0 odNg== X-Gm-Message-State: AOAM530ioU7bfWfT4TZlGNkgfcgqIGqGLr0BWZqZ4NpDpwbC/j1WYtH8 TW8zmjiway+IW3IkWfcrnS1pAw== X-Google-Smtp-Source: ABdhPJwvv1ACi5tPa4gWV5f7qwXgssJGaC9yWcNhrd4pKPcQQhmICv46FEOJ3s8/8eUloCzxJ0LyeQ== X-Received: by 2002:a65:508a:: with SMTP id r10mr10115726pgp.96.1633342781006; Mon, 04 Oct 2021 03:19:41 -0700 (PDT) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id q8sm8190081pja.52.2021.10.04.03.19.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 03:19:40 -0700 (PDT) Date: Mon, 4 Oct 2021 15:49:35 +0530 From: Sunil V L To: Daniel Schaefer Cc: devel@edk2.groups.io, Abner Chang , Leif Lindholm Subject: Re: [PATCH v1 1/5] U540, U500: Add filesystem drivers Message-ID: <20211004101935.GA83401@sunil-ThinkPad-T490> References: <20211003172359.1622768-1-daniel.schaefer@hpe.com> <20211003172359.1622768-2-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20211003172359.1622768-2-daniel.schaefer@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Looks good to me. Reviewed-by: Sunil V L Thanks Sunil On Mon, Oct 04, 2021 at 01:23:55AM +0800, Daniel Schaefer wrote: > Not DiskIoDxe because we don't have a disk, just for loading from > Ramdisks. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 ++++++- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 4 +++- > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 7 ++++++- > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 4 +++- > 4 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index 124f0d02cc..cdc1b9ee8f 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -1,7 +1,7 @@ > ## @file > # RISC-V EFI on SiFive VC707 (U500) RISC-V platform > # > -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -507,6 +507,11 @@ > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > + # > + # FAT filesystem + GPT/MBR partitioning + UDF filesystem > + # > + FatPkg/EnhancedFatDxe/Fat.inf > + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > ShellPkg/Application/Shell/Shell.inf { > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > index dac6f85272..f262e4fe17 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > @@ -1,7 +1,7 @@ > # @file > # Flash definition file on SiFive VC707 (U500) RISC-V platform > # > -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -178,6 +178,8 @@ INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf > +INF FatPkg/EnhancedFatDxe/Fat.inf > +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > !ifndef $(SOURCE_DEBUG_ENABLE) > INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > index db7905774a..be70ef5294 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > @@ -1,7 +1,7 @@ > ## @file > # RISC-V EFI on SiFive Freedom U540 HiFive Unleashed RISC-V platform > # > -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -506,6 +506,11 @@ > MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > > + # > + # FAT filesystem + GPT/MBR partitioning + UDF filesystem > + # > + FatPkg/EnhancedFatDxe/Fat.inf > + MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > ShellPkg/Application/Shell/Shell.inf { > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > index 5622e589d6..c0ce09fcee 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > @@ -1,7 +1,7 @@ > # @file > # Flash definition file on SiFive Freedom U540 HiFive Unleashed RISC-V platform > # > -# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2019-2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -178,6 +178,8 @@ INF MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabaseDxe.inf > INF MdeModulePkg/Universal/SetupBrowserDxe/SetupBrowserDxe.inf > INF MdeModulePkg/Universal/DisplayEngineDxe/DisplayEngineDxe.inf > INF MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryTestDxe.inf > +INF FatPkg/EnhancedFatDxe/Fat.inf > +INF MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > !ifndef $(SOURCE_DEBUG_ENABLE) > INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > -- > 2.33.0 >