From: Sunil V L <sunilvl@ventanamicro.com>
To: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: devel@edk2.groups.io, Abner Chang <abner.chang@hpe.com>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure
Date: Mon, 4 Oct 2021 16:09:42 +0530 [thread overview]
Message-ID: <20211004103942.GB83401@sunil-ThinkPad-T490> (raw)
In-Reply-To: <20211003172359.1622768-3-daniel.schaefer@hpe.com>
On Mon, Oct 04, 2021 at 01:23:56AM +0800, Daniel Schaefer wrote:
> While enumerating the PCIe devices, the driver tries to set some caching
> attributes on the memory.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
>
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
> Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c b/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c
> index 27a07b1561..b8b8e91a6c 100644
> --- a/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c
> +++ b/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c
> @@ -1,7 +1,7 @@
> /** @file
> RISC-V CPU DXE driver.
>
> - Copyright (c) 2016 - 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> + Copyright (c) 2016 - 2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -269,7 +269,7 @@ CpuSetMemoryAttributes (
> )
> {
> DEBUG ((DEBUG_INFO, "%a: Set memory attributes not supported yet\n", __FUNCTION__));
> - return EFI_UNSUPPORTED;
> + return EFI_SUCCESS;
Looks good to me.
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
Thanks
Sunil
> }
>
> /**
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-10-04 10:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 17:23 [PATCH v1 0/5] Improvements for booting to Linux on RISC-V Daniel Schaefer
2021-10-03 17:23 ` [PATCH v1 1/5] U540, U500: Add filesystem drivers Daniel Schaefer
2021-10-04 10:19 ` Sunil V L
2021-10-03 17:23 ` [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure Daniel Schaefer
2021-10-04 10:39 ` Sunil V L [this message]
2021-10-03 17:23 ` [PATCH v1 3/5] U540, U500: Add initrd command to boot Linux Daniel Schaefer
2021-10-04 10:45 ` Sunil V L
2021-10-04 11:07 ` Daniel Schaefer
2021-10-03 17:23 ` [PATCH v1 4/5] U540: BuildCpuHob with 48 to indicate size memory space Daniel Schaefer
2021-10-04 11:02 ` Sunil V L
2021-10-04 11:26 ` Abner Chang
2021-10-03 17:23 ` [PATCH v1 5/5] Signal EndOfDxe in boot manager Daniel Schaefer
2021-10-04 11:07 ` Sunil V L
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004103942.GB83401@sunil-ThinkPad-T490 \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox