From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web09.7528.1633343988101069798 for ; Mon, 04 Oct 2021 03:39:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=gw7JVazA; spf=pass (domain: ventanamicro.com, ip: 209.85.216.42, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f42.google.com with SMTP id qe4-20020a17090b4f8400b0019f663cfcd1so7905477pjb.1 for ; Mon, 04 Oct 2021 03:39:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GT3HXl4kEiRm6FPR8N6vOWnAl6lOmt29U4AVyu6Y4eA=; b=gw7JVazAA7tEH7uEz5eDEAT82KwlmM4lkZNUcEK/LFN7PQd2YlkXjUxyqTnB5vj4Iv 3hze3Ql9MvmrRkmx6jVlmYBoKUn0NKTVy0cRzqscyEdloRyAySauasI/bdHczVWRWIQk jhMjzrRBX66zUTUTzFSj15onglSPC0IUFPVGGXpXj5oT6aIizZ+hXSRWUxJNdoXreZIT dalrPNTXDTETDzJI79U0Qs1mZb5QbmbKsit2edXuv9FDMNZfgTQ3lg3ZNKRVgic+kFQi JhtiSYj+boadOrpimwiSflyfLpOPNYnQafxvwjgmSQRpGnTgwncik2DM/Fx8GhHkwhcA JsjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GT3HXl4kEiRm6FPR8N6vOWnAl6lOmt29U4AVyu6Y4eA=; b=6+H3jIJNQsatNFhyGAMLvCqrRW4FxBW1FKqEI/vUuauTNlFZqVAzVoMMOjz/txAaeL cGHgBlXMOUdf1Wc+PIOpDC2619ZcMik1/VGf6fusvXhTURKnoDjnmQQVK1byzpwkRJeL c62N+FFuJMcoXPvCXNCJJkWV5P3vY+vjnxLsCSmBKbdEse6qKAyOKCQMZ0zzI3vqy7Ot Rq0xBp/v7AVgh8YT4AV1cLvsJ+8kiKM+Pif1VLe0mY0TIK5ltJ9Q9NbgsffEWCkUrWcf sEEfQOoPz8o1K8tTYkawacfBDURFo8wtJpVXJRyCOLNFRM2C39DmNk9qjLsNGM9SRMRe euMw== X-Gm-Message-State: AOAM53168ohDOr0O46+8KPeTGyP8FTKVLGUS15dCmmKMyP/46jqDHRou kbiaIfQ5b6wf4fHiDmbSVzQkug== X-Google-Smtp-Source: ABdhPJybarPXrBJbtT/um0Ev0Fqr5T7Ip/qhRir3SEBCtdldExJ6sZEZ5KP8Fad5OQrY+eHlyqLoEA== X-Received: by 2002:a17:90b:4c92:: with SMTP id my18mr13471474pjb.246.1633343987610; Mon, 04 Oct 2021 03:39:47 -0700 (PDT) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id s25sm13980209pfm.138.2021.10.04.03.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 03:39:47 -0700 (PDT) Date: Mon, 4 Oct 2021 16:09:42 +0530 From: Sunil V L To: Daniel Schaefer Cc: devel@edk2.groups.io, Abner Chang , Leif Lindholm Subject: Re: [PATCH v1 2/5] RISC-V/CpuDxe: Ignore set memory attributes failure Message-ID: <20211004103942.GB83401@sunil-ThinkPad-T490> References: <20211003172359.1622768-1-daniel.schaefer@hpe.com> <20211003172359.1622768-3-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20211003172359.1622768-3-daniel.schaefer@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 04, 2021 at 01:23:56AM +0800, Daniel Schaefer wrote: > While enumerating the PCIe devices, the driver tries to set some caching > attributes on the memory. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c b/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c > index 27a07b1561..b8b8e91a6c 100644 > --- a/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c > +++ b/Silicon/RISC-V/ProcessorPkg/Universal/CpuDxe/CpuDxe.c > @@ -1,7 +1,7 @@ > /** @file > RISC-V CPU DXE driver. > > - Copyright (c) 2016 - 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> + Copyright (c) 2016 - 2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > @@ -269,7 +269,7 @@ CpuSetMemoryAttributes ( > ) > { > DEBUG ((DEBUG_INFO, "%a: Set memory attributes not supported yet\n", __FUNCTION__)); > - return EFI_UNSUPPORTED; > + return EFI_SUCCESS; Looks good to me. Reviewed-by: Sunil V L Thanks Sunil > } > > /** > -- > 2.33.0 >