Re: [PATCH v1 5/5] Signal EndOfDxe in boot manager

[Sunil V L <sunilvl@ventanamicro.com>]

On Mon, Oct 04, 2021 at 01:23:59AM +0800, Daniel Schaefer wrote:
> Otherwise we can't load a 3rd party image because we're still in DXE.
> MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c prevents
> that.
> 
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Sunil V L <sunilvl@ventanamicro.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> 
> Signed-off-by: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
>  Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c      | 7 ++++++-
>  Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 3 ++-
>  2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> index 82cd311df5..d67f4836fc 100644
> --- a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> +++ b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> @@ -1,7 +1,7 @@
>  /** @file
>    This file include all platform actions
>  
> -Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
>  Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>  
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -155,6 +155,11 @@ PlatformBootManagerBeforeConsole (
>    EFI_INPUT_KEY                F2;
>    EFI_BOOT_MANAGER_LOAD_OPTION BootOption;
>  
> +  //
> +  // Signal EndOfDxe PI Event
> +  //
> +  EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid);
> +
>    //
>    // Update the console variables.
>    //
> diff --git a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> index afba07573f..2bf89a3c44 100644
> --- a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> +++ b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Include all platform action which can be customized by IBV/OEM.
>  #
> -#  Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
> +#  Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights reserved.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -48,6 +48,7 @@
>    PrintLib
>  
>  [Guids]
> +  gEfiEndOfDxeEventGroupGuid

Looks good to me.

Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>

Thanks
Sunil
>  
>  [Protocols]
>    gEfiGenericMemTestProtocolGuid  ## CONSUMES
> -- 
> 2.33.0
>