From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mx.groups.io with SMTP id smtpd.web11.7775.1633345631462279447 for ; Mon, 04 Oct 2021 04:07:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=nvKQAoUj; spf=pass (domain: ventanamicro.com, ip: 209.85.215.176, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pg1-f176.google.com with SMTP id s75so5297496pgs.5 for ; Mon, 04 Oct 2021 04:07:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2upy3myV7ljfoC9UuNUK1FrpewQwrJWZnGKKLYuiPTI=; b=nvKQAoUj37u0Afw58pxlZ1OfnI3muqVLqyGxuo70mjug+hnFxJgG5fRKlv7ivSizkO tHw0Sk1/vV5E4GY/FSSQkQ0lRU4/Xumk4wVmteStHz0a0tpZWYeD+o+yBXCXNT6zNOeR kgAcnfIkDwbL/caB3T16Sa6ISRRi4NkWqMaYSsoZBAAvYLC9JqxJ5RgbkGXmZNVXhHYz bqtAKBBJK5jUfbPfQJH5Ldq6/t5y8BLREX1zZw785jx4Wz01pIa1fROB6gkhVIQn4c4/ uyeZxn/VQtc6AwAohHz35IAtm6o8FvmQ0DIWx9mdhegySl45+QRkF5EKn61xwQiJL/la sb8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2upy3myV7ljfoC9UuNUK1FrpewQwrJWZnGKKLYuiPTI=; b=0yFmMCFFoZi5FkLg96xGEHI9YXfEXpUbWvpFniUeFoS/f3zyNky+0QLJKiFUb62asu wtxpiTESkmtG8ZTAv2JjMpe3qqTezS2fRMhNQGwDVw17julbhhjcfuDyctjRpYEPu1c1 4XM5qXjLeYI29LP7usSLNc6G3dqt5HYkw6GD5prnkmTfM+yTUIpEwgeM/uojUrfM5TQq nEq3B/3YPDMYQH1/TLJuLDrbTZkyI/JhHVo2sCefS7VW8n2no4HFXlrWOd7p9cG1Dg/A /hFfB5d91XZRXoXoYqRTuUHnl5JYbYDYNQSsgTK9KFuWhhoD/WAUY0SdSjplJcry16KT Npww== X-Gm-Message-State: AOAM532cX4WpvNVGoqPIz/tx1c4N3HOzDiKA8oQdFx1YqIRTUOhbUEVD 8lQnY8G8GE4Ss4bAiXLoiq/6YStAGsg8Jg== X-Google-Smtp-Source: ABdhPJwP24wGxI6pq+dpjFfloGTyH1GOHO0gD8qB1yki8XI8K0sMQruLPmmDoa7x6kXcfdvfQ/67ZA== X-Received: by 2002:a62:5101:0:b0:44c:5cc3:e088 with SMTP id f1-20020a625101000000b0044c5cc3e088mr5698277pfb.72.1633345631038; Mon, 04 Oct 2021 04:07:11 -0700 (PDT) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id o5sm15359330pjg.40.2021.10.04.04.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 04:07:10 -0700 (PDT) Date: Mon, 4 Oct 2021 16:37:05 +0530 From: Sunil V L To: Daniel Schaefer Cc: devel@edk2.groups.io, Abner Chang , Leif Lindholm Subject: Re: [PATCH v1 5/5] Signal EndOfDxe in boot manager Message-ID: <20211004110705.GE83401@sunil-ThinkPad-T490> References: <20211003172359.1622768-1-daniel.schaefer@hpe.com> <20211003172359.1622768-6-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20211003172359.1622768-6-daniel.schaefer@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 04, 2021 at 01:23:59AM +0800, Daniel Schaefer wrote: > Otherwise we can't load a 3rd party image because we're still in DXE. > MdeModulePkg/Universal/SecurityStubDxe/Defer3rdPartyImageLoad.c prevents > that. > > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 7 ++++++- > Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 3 ++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > index 82cd311df5..d67f4836fc 100644 > --- a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > +++ b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c > @@ -1,7 +1,7 @@ > /** @file > This file include all platform actions > > -Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> Copyright (c) 2015, Intel Corporation. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -155,6 +155,11 @@ PlatformBootManagerBeforeConsole ( > EFI_INPUT_KEY F2; > EFI_BOOT_MANAGER_LOAD_OPTION BootOption; > > + // > + // Signal EndOfDxe PI Event > + // > + EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); > + > // > // Update the console variables. > // > diff --git a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index afba07573f..2bf89a3c44 100644 > --- a/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/Platform/RISC-V/PlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -1,7 +1,7 @@ > ## @file > # Include all platform action which can be customized by IBV/OEM. > # > -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -48,6 +48,7 @@ > PrintLib > > [Guids] > + gEfiEndOfDxeEventGroupGuid Looks good to me. Reviewed-by: Sunil V L Thanks Sunil > > [Protocols] > gEfiGenericMemTestProtocolGuid ## CONSUMES > -- > 2.33.0 >