From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mx.groups.io with SMTP id smtpd.web12.10169.1633357597296971591 for ; Mon, 04 Oct 2021 07:26:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@ventanamicro.com header.s=google header.b=UmPeKD5D; spf=pass (domain: ventanamicro.com, ip: 209.85.216.53, mailfrom: sunilvl@ventanamicro.com) Received: by mail-pj1-f53.google.com with SMTP id me5-20020a17090b17c500b0019af76b7bb4so4618042pjb.2 for ; Mon, 04 Oct 2021 07:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vj8C0sAuMWZofLDoWZw32br5UHJoti6UOxjUejJ7AEA=; b=UmPeKD5D8htT7ao42dLmb9h6G3N41W0jzqJh+RWyd8VhnMCHAneBva9f61b5sVMQnj 1ujGle0lORvVViX0W8dVu946wcDbZpeSUUgUBW43RmwVmXRjxOgiJWvq8cM5HGShAg6i Du6T2Wu11dhqQIDtDDP/ViTt1/qokPt6tBW06aIxCvFI+bDBybTl+euAuuhy4v7YXNtw YcPVIPM3Q+/QznqYpC0v/8cJ3+UMaigR7VQNpWAjI1igtr3pN8fL6ZF4sdkImjTvmt7x 9MgY/MVl2WxDPm4Pb1QbA6LOAuF27bBB3B9RILCaTaJgOTaPwMJgOUIhOc3DEqYyMTJh grPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vj8C0sAuMWZofLDoWZw32br5UHJoti6UOxjUejJ7AEA=; b=B7pdPfeWdD0l4xpgof7nu1G1DnPuK8roupLGKm7IzVEjOGNP1FmiAXmwEkdlc9eMpP S+59i5f4dEb+lm/8rY4ZJmH4QapSOmbm3Z5ryLFjg0jyKl1uMxe7oF0R+hLmMpqQ3q2l lIBMtqALTNHUFK3yNkbp+cvy92uOqnLi4jOGQUQUSIc0pFmIKsYwXEbamZD6Rp+85Pt8 BIiJf0e33dCRDKRU0MlljyG5fHUpYKLYDxF1q2/ZCY6qSe5xe8N5rBE91lZWpItzPfXn Yk0lscyU0lhPpl+IiLUKgZdkaBmqFrilPCy1cLhOR6u1SEzli/B+BUJ0pZI+tsL66skk ScWg== X-Gm-Message-State: AOAM530L8pXfvug5nOJioIQ1hVCLpNSr5vvpACa8IcQ4qVkW8KsHd71e 3NAaggPiBZ9OBh0fwLbCtGOePw== X-Google-Smtp-Source: ABdhPJxRegPigXLK1CkwF9z12TvKmK3bg//BGuZDnIuXfRvaAEFKI8han/D22OHUqej/vnT1Qwp7Ag== X-Received: by 2002:a17:90a:304:: with SMTP id 4mr36797732pje.124.1633357596808; Mon, 04 Oct 2021 07:26:36 -0700 (PDT) Return-Path: Received: from sunil-ThinkPad-T490 ([49.206.3.187]) by smtp.gmail.com with ESMTPSA id d137sm15176055pfd.72.2021.10.04.07.26.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 07:26:36 -0700 (PDT) Date: Mon, 4 Oct 2021 19:56:31 +0530 From: "Sunil V L" To: Daniel Schaefer Cc: devel@edk2.groups.io, Abner Chang , Leif Lindholm Subject: Re: [edk2-platforms][PATCH v2 3/5] U540, U500: Add initrd command to boot Linux Message-ID: <20211004142631.GA95454@sunil-ThinkPad-T490> References: <20211004112829.3385183-1-daniel.schaefer@hpe.com> <20211004112829.3385183-4-daniel.schaefer@hpe.com> MIME-Version: 1.0 In-Reply-To: <20211004112829.3385183-4-daniel.schaefer@hpe.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 04, 2021 at 07:28:27PM +0800, Daniel Schaefer wrote: > Cc: Abner Chang > Cc: Sunil V L > Cc: Leif Lindholm > > Signed-off-by: Daniel Schaefer > --- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 ++++++- > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 1 + > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 7 ++++++- > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 1 + > 4 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index cdc1b9ee8f..9f0a25f8a6 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -97,6 +97,7 @@ > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > @@ -513,6 +514,11 @@ > FatPkg/EnhancedFatDxe/Fat.inf > MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > + > ShellPkg/Application/Shell/Shell.inf { > > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > @@ -524,7 +530,6 @@ > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > index f262e4fe17..5f3ac8e0b7 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf > @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > +INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > INF ShellPkg/Application/Shell/Shell.inf > > # > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > index be70ef5294..afe63c80ba 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > @@ -97,6 +97,7 @@ > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > @@ -512,6 +513,11 @@ > FatPkg/EnhancedFatDxe/Fat.inf > MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf > > + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf { > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + } > + > ShellPkg/Application/Shell/Shell.inf { > > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > @@ -523,7 +529,6 @@ > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.inf > - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > index c0ce09fcee..a1a4b342e3 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf > @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > > INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > +INF OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf > INF ShellPkg/Application/Shell/Shell.inf Looks good to me. Reviewed-by: Sunil V L Regards Sunil > > # > -- > 2.33.0 >