From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.groups.io with SMTP id smtpd.web09.9100.1633597593951090169 for ; Thu, 07 Oct 2021 02:06:34 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=rEnzvujs; spf=pass (domain: nuviainc.com, ip: 209.85.221.52, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f52.google.com with SMTP id k7so16728796wrd.13 for ; Thu, 07 Oct 2021 02:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ygCuOz87VUUclN4TPWZ9UzbZBbwIBf2Xffyr3ymBsyE=; b=rEnzvujsvzxI9TF3LRuRw0Kmze+6eBoQcMTkEhXTMPyQcLZxTPovYM1c/cwS1okIDt fcQt3Y4mNHd8AmXkYVWnG48P5YpOYPaZGDaoMFddEUiIIqHz+s2qiHO3ZVw5XZXJKNh3 idiOKU2fwqH4t7BgOwR24HUJpEZY3EvB2qALb3pNPC64v5UFh9MRmBwpL5Z7/Ego5trp OoLw3figGJD9XTgu5ADe9OtIWuj7hMOSSar/aPls3E2dfAC/JXL3uL1eqfTR/44N9fBY OT8202SX5qUDPzWG7VXzCf/DVjHeCRauhWE4rTnc252AzsLhzarfytSrRysLqglT7GfM WV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ygCuOz87VUUclN4TPWZ9UzbZBbwIBf2Xffyr3ymBsyE=; b=eXEGSjVP7W6Br1HCmK8bGV2sxWMbgbbv22iuEGe+9MG6l9ON0OysOXqVYbAunLPD0h YsDd+Cih6jfUJW5nNc3HRpefa6o2N8PGNhrxH/Qlm5jNBHZdVQBrDo4sTHDXlAgRpnkP LE2HFtTBHau5znZZjuC5haFM2pNGjUZLy1sYZphyx9XGB1c//iRzqRp+6A4t2cQ7nvTN S05mfMcuHp7CFI/46lsFekLJ7uo7Xg8LPqZe6PKPuGy9wQ26HD3WpkHuQJdhNAXHcvow N8pXN3mWyPaMkT6AEqlyjkHc7VnFcfVT40IBkCXc2mkt/k4Qjb9pLm5oD6cKqL7bE8DO QeNw== X-Gm-Message-State: AOAM533J+8tc8SHC1zDkNJUMkSpzlPn/J+6hkehLVXensaLlzh/3RGk2 aZNkaCQnxCZ2qz2TN4fLtJmn0w== X-Google-Smtp-Source: ABdhPJyaIJDEnyt8d4UvacIddYMZxhMKLDg39tBj4FwR5GC5JIEg63pZwLEt5cZDiU9MAl3aVbdS7w== X-Received: by 2002:adf:aa4e:: with SMTP id q14mr3880898wrd.100.1633597592278; Thu, 07 Oct 2021 02:06:32 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id y6sm12802299wro.63.2021.10.07.02.06.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Oct 2021 02:06:31 -0700 (PDT) Date: Thu, 7 Oct 2021 10:06:29 +0100 From: "Leif Lindholm" To: Nhi Pham Cc: devel@edk2.groups.io, patches@amperecomputing.com, vunguyen@os.amperecomputing.com, Thang Nguyen , Chuong Tran , Phong Vo , Michael D Kinney , Ard Biesheuvel , Nate DeSimone Subject: Re: [edk2-devel] [PATCH v3 12/28] AmpereAltraPkg: Add Ac01PcieLib library instance Message-ID: <20211007090629.uxvy2vghq76tetvd@leviathan> References: <20210915155527.8176-1-nhi@os.amperecomputing.com> <20210915155527.8176-13-nhi@os.amperecomputing.com> <20210923134931.gzxueebb4axflhdi@leviathan> <20211005195953.eqmym4dkkkpqatik@leviathan> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 06, 2021 at 19:55:53 +0700, Nhi Pham wrote: > > Would it be possible for PHYLib to link in ArmArchTimerLib directly > > and wrap this there instead? Something about this integration just > > feels kind of backwards to me. > > Thanks Leif. That's great idea. > > I will wrap it and re-send the patchset for PHYLib in the edk2-non-osi > repository as well. Thanks! Actually, if you do that, can you have a look at the coding style of some the enums in Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h ? They have enumerations in UPPER_CASE_WITH_UNDERSCORES instead of CamelCase. I noticed these after giving my r-b, so didn't bother bringing it up, but if you're refreshing the patch anyway... / Leif