From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.groups.io with SMTP id smtpd.web11.7481.1633689268604572299 for ; Fri, 08 Oct 2021 03:34:29 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=7lEtl5I+; spf=pass (domain: nuviainc.com, ip: 209.85.221.52, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f52.google.com with SMTP id u18so28375233wrg.5 for ; Fri, 08 Oct 2021 03:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7ySUNLLlx2WMYavyUWbNqBsn9VHJZo5qfoRug+K7QHU=; b=7lEtl5I+k0puE+I047aTXmNBhBp6VD+lUYeAVIcOx0G3mZ398loQXWaE8RPgI78Tnp fu1SgFz3eEFxCQwvw+WksgHOD+1Lanz8Dxfa7cvFgBqImBYArMMQQcWGYl9x+N5A73S1 zxeGfMzbTRs4EMgofVGIdySo47kXzUzi45YDIl2t9xvqZ9qs+WoeZ/VtR22T1jcPGr8J aHRBOVreQupN1KDFSR2UxaRXyRNepNLrlAFNnulsMqzPlqEuZMxIgn9WNKMkTXvmaCCX z1M9Ms3v9INnct8dyqWgUx/DVwPQTuN9y+Yoy4XUleiygmfGmWv/8IUfrD+ibiEkEUtc c7Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=7ySUNLLlx2WMYavyUWbNqBsn9VHJZo5qfoRug+K7QHU=; b=azDMMi/oNZVSAUxF4kVp9W74chy3gnp2pInTeL5RTct9FvWV+UNrpEK/b9TPcYtDg5 x42cTSZ7QbQhiYHHnXbAG/Np9HQCvzCObuWIQZTNgowZZVmtfRR9zyCYK+J3vz9Vj82y v/hLYUva1mjaoX+fTn6quk97W9X5Eibz1jQrYGj3adEziTBnIEIJs2yrgiawCSj/M4y2 Lbh1AFt4G4/eQvpjK5tQQZP+tt4tRsbxhicdOKmml+E4eiYYHnzegidObjZXZ8RtohXH CR+KJWdDVsTrPp49LA3r77jOlrivL9xtoCwZDK4+PvOOVKxrdeQAHwNSWExj0YmDGcuR 2vMw== X-Gm-Message-State: AOAM530ye+XuQVFSPwvxYpDd8TGrHnPrxDDTje01QMQjvvQ+VfLK9ILI mfoQbUDvZ5a/Hvqywju9Dx7ZpXVuMHqLcQbAK1epvYn2nkL6wLi/VVlHTFUObYaypF0X3mYGzcU vYL/i0PNCsNZYW/UWFGFJZ+vlq5lZdlc7/68KfI7AhrG0FAcrIgIm2K7qYqxx7sBO4vt8 X-Google-Smtp-Source: ABdhPJy82uDhG0DkQYZM779svCiw3s2+sxCtjrcYd92/Yu37XRFiQhYDTPc1UNbjSyxPLgpdDLdbhA== X-Received: by 2002:adf:a54f:: with SMTP id j15mr2965625wrb.218.1633689266821; Fri, 08 Oct 2021 03:34:26 -0700 (PDT) Return-Path: Received: from qc-i7.hemma.eciton.net (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id x15sm2178303wrl.74.2021.10.08.03.34.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 03:34:26 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: [PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT Date: Fri, 8 Oct 2021 11:34:25 +0100 Message-Id: <20211008103425.1810992-1-leif@nuviainc.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MADT GICC structure contains the field PhysicalBaseAddress, which is needed for a GICv1/v2 implementation, or to indicate legacy compatibility in modern GICs. Linux commit 9739f6ef053f1, included in v5.12, adds a warning message when this field is populated but invalid: [Firmware Bug]: CPU interface incapable of MMIO access As it happens, we currently initialize this to PcdGicDistributorBase instead of PcdGicInterruptInterfaceBase, and as a result we now trigger this warning. Since this is an SBSA reference implementation, and legacy GIC support has never worked for this port, set the field to 0. Signed-off-by: Leif Lindholm Cc: Ard Biesheuvel Cc: Graeme Gregory Cc: Radoslaw Biernacki --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c index b8901030ecd0..dbc5e9475358 100644 --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c @@ -71,7 +71,7 @@ AddMadtTable ( 0, /* Mpidr */ EFI_ACPI_6_0_GIC_ENABLED, /* Flags */ SBSAQEMU_MADT_GIC_PMU_IRQ, /* PMU Irq */ - FixedPcdGet32 (PcdGicDistributorBase), /* PhysicalBaseAddress */ + 0, /* PhysicalBaseAddress */ SBSAQEMU_MADT_GIC_VBASE, /* GicVBase */ SBSAQEMU_MADT_GIC_HBASE, /* GicHBase */ 25, /* GsivId */ -- 2.30.2