* [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
@ 2021-10-10 19:48 Mark Kettenis
2021-10-10 20:15 ` Mark Kettenis
2021-10-10 21:10 ` [edk2-devel] " Ard Biesheuvel
0 siblings, 2 replies; 4+ messages in thread
From: Mark Kettenis @ 2021-10-10 19:48 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, pete, jeremy.linton, Mark Kettenis
The MMIO host bridge window isn't translated as both the primary
and secondary side are MMIO. So remove the incorrect
TypeTranslation attribute.
Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
index ee37b7a21e..f485c6b5d2 100644
--- a/Platform/RaspberryPi/AcpiTables/Pci.asl
+++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
@@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
2 // SANITIZED_PCIE_MMIO_LEN + 1
- ,,,MMI1,,TypeTranslation
+ ,,,MMI1
)
// root port registers, not to be used if SMCCC is utilized
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
2021-10-10 19:48 [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute Mark Kettenis
@ 2021-10-10 20:15 ` Mark Kettenis
2021-10-10 21:10 ` [edk2-devel] " Ard Biesheuvel
1 sibling, 0 replies; 4+ messages in thread
From: Mark Kettenis @ 2021-10-10 20:15 UTC (permalink / raw)
To: Mark Kettenis; +Cc: devel, ardb+tianocore, leif, pete, jeremy.linton, kettenis
Sorry. Used an old mail address for ardb. Can resend this if necessary.
> From: Mark Kettenis <kettenis@openbsd.org>
> Date: Sun, 10 Oct 2021 21:48:14 +0200
>
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO. So remove the incorrect
> TypeTranslation attribute.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
> Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
> 1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
> SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
> 2 // SANITIZED_PCIE_MMIO_LEN + 1
> - ,,,MMI1,,TypeTranslation
> + ,,,MMI1
> )
>
> // root port registers, not to be used if SMCCC is utilized
> --
> 2.33.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
2021-10-10 19:48 [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute Mark Kettenis
2021-10-10 20:15 ` Mark Kettenis
@ 2021-10-10 21:10 ` Ard Biesheuvel
2021-10-14 21:05 ` Jeremy Linton
1 sibling, 1 reply; 4+ messages in thread
From: Ard Biesheuvel @ 2021-10-10 21:10 UTC (permalink / raw)
To: edk2-devel-groups-io, mark.kettenis
Cc: Ard Biesheuvel, Leif Lindholm, Peter Batard, Jeremy Linton,
Mark Kettenis
On Sun, 10 Oct 2021 at 21:48, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO. So remove the incorrect
> TypeTranslation attribute.
>
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
Pushed as bbb431a0c658..ab6fcc28fd99
Thanks,
> ---
> Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
> 1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
> SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
> 2 // SANITIZED_PCIE_MMIO_LEN + 1
> - ,,,MMI1,,TypeTranslation
> + ,,,MMI1
> )
>
> // root port registers, not to be used if SMCCC is utilized
> --
> 2.33.0
>
>
>
> ------------
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
> Mute This Topic: https://groups.io/mt/86221449/1131722
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
> ------------
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
2021-10-10 21:10 ` [edk2-devel] " Ard Biesheuvel
@ 2021-10-14 21:05 ` Jeremy Linton
0 siblings, 0 replies; 4+ messages in thread
From: Jeremy Linton @ 2021-10-14 21:05 UTC (permalink / raw)
To: Ard Biesheuvel, edk2-devel-groups-io, mark.kettenis
Cc: Ard Biesheuvel, Leif Lindholm, Peter Batard, Mark Kettenis
Hi,
On 10/10/21 4:10 PM, Ard Biesheuvel wrote:
> On Sun, 10 Oct 2021 at 21:48, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>>
>> The MMIO host bridge window isn't translated as both the primary
>> and secondary side are MMIO. So remove the incorrect
>> TypeTranslation attribute.
>>
>> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>
> Pushed as bbb431a0c658..ab6fcc28fd99
>
> Thanks,
>
>> ---
>> Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
>> index ee37b7a21e..f485c6b5d2 100644
>> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
>> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
>> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>> 1, // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
>> SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
>> 2 // SANITIZED_PCIE_MMIO_LEN + 1
>> - ,,,MMI1,,TypeTranslation
>> + ,,,MMI1
>> )
Its a bit late, but this looks fine.
THanks!
>>
>> // root port registers, not to be used if SMCCC is utilized
>> --
>> 2.33.0
>>
>>
>>
>> ------------
>> Groups.io Links: You receive all messages sent to this group.
>> View/Reply Online (#81734): https://edk2.groups.io/g/devel/message/81734
>> Mute This Topic: https://groups.io/mt/86221449/1131722
>> Group Owner: devel+owner@edk2.groups.io
>> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ardb@kernel.org]
>> ------------
>>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-14 21:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-10 19:48 [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute Mark Kettenis
2021-10-10 20:15 ` Mark Kettenis
2021-10-10 21:10 ` [edk2-devel] " Ard Biesheuvel
2021-10-14 21:05 ` Jeremy Linton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox