From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.10266.1634022134911546723 for ; Tue, 12 Oct 2021 00:02:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bAcDjAC1; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634022133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1D+gduSbnF33j2K51Os6fpehUNSviyMaWB4rCCYuaUo=; b=bAcDjAC1cUWTnUZfmQ1kt7V0EF9Kx4bUfwfLrEHdzFpHLsztLqAWa8rD19YK6rOJkNRkMY lufd4zc5yWs6OPil+UwSN2WsAco93mwlyzsx9qAMIgXHh9l7RqObl+DJI2JxKV9dz2SPlK yXsKV4P56FAIxi2Fc+Gaa2cMZIQ8yU4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-9Tn3y_rQMUCXsfVu5-WBpQ-1; Tue, 12 Oct 2021 03:02:09 -0400 X-MC-Unique: 9Tn3y_rQMUCXsfVu5-WBpQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24D1584A5E4; Tue, 12 Oct 2021 07:02:07 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B986C5C1B4; Tue, 12 Oct 2021 07:02:06 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 0741A1800393; Tue, 12 Oct 2021 09:02:05 +0200 (CEST) Date: Tue, 12 Oct 2021 09:02:05 +0200 From: "Gerd Hoffmann" To: Min Xu Cc: devel@edk2.groups.io, Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky Subject: Re: [PATCH V9 1/4] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector Message-ID: <20211012070205.manhwbn663xwhpja@sirius.home.kraxel.org> References: <02adf7fc59d9e9d8d550f589d009c4db4126039a.1634005437.git.min.m.xu@intel.com> MIME-Version: 1.0 In-Reply-To: <02adf7fc59d9e9d8d550f589d009c4db4126039a.1634005437.git.min.m.xu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Oct 12, 2021 at 10:37:47AM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Previously OvmfPkg/ResetVector uses the Main.asm in > UefiCpuPkg/ReseteVector/Vtf0. In this Main.asm there is only Main16 > entry point. > > This patch-set is to introduce Intel TDX into Ovmf. Main32 entry point > is needed in Main.asm by Intel TDX. To reduce the complexity of Main.asm > in UefiCpuPkg, OvmfPkg create its own Main.asm to meet the requirement > of Intel TDX. > > UefiCpuPkg/ResetVector/Vtf0/main.asm -> OvmfPkg/ResetVector/Main.asm You should mention that this is an unmodified copy (so no functional change) and the actual changes for tdx come as incremental patches. With that: Acked-by: Gerd Hoffmann take care, Gerd