From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mx.groups.io with SMTP id smtpd.web11.11756.1634033869819051669 for ; Tue, 12 Oct 2021 03:17:50 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=rnG1XUzs; spf=pass (domain: nuviainc.com, ip: 209.85.221.54, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f54.google.com with SMTP id o20so65148000wro.3 for ; Tue, 12 Oct 2021 03:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4ke8oCWAipRxM6fZZGPBu1xoApHbW/Lha6jrUwivKJ8=; b=rnG1XUzsFMLhv2HhrLP2SnVCCru74KvSG/q+5w+6oFU14isYDMO+wkRZZGhiSdd4+V knAZxb0AEiI/IDLtEq929Zw8Wj2XeQNEtbQoBXDOJF5SKrlm2DW/9wpKXqsVqQGbrgrc x+hv2Qe6x+n9SwXeno0SL8GlGe1ZlBzfMUXAztazLyKNgJip5xXvP0W3LIzzLpt5amfv uWovR2LnrR4OYxHqxhnMQ8yXRCV4zaQ0rDsYdc77KBjkeTrrYro7zIXEWktjHQKa1qMl QJgTDg+9tlp0tNrWHFK9puvIAOHlny8yDS6DP/0QkdYjPsyLAPL4rmdFoc6E14HY0RpU +s+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4ke8oCWAipRxM6fZZGPBu1xoApHbW/Lha6jrUwivKJ8=; b=ClgAPyYBH4Tb9BoEBdWet2w3QMcHGP3vSMKv7+WgTLWbW1j+MXGXNiL8c/0Q3GAQEJ vbE/PW6/f7ZnLuHmbeyMhyGz3+GakZrBRkVluybcgHr09fbiMPIG01k0w1G/CEO6woB1 cRaQb0yqL/b+dZSyCx58dsChMFcRdARmbyXcuvDbFhDj7H/EcKCMv/M+kFjVFgsE8nGV rjhioUxoaetGSWE/YWzmFuUCAPPHJjafR+aORryDrzBkx91wNfPVVe4Xh2wNWL91n+2A U+K30Fba9nr9H4ActNGcsQsnriiX2BERw6kb5QpCzcpRXDwWig+rHmXXB2mkvApC+tQB O/Tg== X-Gm-Message-State: AOAM530yOg8fVFStkOaWV6wzO+/e/nsZlvo9kCseXRgypi38VzmzQeTz WS6S7dsiViscsjZADtbtyd/6nQ== X-Google-Smtp-Source: ABdhPJx7R3v6mdSAP+ZUfGxsnjH+SXEfg2Bg5HR8dZItC1tN0P3FvV6ef3yt6Eu09FPs21E3xFT1jg== X-Received: by 2002:a05:600c:21c4:: with SMTP id x4mr4621740wmj.111.1634033868228; Tue, 12 Oct 2021 03:17:48 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id o1sm10454080wru.91.2021.10.12.03.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Oct 2021 03:17:47 -0700 (PDT) Date: Tue, 12 Oct 2021 11:17:45 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Ard Biesheuvel , Graeme Gregory , Radoslaw Biernacki Subject: Re: [PATCH edk2-platforms 1/1] Silicon/Qemu: don't advertise GICC legacy mmio interface in SbsaQamu MADT Message-ID: <20211012101745.2l2zpdlx4pfwilid@leviathan> References: <20211008103425.1810992-1-leif@nuviainc.com> MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 08, 2021 at 16:18:44 +0200, Ard Biesheuvel wrote: > On Fri, 8 Oct 2021 at 12:34, Leif Lindholm wrote: > > > > The MADT GICC structure contains the field PhysicalBaseAddress, which > > is needed for a GICv1/v2 implementation, or to indicate legacy > > compatibility in modern GICs. > > > > Linux commit 9739f6ef053f1, included in v5.12, adds a warning message > > when this field is populated but invalid: > > [Firmware Bug]: CPU interface incapable of MMIO access > > > > As it happens, we currently initialize this to PcdGicDistributorBase > > instead of PcdGicInterruptInterfaceBase, and as a result we now trigger > > this warning. > > > > Since this is an SBSA reference implementation, and legacy GIC support > > has never worked for this port, set the field to 0. > > > > Signed-off-by: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Graeme Gregory > > Cc: Radoslaw Biernacki > > Acked-by: Ard Biesheuvel Thanks - pushed as 69035742d336. / Leif > > --- > > Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > index b8901030ecd0..dbc5e9475358 100644 > > --- a/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > +++ b/Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c > > @@ -71,7 +71,7 @@ AddMadtTable ( > > 0, /* Mpidr */ > > EFI_ACPI_6_0_GIC_ENABLED, /* Flags */ > > SBSAQEMU_MADT_GIC_PMU_IRQ, /* PMU Irq */ > > - FixedPcdGet32 (PcdGicDistributorBase), /* PhysicalBaseAddress */ > > + 0, /* PhysicalBaseAddress */ > > SBSAQEMU_MADT_GIC_VBASE, /* GicVBase */ > > SBSAQEMU_MADT_GIC_HBASE, /* GicHBase */ > > 25, /* GsivId */ > > -- > > 2.30.2 > >