From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web12.11746.1634034442096957643
 for <devel@edk2.groups.io>;
 Tue, 12 Oct 2021 03:27:22 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iUefbrn0;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634034441;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=eJvVhP9UWHTxe4K9lPlASMcDpasmD1yRiZitkOZwAbQ=;
	b=iUefbrn0CVrtnWFLt0/nVrTN3TG+EyxyQvYiVXpsGpnyBY6z0LuPbqVhbZH4Xe1tGHl4kL
	0+61h2IgqDB5aMdl/1saD+A/qQ8N9Y0vojEy3q5kuaraTGdr3anzvwPE4/SUVWKJklP1lz
	9SeL+d+BJHhnmT2rm/kgz3+9J4Ko5uw=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-486-jcp4jvd7PF-jqsI27561Yg-1; Tue, 12 Oct 2021 06:27:20 -0400
X-MC-Unique: jcp4jvd7PF-jqsI27561Yg-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95E9A1006AA3;
	Tue, 12 Oct 2021 10:27:18 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.22])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4713119C79;
	Tue, 12 Oct 2021 10:27:18 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 960BE180060E; Tue, 12 Oct 2021 12:27:16 +0200 (CEST)
Date: Tue, 12 Oct 2021 12:27:16 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, min.m.xu@intel.com
Cc: Brijesh Singh <brijesh.singh@amd.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception
Message-ID: <20211012102716.wr6bao42f5hviz5z@sirius.home.kraxel.org>
References: <cover.1633401643.git.min.m.xu@intel.com>
 <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com>
MIME-Version: 1.0
In-Reply-To: <24d3a351f21bff1a4b20490313d039e403b1453c.1633401643.git.min.m.xu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  if (ExceptionType == VE_EXCEPTION) {
> +    EFI_STATUS  Status;
> +    //
> +    // #VE needs to be handled immediately upon enabling exception handling
> +    // and therefore can't use the RegisterCpuInterruptHandler() interface.

Can please you explain in more detail why this is the case?

thanks,
  Gerd