From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web11.7915.1634130447376229526
 for <devel@edk2.groups.io>;
 Wed, 13 Oct 2021 06:07:27 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=YurbFAwV;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634130445;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=by6RiEW4iU8wVQ5E6hLkmNlTaM+3/OATiQjfpIbkTWw=;
	b=YurbFAwVXl7EZV3oImL9PKwehQVY4tkuocDoQyZwS8a3NPT1uagmnWGPo4daitTtZDeKyy
	8EiwB9P49nLpDLFA5dysKrzL01xqLTTcYhMPPHkh3ceVprwtwBuBsBBEnO5Ji6+CsSns61
	Omyve2iT36HPdnzT66G+7vyThgqf5jM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-597-ooKeM3_bMfeRhP7HpYkR-Q-1; Wed, 13 Oct 2021 09:07:20 -0400
X-MC-Unique: ooKeM3_bMfeRhP7HpYkR-Q-1
Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A4EE1801AA7;
	Wed, 13 Oct 2021 13:07:18 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.22])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 416F91972E;
	Wed, 13 Oct 2021 13:07:18 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 2CB621800906; Wed, 13 Oct 2021 15:07:16 +0200 (CEST)
Date: Wed, 13 Oct 2021 15:07:16 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, Min Xu <min.m.xu@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [edk2-devel] [PATCH V9 3/4] OvmfPkg: Add IntelTdxMetadata.asm
Message-ID: <20211013130716.rumgg4ual76xaizn@sirius.home.kraxel.org>
References: <cover.1634005437.git.min.m.xu@intel.com>
 <62bb7a8bf025bce78b012c8f92d59cbd203f3674.1634005437.git.min.m.xu@intel.com>
 <20211012072228.h3meki5hmw27fn32@sirius.home.kraxel.org>
 <e9f048ca-a0ec-0bba-3903-59a39790a6be@amd.com>
MIME-Version: 1.0
In-Reply-To: <e9f048ca-a0ec-0bba-3903-59a39790a6be@amd.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 13, 2021 at 06:44:28AM -0500, Brijesh Singh wrote:
> 
> On 10/12/21 12:22 AM, Gerd Hoffmann via groups.io wrote:
> >   Hi,
> >
> >> +; - Type field means this section is of BFV. This field is designed for the
> >> +;   purpose that in some case host VMM may do some additional processing based
> >> +;   upon the section type. TdHob section is an example. Host VMM pass the
> >> +;   physical memory information to the guest firmware by writing the data in
> >> +;   the memory region designated by TdHob section.
> > Brijesh?  What are your plans?  Do you want use this too?
> 
> Based on the previous comment by Jiewen it seems TDX folks want to have
> a separate metadata for flexibility. In the v9, I am creating metadata
> just for the SEV with a different GUID. Basically same as version 8 but
> now the number of descriptors will be smaller (since we focus on SEV-SNP).

Ok.  We can leave IntelTdxMetadata.asm as-is then.  So

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd