From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, c.koehne@beckhoff.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Rebecca Cran <rebecca@bsdio.com>,
Peter Grehan <grehan@freebsd.org>,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <gaoliming@byosoft.com.cn>,
Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/BhyveBhfPkg: install bhyve's ACPI tables
Date: Thu, 14 Oct 2021 07:07:45 +0200 [thread overview]
Message-ID: <20211014050745.5wx43tdxlpbidh3b@sirius.home.kraxel.org> (raw)
In-Reply-To: <20211013091657.202-1-c.koehne@beckhoff.com>
Hi,
> +#define BHYVE_ACPI_PHYSICAL_ADDRESS ((UINTN)0x000F2400)
> +#define BHYVE_BIOS_PHYSICAL_END ((UINTN)0x00100000)
> + //
> + // Detect the RSDP
> + //
> + for (RsdpAddress = BHYVE_ACPI_PHYSICAL_ADDRESS;
> + RsdpAddress < BHYVE_BIOS_PHYSICAL_END;
> + RsdpAddress += 0x10) {
> + Rsdp = NUMERIC_VALUE_AS_POINTER (
> + EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER,
> + RsdpAddress
> + );
> + if (Rsdp->Signature != EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER_SIGNATURE) {
> + continue;
> + }
So bhyve copies the tables to guest memory and ovmf searches for them,
correct?
The commit message should (briefly) describe how the tables are passed
from the host to the guest.
The code looks sane to me, so with a more verbose commit message:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
take care,
Gerd
next prev parent reply other threads:[~2021-10-14 5:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:16 [PATCH] OvmfPkg/BhyveBhfPkg: install bhyve's ACPI tables Corvin Köhne
2021-10-14 5:07 ` Gerd Hoffmann [this message]
2021-10-14 5:42 ` Peter Grehan
2021-10-14 5:51 ` [edk2-devel] " Gerd Hoffmann
2021-10-14 5:53 ` Peter Grehan
2021-10-14 9:41 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014050745.5wx43tdxlpbidh3b@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox