From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web11.5470.1634188074081179945
 for <devel@edk2.groups.io>;
 Wed, 13 Oct 2021 22:07:54 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Trys3X4s;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634188073;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Bdpt5Hf13xaGgusjs/U2MPTyn5LHA3BFe4sMqTUdz6k=;
	b=Trys3X4saDIzd+d9nChXTJ+qXJSUd8T7Jqcipih6zXCg7zfPJ97JTANl5AB9GGX7Ft6bWJ
	S9U+9PDekStUs9p8ylQI8LKrO8oj3d3gS5WaR5DYsGxMEYFEKJHzDGDdyD8kjIPy/7sKnj
	7fM3XZMzgk61+lQ/YeLTAlbdcmusXaI=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-514-WVT-nJVYMR2gJ8eo6E6o3Q-1; Thu, 14 Oct 2021 01:07:49 -0400
X-MC-Unique: WVT-nJVYMR2gJ8eo6E6o3Q-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3627480198A;
	Thu, 14 Oct 2021 05:07:48 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BABD641AA;
	Thu, 14 Oct 2021 05:07:47 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 7646118007AC; Thu, 14 Oct 2021 07:07:45 +0200 (CEST)
Date: Thu, 14 Oct 2021 07:07:45 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, c.koehne@beckhoff.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Rebecca Cran <rebecca@bsdio.com>, Peter Grehan <grehan@freebsd.org>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Zhiguang Liu <zhiguang.liu@intel.com>
Subject: Re: [edk2-devel] [PATCH] OvmfPkg/BhyveBhfPkg: install bhyve's ACPI tables
Message-ID: <20211014050745.5wx43tdxlpbidh3b@sirius.home.kraxel.org>
References: <20211013091657.202-1-c.koehne@beckhoff.com>
MIME-Version: 1.0
In-Reply-To: <20211013091657.202-1-c.koehne@beckhoff.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +#define BHYVE_ACPI_PHYSICAL_ADDRESS   ((UINTN)0x000F2400)
> +#define BHYVE_BIOS_PHYSICAL_END       ((UINTN)0x00100000)

> +  //
> +  // Detect the RSDP
> +  //
> +  for (RsdpAddress = BHYVE_ACPI_PHYSICAL_ADDRESS;
> +       RsdpAddress < BHYVE_BIOS_PHYSICAL_END;
> +       RsdpAddress += 0x10) {
> +    Rsdp = NUMERIC_VALUE_AS_POINTER (
> +             EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER,
> +             RsdpAddress
> +             );
> +    if (Rsdp->Signature != EFI_ACPI_2_0_ROOT_SYSTEM_DESCRIPTION_POINTER_SIGNATURE) {
> +      continue;
> +    }

So bhyve copies the tables to guest memory and ovmf searches for them,
correct?

The commit message should (briefly) describe how the tables are passed
from the host to the guest.

The code looks sane to me, so with a more verbose commit message:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd