From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web08.5536.1634189869279614975 for ; Wed, 13 Oct 2021 22:37:49 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ODFPdWcR; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634189868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QrPdMMiYQ1qhAmwyx/wHlYGHUCqTPPbASxnphPe36/A=; b=ODFPdWcRwdPtJHH2yXEvRWuTiMKXqyvNmPyR22RM0JRppvyBys9VvAwcRyod+cGtI4caaI TSKi79nn7kk7c7Sev5VzGC+i3dDmgibsH43leOSZqQath0+kmVgGYgZYkWWeCBKYHB3HAU 2dH9z6d/oY71WIDZPy2RXnboSy0Wb2Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-4mI-ujUoMHqwT_VKd90Afg-1; Thu, 14 Oct 2021 01:37:45 -0400 X-MC-Unique: 4mI-ujUoMHqwT_VKd90Afg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55215180830F; Thu, 14 Oct 2021 05:37:43 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.192.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D37AD19D9D; Thu, 14 Oct 2021 05:37:42 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 196A718007AC; Thu, 14 Oct 2021 07:37:41 +0200 (CEST) Date: Thu, 14 Oct 2021 07:37:41 +0200 From: "Gerd Hoffmann" To: "Xu, Min M" Cc: "devel@edk2.groups.io" , "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , Brijesh Singh , Erdem Aktas , James Bottomley , "Yao, Jiewen" , Tom Lendacky Subject: Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx Message-ID: <20211014053741.ev2wd7hrzkrdatln@sirius.home.kraxel.org> References: <78bc0164be0e6adb1edf4454bdc3aaf1d55a2771.1633401643.git.min.m.xu@intel.com> <20211012100555.4sykhkinx3fc6gak@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, > > Calling CPUID should not be needed, we have a new fancy > > ConfidentialComputing PCD for that now. > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is defined in UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. > If the ConfidentialComputing PCD is used, then UefiCpuPkg has to be included in BaseIoLibIntrinsicSev.inf. > I check all the *.inf under MdePkg but no one *.inf include UefiCpuPkg. > I am not sure if UefiCpuPkg can be included in BaseIoLibIntrinsicSev.inf. Hmm, I guess we should move the pcd then so it cam be used more widely. Confidential computing has an impact beyond just cpu, it's also memory, io and more. > > Maybe that's something to cleanup for amd (Brijesh?) beforehand, so the > > structure is there already and the tdx patches just need to add the "case tdx:" > > bits. > Tdx patches can first use above structure. AMD can update it later. Either way is ok. That'll work too, I don't care much about the ordering. take care, Gerd