From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mx.groups.io with SMTP id smtpd.web08.6735.1634200417371865533
 for <devel@edk2.groups.io>;
 Thu, 14 Oct 2021 01:33:37 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dDaFPgwY;
 spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634200416;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=rFMPDrd6nuoJfuX+XN/SZyObIewbmK6uXLY4XikeAFo=;
	b=dDaFPgwYE2Qxfm8NZ/jTVAFActZr5cPHShN/NM8mys0aEcVBisDKvUkifkKzpI8OVcVJZ1
	fGhxlADW2P4QXTv+9Vj6xNB9/ZLhSThMdZPjDOXp1YqdUUg7TBxBmjys3p+2pEmjEZQQi8
	MBJhe/ifR/KaMaexZiyYAa2N2VTpYwE=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-494-OAbR1DK9NhqRBL8ZmkxhNw-1; Thu, 14 Oct 2021 04:33:33 -0400
X-MC-Unique: OAbR1DK9NhqRBL8ZmkxhNw-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3D241835ACB;
	Thu, 14 Oct 2021 08:33:31 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F64C5F4EB;
	Thu, 14 Oct 2021 08:33:31 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id C3A5318007AC; Thu, 14 Oct 2021 10:33:29 +0200 (CEST)
Date: Thu, 14 Oct 2021 10:33:29 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>
Subject: Re: [PATCH v9 18/32] OvmfPkg/SecMain: validate the memory used for decompressing Fv
Message-ID: <20211014083329.buyqmel7nvfczgzz@sirius.home.kraxel.org>
References: <20211013165713.727815-1-brijesh.singh@amd.com>
 <20211013165713.727815-19-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20211013165713.727815-19-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 13, 2021 at 11:56:59AM -0500, Brijesh Singh wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
> 
> The VMM launch sequence should have pre-validated all the data pages used
> in the Reset vector. The range does not cover the data pages used during
> the SEC phase (mainly PEI and DXE firmware volume decompression memory).
> 
> When SEV-SNP is active, the memory must be pre-validated before the access.
> Add support to pre-validate the memory range from SnpSecPreValidatedStart
> to SnpSecPreValidatedEnd. This should be sufficent to enter into the PEI
> phase.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd