From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web08.6766.1634200729517295443
 for <devel@edk2.groups.io>;
 Thu, 14 Oct 2021 01:38:49 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bAE+HtSH;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634200728;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=gfAxWsTFJ3rrzKDJNqaPQHta0pATY3GD8m6Rd0+xKt8=;
	b=bAE+HtSHY9ZE76N2rFWmjfAWw8Y26b5xW/QJQRnFojHGBvwRprBEtmxDgECugNp4cnHlAc
	kGyhLEVSF+UiqsrJOt3cSwpbUTWdEXP+qq5oYYhQKLkPX8kubz+E0Wd6aV8D4x4FUrhtzY
	gU7mv2QrAhxfLH97Qla8fIHv4gASYjg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-341-bFGJcq5mNX6Zcato7XDmAQ-1; Thu, 14 Oct 2021 04:38:43 -0400
X-MC-Unique: bFGJcq5mNX6Zcato7XDmAQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3AAB31006AA4;
	Thu, 14 Oct 2021 08:38:41 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id B59D55DEFA;
	Thu, 14 Oct 2021 08:38:40 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id DE40718007AC; Thu, 14 Oct 2021 10:38:36 +0200 (CEST)
Date: Thu, 14 Oct 2021 10:38:36 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Eric Dong <eric.dong@intel.com>
Subject: Re: [PATCH v9 20/32] UefiCpuPkg: Define ConfidentialComputingGuestAttr
Message-ID: <20211014083836.ivmb6ag63kyin5e2@sirius.home.kraxel.org>
References: <20211013165713.727815-1-brijesh.singh@amd.com>
 <20211013165713.727815-21-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20211013165713.727815-21-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

  Hi,

> +  ## This dynamic PCD indicates the memory encryption attribute of the guest.
> +  # @Prompt Memory encryption attribute
> +  gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x60000017

See discussion in parallel thread.  This is probably not the best place
for the PCD due to dependency problems which make the PCD less useful
than it should.  There is more code than just cpu which must be tsx/sev
aware.

Move to MdePkg?

take care,
  Gerd