From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web10.6717.1634201643787156709
 for <devel@edk2.groups.io>;
 Thu, 14 Oct 2021 01:54:04 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BMebLjof;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634201642;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=Hlf960FlFaWZQyCkP0ewZwxuLi2n8iMReT30LiFZwKM=;
	b=BMebLjofHuQi3z8m9pM3vbK4GrF97N5MxbvbSkPZb5X6snqNwNlvtYgAaYjiRPRY1irn2y
	4lR9h+42wRN63/ZxYFpzoflUzzAikYBrZVLQid8fSrY81NYXDST9+hlQF8C3ucfyAGdr9Z
	eCwV5fO4UKX8sP3BC0jdpVrpXEidHcg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-517-D9ow-xgpMbm8bCidDsZXuA-1; Thu, 14 Oct 2021 04:53:57 -0400
X-MC-Unique: D9ow-xgpMbm8bCidDsZXuA-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D0E719200C0;
	Thu, 14 Oct 2021 08:53:55 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 513E560CC9;
	Thu, 14 Oct 2021 08:53:55 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 278D918007AC; Thu, 14 Oct 2021 10:53:50 +0200 (CEST)
Date: Thu, 14 Oct 2021 10:53:50 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Brijesh Singh <brijesh.singh@amd.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Erdem Aktas <erdemaktas@google.com>,
	Michael Roth <Michael.Roth@amd.com>
Subject: Re: [PATCH v9 29/32] OvmfPkg/MemEncryptSevLib: skip page state change for Mmio address
Message-ID: <20211014085350.gnl7mqtn64od77t2@sirius.home.kraxel.org>
References: <20211013165713.727815-1-brijesh.singh@amd.com>
 <20211013165713.727815-30-brijesh.singh@amd.com>
MIME-Version: 1.0
In-Reply-To: <20211013165713.727815-30-brijesh.singh@amd.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 13, 2021 at 11:57:10AM -0500, Brijesh Singh wrote:
> The SetMemoryEncDec() is used by the higher level routines to set or clear
> the page encryption mask for system RAM and Mmio address. When SEV-SNP is
> active, in addition to set/clear page mask it also updates the RMP table.
> The RMP table updates are required for the system RAM address and not
> the Mmio address.
> 
> Add a new parameter in SetMemoryEncDec() to tell whether the specified
> address is Mmio. If its Mmio then skip the page state change in the RMP
> table.

Acked-by: Gerd Hoffmann <kraxel@redhat.com>