Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

["Leif Lindholm" <leif@nuviainc.com>]

+Rebecca

On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote:
> As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
> for 64K granularity.
> 
> Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
> ---
>  ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> index fb484086a4..4b409ff745 100644
> --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation (
>      CacheSize32 = CacheSize16;
>    } else if ((CacheSize64 / 64) < MAX_INT16) {
>      CacheSize16 = (1 << 15) | (CacheSize64 / 64);
> -    CacheSize32 = CacheSize16;
> +    CacheSize32 = (1 << 31) | (CacheSize64 / 64);
>    } else {
>      if ((CacheSize64 / 1024) <= 2047) {
>        CacheSize32 = CacheSize64;
> -- 
> 2.17.1
> 
> 
> 
> 
> 
>