From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.groups.io with SMTP id smtpd.web11.7541.1634206028483099066 for ; Thu, 14 Oct 2021 03:07:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=u44k+uIy; spf=pass (domain: nuviainc.com, ip: 209.85.221.52, mailfrom: leif@nuviainc.com) Received: by mail-wr1-f52.google.com with SMTP id r7so17724649wrc.10 for ; Thu, 14 Oct 2021 03:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Tk6tkaimNbmXdiQ28XAQX1HWtW6444I7k8mNBoI3aeo=; b=u44k+uIy9WyRdgXvVe5Dc/I1y9I5AM7CR6qqMyaH1XBgdkVOzDP6gFeQVJSkpWuk3I S/N6ykPZ6lkyVTnEgq6TfpOGGphg9LHBEI7P2AVyUjd+83HrUGNbkRzIQsvO1cxgsoZn DB8F2wFHQfD9k13lRGRKkCN2ZZr5sqI4BdjSa/OTfL2lyIoUZXi7DiiXHUbWAWggE9l8 8ZHlWrs/at0qocPM+sT43UTrZ6oMUkWXqAWiBBqILtEJF9K6J+FpDIpsJgutqXefBwAO p9hlk2Pv7FEMy21QLswyO+eWfpNr8hNMvdl7H0JoHbd2AL4ZJCrKvnD77OQa9d/ynG2y tvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Tk6tkaimNbmXdiQ28XAQX1HWtW6444I7k8mNBoI3aeo=; b=0VzFcbDQywvJikr1C+pQ49uRWrHeGObgfnhlRaWF8co1mp6i+U9fyaPUdEf/kDOgYt 7FoLjDBMobGjkBv3HPwTZ6CxCp9Q3OqgruAdXz6/lf3FA3ANgpSzcnpsQQa8WwivnmYK g2UYKCEOoyyfOjHmdr7AzMCZ2gEylXMUi3yaUMyIg1tFhlXcao+SEa/LGE2iA+NXFR7O LlUI3iEoBLEi0amlIX6XZ0EMlmajhfhrwxppaGQ/TU6sXDPhSM4wGh8SdEXJKyZ91RXF 2966KDqrcq0iBrzYQmgzhiLwvhQPcJ8ZTGJA00h9AngkIQ0zeYioLSBY1Nu5glnXS0ka sPfA== X-Gm-Message-State: AOAM533WPszehULqlLw0TtmVk6m6qFlzR8LCrm6ahI6eSU3zKwpTLEzl 776RnbgaVt/0pVZM4G0l5FGLJMdGVtzecZnUkry85wd1gC03TaMsg6RKCaxBEZpbtvnGq9Wknv6 pq8akfCbdmS7ahdDtSdMY978jvxpmh7x9zsdaqVFKc/NLPkHopLUyWCJ4MWDwMrU19PYQ X-Google-Smtp-Source: ABdhPJyAhqiAA7OrQS16K2ZxTZJmN5b80wlknnXnQ8+w6YutxpUI/dz4WVgS2KEx2GlWPfyyFBmR/Q== X-Received: by 2002:a7b:c08a:: with SMTP id r10mr18916282wmh.135.1634206026330; Thu, 14 Oct 2021 03:07:06 -0700 (PDT) Return-Path: Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48]) by smtp.gmail.com with ESMTPSA id l2sm8158491wmi.1.2021.10.14.03.07.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Oct 2021 03:07:05 -0700 (PDT) Date: Thu, 14 Oct 2021 11:07:04 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, huangming@linux.alibaba.com Cc: ardb+tianocore@kernel.org, ming.huang-@outlook.com, Rebecca Cran Subject: Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue Message-ID: <20211014100704.gbhrrny2ayefrygn@leviathan> References: <20211014072314.54891-1-huangming@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <20211014072314.54891-1-huangming@linux.alibaba.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline +Rebecca On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > index fb484086a4..4b409ff745 100644 > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation ( > CacheSize32 = CacheSize16; > } else if ((CacheSize64 / 64) < MAX_INT16) { > CacheSize16 = (1 << 15) | (CacheSize64 / 64); > - CacheSize32 = CacheSize16; > + CacheSize32 = (1 << 31) | (CacheSize64 / 64); > } else { > if ((CacheSize64 / 1024) <= 2047) { > CacheSize32 = CacheSize64; > -- > 2.17.1 > > > > > >