public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "manickavasakam karpagavinayagam" <manickavasakamk@ami.com>
To: <devel@edk2.groups.io>
Cc: <isaac.w.oram@intel.com>, <nathaniel.l.desimone@intel.com>,
	<Felixp@ami.com>, <harikrishnad@ami.com>, <manishj@ami.com>,
	<zacharyb@ami.com>, <manickavasakamk@ami.com>
Subject: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
Date: Thu, 14 Oct 2021 18:29:52 -0400	[thread overview]
Message-ID: <20211014222952.1651-1-manickavasakamk@ami.com> (raw)

Fix to resolve the OS boot issue when booting on WilsonCitySMT board.
ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code and not with TRUE or FALSE.
Replaced ASSERT_EFI_ERROR with ASSERT.

Signed-off-by: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
---
 Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
index d8274fa7ad..212103f483 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
@@ -68,6 +68,16 @@ BoardInitDxeDriverEntry (
       ASSERT_EFI_ERROR (Status);
       break;
 
+    case TypeWilsonCitySMT:
+      Status = gBS->InstallProtocolInterface(
+        &Handle,
+        &gEfiPlatformTypeWilsonCitySMTProtocolGuid,
+        EFI_NATIVE_INTERFACE,
+        NULL
+      );
+      ASSERT_EFI_ERROR(Status);
+      break;
+
     case TypeCooperCityRP:
       Status = gBS->InstallProtocolInterface (
         &Handle,
@@ -80,7 +90,7 @@ BoardInitDxeDriverEntry (
 
     default:
       // CAN'T GO TO HERE.
-      ASSERT_EFI_ERROR (FALSE);
+      ASSERT (FALSE);
   }
 
   return Status;
--
2.25.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.

             reply	other threads:[~2021-10-14 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 22:29 manickavasakam karpagavinayagam [this message]
2021-10-14 23:17 ` [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Oram, Isaac W
2021-10-15  0:53 ` [edk2-devel] " Nate DeSimone
2021-10-15  0:53 ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211014222952.1651-1-manickavasakamk@ami.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox