* [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
@ 2021-10-14 22:29 manickavasakam karpagavinayagam
2021-10-14 23:17 ` Oram, Isaac W
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: manickavasakam karpagavinayagam @ 2021-10-14 22:29 UTC (permalink / raw)
To: devel
Cc: isaac.w.oram, nathaniel.l.desimone, Felixp, harikrishnad, manishj,
zacharyb, manickavasakamk
Fix to resolve the OS boot issue when booting on WilsonCitySMT board.
ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code and not with TRUE or FALSE.
Replaced ASSERT_EFI_ERROR with ASSERT.
Signed-off-by: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
---
Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
index d8274fa7ad..212103f483 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
@@ -68,6 +68,16 @@ BoardInitDxeDriverEntry (
ASSERT_EFI_ERROR (Status);
break;
+ case TypeWilsonCitySMT:
+ Status = gBS->InstallProtocolInterface(
+ &Handle,
+ &gEfiPlatformTypeWilsonCitySMTProtocolGuid,
+ EFI_NATIVE_INTERFACE,
+ NULL
+ );
+ ASSERT_EFI_ERROR(Status);
+ break;
+
case TypeCooperCityRP:
Status = gBS->InstallProtocolInterface (
&Handle,
@@ -80,7 +90,7 @@ BoardInitDxeDriverEntry (
default:
// CAN'T GO TO HERE.
- ASSERT_EFI_ERROR (FALSE);
+ ASSERT (FALSE);
}
return Status;
--
2.25.0.windows.1
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
2021-10-14 22:29 [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro manickavasakam karpagavinayagam
@ 2021-10-14 23:17 ` Oram, Isaac W
2021-10-15 0:53 ` [edk2-devel] " Nate DeSimone
2021-10-15 0:53 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Oram, Isaac W @ 2021-10-14 23:17 UTC (permalink / raw)
To: KARPAGAVINAYAGAM, MANICKAVASAKAM, devel@edk2.groups.io
Cc: Desimone, Nathaniel L, Felixp@ami.com, DOPPALAPUDI, HARIKRISHNA,
Jha, Manish, Bobroff, Zachary, KARPAGAVINAYAGAM, MANICKAVASAKAM
Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>
-----Original Message-----
From: manickavasakam karpagavinayagam <manickavasakamk@ami.com>
Sent: Thursday, October 14, 2021 3:30 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; Jha, Manish <manishj@ami.com>; Bobroff, Zachary <zacharyb@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>
Subject: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
Fix to resolve the OS boot issue when booting on WilsonCitySMT board.
ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code and not with TRUE or FALSE.
Replaced ASSERT_EFI_ERROR with ASSERT.
Signed-off-by: Manickavasakam Karpagavinayagam <manickavasakamk@ami.com>
---
Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
index d8274fa7ad..212103f483 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
@@ -68,6 +68,16 @@ BoardInitDxeDriverEntry (
ASSERT_EFI_ERROR (Status);
break;
+ case TypeWilsonCitySMT:
+ Status = gBS->InstallProtocolInterface(
+ &Handle,
+ &gEfiPlatformTypeWilsonCitySMTProtocolGuid,
+ EFI_NATIVE_INTERFACE,
+ NULL
+ );
+ ASSERT_EFI_ERROR(Status);
+ break;
+
case TypeCooperCityRP:
Status = gBS->InstallProtocolInterface (
&Handle,
@@ -80,7 +90,7 @@ BoardInitDxeDriverEntry (
default:
// CAN'T GO TO HERE.
- ASSERT_EFI_ERROR (FALSE);
+ ASSERT (FALSE);
}
return Status;
--
2.25.0.windows.1
Please consider the environment before printing this email.
The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
2021-10-14 22:29 [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro manickavasakam karpagavinayagam
2021-10-14 23:17 ` Oram, Isaac W
@ 2021-10-15 0:53 ` Nate DeSimone
2021-10-15 0:53 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-10-15 0:53 UTC (permalink / raw)
To: devel@edk2.groups.io, KARPAGAVINAYAGAM, MANICKAVASAKAM
Cc: Oram, Isaac W, Felixp@ami.com, DOPPALAPUDI, HARIKRISHNA,
Jha, Manish, Bobroff, Zachary
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> manickavasakam karpagavinayagam via groups.io
> Sent: Thursday, October 14, 2021 3:30 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Felixp@ami.com; DOPPALAPUDI,
> HARIKRISHNA <harikrishnad@ami.com>; Jha, Manish <manishj@ami.com>;
> Bobroff, Zachary <zacharyb@ami.com>; KARPAGAVINAYAGAM,
> MANICKAVASAKAM <manickavasakamk@ami.com>
> Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for
> WilsonCitySMT OS boot issue & using proper ASSERT macro
>
> Fix to resolve the OS boot issue when booting on WilsonCitySMT board.
> ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status
> code and not with TRUE or FALSE.
> Replaced ASSERT_EFI_ERROR with ASSERT.
>
> Signed-off-by: Manickavasakam Karpagavinayagam
> <manickavasakamk@ami.com>
> ---
> Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c |
> 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> index d8274fa7ad..212103f483 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry (
> ASSERT_EFI_ERROR (Status);
>
> break;
>
>
>
> + case TypeWilsonCitySMT:
>
> + Status = gBS->InstallProtocolInterface(
>
> + &Handle,
>
> + &gEfiPlatformTypeWilsonCitySMTProtocolGuid,
>
> + EFI_NATIVE_INTERFACE,
>
> + NULL
>
> + );
>
> + ASSERT_EFI_ERROR(Status);
>
> + break;
>
> +
>
> case TypeCooperCityRP:
>
> Status = gBS->InstallProtocolInterface (
>
> &Handle,
>
> @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry (
>
>
> default:
>
> // CAN'T GO TO HERE.
>
> - ASSERT_EFI_ERROR (FALSE);
>
> + ASSERT (FALSE);
>
> }
>
>
>
> return Status;
>
> --
> 2.25.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro
2021-10-14 22:29 [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro manickavasakam karpagavinayagam
2021-10-14 23:17 ` Oram, Isaac W
2021-10-15 0:53 ` [edk2-devel] " Nate DeSimone
@ 2021-10-15 0:53 ` Nate DeSimone
2 siblings, 0 replies; 4+ messages in thread
From: Nate DeSimone @ 2021-10-15 0:53 UTC (permalink / raw)
To: devel@edk2.groups.io, KARPAGAVINAYAGAM, MANICKAVASAKAM
Cc: Oram, Isaac W, Felixp@ami.com, DOPPALAPUDI, HARIKRISHNA,
Jha, Manish, Bobroff, Zachary
Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> manickavasakam karpagavinayagam via groups.io
> Sent: Thursday, October 14, 2021 3:30 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Felixp@ami.com; DOPPALAPUDI,
> HARIKRISHNA <harikrishnad@ami.com>; Jha, Manish <manishj@ami.com>;
> Bobroff, Zachary <zacharyb@ami.com>; KARPAGAVINAYAGAM,
> MANICKAVASAKAM <manickavasakamk@ami.com>
> Subject: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for
> WilsonCitySMT OS boot issue & using proper ASSERT macro
>
> Fix to resolve the OS boot issue when booting on WilsonCitySMT board.
> ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status
> code and not with TRUE or FALSE.
> Replaced ASSERT_EFI_ERROR with ASSERT.
>
> Signed-off-by: Manickavasakam Karpagavinayagam
> <manickavasakamk@ami.com>
> ---
> Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c |
> 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> index d8274fa7ad..212103f483 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c
> @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry (
> ASSERT_EFI_ERROR (Status);
>
> break;
>
>
>
> + case TypeWilsonCitySMT:
>
> + Status = gBS->InstallProtocolInterface(
>
> + &Handle,
>
> + &gEfiPlatformTypeWilsonCitySMTProtocolGuid,
>
> + EFI_NATIVE_INTERFACE,
>
> + NULL
>
> + );
>
> + ASSERT_EFI_ERROR(Status);
>
> + break;
>
> +
>
> case TypeCooperCityRP:
>
> Status = gBS->InstallProtocolInterface (
>
> &Handle,
>
> @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry (
>
>
> default:
>
> // CAN'T GO TO HERE.
>
> - ASSERT_EFI_ERROR (FALSE);
>
> + ASSERT (FALSE);
>
> }
>
>
>
> return Status;
>
> --
> 2.25.0.windows.1
>
>
> Please consider the environment before printing this email.
>
> The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
> to be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
> telephone at 770-246-8600, and then delete or destroy all copies of the
> transmission.
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-15 0:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-14 22:29 [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro manickavasakam karpagavinayagam
2021-10-14 23:17 ` Oram, Isaac W
2021-10-15 0:53 ` [edk2-devel] " Nate DeSimone
2021-10-15 0:53 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox