From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web09.2015.1634250596594490085 for ; Thu, 14 Oct 2021 15:29:56 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ami.com, ip: 63.147.10.40, mailfrom: manickavasakamk@ami.com) X-AuditID: ac1060b2-d15ff700000017be-9b-6168af63ee2c Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id FE.68.06078.36FA8616; Thu, 14 Oct 2021 18:29:55 -0400 (EDT) Received: from MANIC-WIN10.us.megatrends.com (172.16.98.169) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.498.0; Thu, 14 Oct 2021 18:29:54 -0400 From: "manickavasakam karpagavinayagam" To: CC: , , , , , , Subject: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Date: Thu, 14 Oct 2021 18:29:52 -0400 Message-ID: <20211014222952.1651-1-manickavasakamk@ami.com> X-Mailer: git-send-email 2.25.0.windows.1 MIME-Version: 1.0 Return-Path: manickavasakamk@ami.com X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsWyRiBhgm7y+oxEg4NLpSzaJ8xms+hfcYzV 4vivD8wOzB7bv19g9Fi85yVTAFNUA6NNYl5efkliSapCSmpxsq1SQFFmWWJypZJCZoqtkqGS QkFOYnJqbmpeia1SYkFBal6Kkh2XAgawASrLzFNIzUvOT8nMS7dV8gz217WwMLXUNVSyC8lI VcjMS8svyk0syczPU0jOzysBqk5NAYoqJHRzZry4fpCx4DN3RdfKEywNjOc5uxg5OSQETCTO vupgAbGFBHYxSSw+Gd3FyAVkb2OU+PJ9DxNIgk3AXmL71NnsILaIgJTElAMzmUCKmAXWMUos fNEGViQskCMx4fULoCIODhYBVYm1izlBTF4Ba4m9R2QhdmlKXJ15jQ3E5hUQlDg58wnYXmYB bYllC18zQ9gSEgdfvGAGaRUSUJF4csxhAiPfLCQds5B0zELSsYCReRWjUGJJTm5iZk56uaFe Ym6mXnJ+7iZGSFxt2sHYctH8ECMTB+MhRgkOZiUR3ncH0hOFeFMSK6tSi/Lji0pzUosPMToB XT+RWYobFHzA+Ig3NjCQEoVxDE3MTMyNzA0tTcyNjZXEeVe5H40XEkgHxmt2ampBahHMECYO TqkGxpNeqp4V6dOlV5Sb3V17fr+LQYC3go2lwyqf35syc3oOC9/ZVa2lsq6KoSy987WQucf9 5lZ+U6cMPwWtSq4f6/ZZbmX7tLqSTchwbnXItu+NByx1L2yNzL/U2MK+PCah1mrBWuY1P0QZ vjpemNRYrZ7e+5/hu0j0jTpHxl2PtT2iAh4rnH+txFKckWioxVxUnAgA6kdGMcACAAA= Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Fix to resolve the OS boot issue when booting on WilsonCitySMT board. ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code= and not with TRUE or FALSE. Replaced ASSERT_EFI_ERROR with ASSERT. Signed-off-by: Manickavasakam Karpagavinayagam --- Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 ++= +++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitD= xe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c index d8274fa7ad..212103f483 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( ASSERT_EFI_ERROR (Status);=0D= break;=0D= =0D= + case TypeWilsonCitySMT:=0D= + Status =3D gBS->InstallProtocolInterface(=0D= + &Handle,=0D= + &gEfiPlatformTypeWilsonCitySMTProtocolGuid,=0D= + EFI_NATIVE_INTERFACE,=0D= + NULL=0D= + );=0D= + ASSERT_EFI_ERROR(Status);=0D= + break;=0D= +=0D= case TypeCooperCityRP:=0D= Status =3D gBS->InstallProtocolInterface (=0D= &Handle,=0D= @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( =0D= default:=0D= // CAN'T GO TO HERE.=0D= - ASSERT_EFI_ERROR (FALSE);=0D= + ASSERT (FALSE);=0D= }=0D= =0D= return Status;=0D= -- 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprietar= y to American Megatrends (AMI). This communication is intended to be read o= nly by the individual or entity to whom it is addressed or by their designee= . If the reader of this message is not the intended recipient, you are on no= tice that any distribution of this message, in any form, is strictly prohibi= ted. Please promptly notify the sender by reply e-mail or by telephone at 7= 70-246-8600, and then delete or destroy all copies of the transmission.