* [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot
@ 2021-10-15 0:27 Guo Dong
2021-10-15 5:48 ` Ni, Ray
0 siblings, 1 reply; 2+ messages in thread
From: Guo Dong @ 2021-10-15 0:27 UTC (permalink / raw)
To: devel; +Cc: Guo Dong, Ray Ni, Maurice Ma, Benjamin You
From: Guo Dong <guo.dong@intel.com>
There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
return NULL;
}
- PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
- ASSERT_EFI_STATUS (Status);
+ Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
+ ASSERT_EFI_ERROR (Status);
return CbTablePtr;
}
--
2.32.0.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot
2021-10-15 0:27 [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot Guo Dong
@ 2021-10-15 5:48 ` Ni, Ray
0 siblings, 0 replies; 2+ messages in thread
From: Ni, Ray @ 2021-10-15 5:48 UTC (permalink / raw)
To: Dong, Guo, devel@edk2.groups.io; +Cc: Ma, Maurice, You, Benjamin
Reviewed-by: Ray Ni <ray.ni@intel.com>
-----Original Message-----
From: Dong, Guo <guo.dong@intel.com>
Sent: Friday, October 15, 2021 8:28 AM
To: devel@edk2.groups.io
Cc: Dong, Guo <guo.dong@intel.com>; Ni, Ray <ray.ni@intel.com>; Ma, Maurice <maurice.ma@intel.com>; You, Benjamin <benjamin.you@intel.com>
Subject: [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot
From: Guo Dong <guo.dong@intel.com>
There is typo in previous change caused coreboot build failue.
This patch fixed the build issue.
Cc: Ray Ni <ray.ni@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Benjamin You <benjamin.you@intel.com>
Signed-off-by: Guo Dong <guo.dong@intel.com>
---
UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
index f81aa0f301..4be5d66ba5 100644
--- a/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
+++ b/UefiPayloadPkg/Library/CbParseLib/CbParseLib.c
@@ -194,8 +194,8 @@ GetParameterBase (
return NULL;
}
- PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
- ASSERT_EFI_STATUS (Status);
+ Status = PcdSet64S (PcdBootloaderParameter, (UINTN)CbTablePtr);
+ ASSERT_EFI_ERROR (Status);
return CbTablePtr;
}
--
2.32.0.windows.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-15 5:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 0:27 [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot Guo Dong
2021-10-15 5:48 ` Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox