public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, jiewen.yao@intel.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt
Date: Fri, 15 Oct 2021 06:53:21 +0200	[thread overview]
Message-ID: <20211015045321.pxemldphaxva27ko@sirius.home.kraxel.org> (raw)
In-Reply-To: <PH0PR11MB4885172F82D62160B7A33EAC8CB99@PH0PR11MB4885.namprd11.prod.outlook.com>

On Fri, Oct 15, 2021 at 03:54:19AM +0000, Yao, Jiewen wrote:
> Hi
> I am not sure where the problem is. "FdtClient is unhappy without a device tree, so add an empty fdt"

FdtClient throws an assert() in case no device tree is present.

> Do we have option 2 to fix the issue?
> If no device tree, why we need FdtClient? Why we need make it happy?

Well, if all goes as planned the microvm in qemu 6.2+ will provide the
fdt but older qemu versions don't.  So I want use the fdt if present to
detect virtio-mmio devices.  On older qemu versions without fdt I do
*not* want abort the boot though, the firmware still works with reduced
functionality (no storage/network, but direct kernel boot works).

The microvm situation is a bit special here.  On arm systems the fdt is
rather essential for hardware bringup, which is probably the reason for
the assert().  For microvm this is not the case though.

take care,
  Gerd


  reply	other threads:[~2021-10-15  4:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 15:30 [PATCH 0/5] [RfC] OvmfPkg/Microvm: second batch of microvm patches Gerd Hoffmann
2021-10-14 15:30 ` [PATCH 1/5] OvmfPkg/Microvm/fdt: add device tree support Gerd Hoffmann
2021-10-14 15:30 ` [PATCH 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg Gerd Hoffmann
2021-10-14 15:30 ` [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt Gerd Hoffmann
2021-10-15  3:54   ` Yao, Jiewen
2021-10-15  4:53     ` Gerd Hoffmann [this message]
2021-10-15 16:10       ` [edk2-devel] " Yao, Jiewen
2021-10-14 15:30 ` [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support Gerd Hoffmann
2021-10-15  3:57   ` [edk2-devel] " Yao, Jiewen
2021-10-15  4:57     ` Gerd Hoffmann
2021-10-15 16:08       ` Yao, Jiewen
2021-10-14 15:30 ` [PATCH 5/5] OvmfPkg/Microvm: add README Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211015045321.pxemldphaxva27ko@sirius.home.kraxel.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox