* [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg
@ 2021-10-15 6:59 Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
` (6 more replies)
0 siblings, 7 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 6:59 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Daniel Schaefer, Thomas Abraham,
Sami Mujawar, Graeme Gregory, Radoslaw Biernacki, Peng Xie,
Ling Jia, Yiqi Shu
This patch set fixes the build error caused by referring to
PcdPciMmio(32)64Translation under ArmPkg. It should use the ones from
MdePkg because of the PCD relocation (BZ:#3665).
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
BZ:#3665 is to migrate some modules from ArmVirtPkg
to under OvmfPkg for the upcoming RiscVVirtPkg that can leverage
those modules without the dependency with Arm*Pkg.
Refer to below message of the pacthes of edk2 portion.
https://edk2.groups.io/g/devel/message/81306
Below PCDs are moved to under MdePkg and leverage by RiscVVirtPkg.
This change also remove the dependency on ArmPkg of OvmfPkg.
- PcdPciMmio32Translation
- PcdPciMmio64Translation
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Peng Xie <xiepeng@phytium.com.cn>
Cc: Ling Jia <jialing@phytium.com.cn>
Cc: Yiqi Shu <shuyiqi@phytium.com.cn>
Abner Chang (9):
Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from
MdePkg
Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from
MdePkg
Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
Platform/DurianPkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
Silicon/FT2000-4Pkg: Use PcdPciMmio(32)64Translation PCD from MdePkg
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 4 ++--
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 ++--
Platform/Phytium/DurianPkg/DurianPkg.dsc | 2 +-
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4 ++--
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 4 ++--
.../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 4 ++--
.../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 2 +-
.../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf | 4 ++--
.../Phytium/FT2000-4Pkg/Library/PlatformLib/PlatformLib.inf | 2 +-
Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 ++--
.../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c | 4 ++--
12 files changed, 21 insertions(+), 21 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:59 ` Ard Biesheuvel
2021-10-15 7:00 ` [edk2-platforms][PATCH 2/9] Platform/CelloBoard: " Abner Chang
` (5 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
index 91b8c7792e..af20739120 100644
--- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
@@ -403,11 +403,11 @@ DEFINE X64EMU_ENABLE = FALSE
gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
- gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
- gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
## Use PCI emulation for ATA PassThru
# gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 2/9] Platform/CelloBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: " Abner Chang
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Platform/LeMaker/CelloBoard/CelloBoard.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
index d826e34fdd..11d989cf34 100644
--- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc
+++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc
@@ -393,11 +393,11 @@ DEFINE NUM_CORES = 4
gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
- gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
- gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
## ACPI (no tables < 4GB)
gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 2/9] Platform/CelloBoard: " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 4/9] Silicon/Styx: " Abner Chang
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 0f61665cbb..57b9e9f381 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -392,11 +392,11 @@ DEFINE NUM_CORES = 4
gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
- gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
- gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
## Use PCI emulation for ATA PassThru
# gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 4/9] Silicon/Styx: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
` (2 preceding siblings ...)
2021-10-15 7:00 ` [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 5/9] Platform/ARM: " Abner Chang
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
.../AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Silicon/AMD/Styx/Library/AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf b/Silicon/AMD/Styx/Library/AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf
index 31c973cd2a..76a3b5aee2 100644
--- a/Silicon/AMD/Styx/Library/AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf
+++ b/Silicon/AMD/Styx/Library/AmdStyxPciHostBridgeLib/AmdStyxPciHostBridgeLib.inf
@@ -43,7 +43,7 @@
gArmTokenSpaceGuid.PcdPciIoSize
gArmTokenSpaceGuid.PcdPciMmio32Base
gArmTokenSpaceGuid.PcdPciMmio32Size
- gArmTokenSpaceGuid.PcdPciMmio32Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
gArmTokenSpaceGuid.PcdPciMmio64Base
gArmTokenSpaceGuid.PcdPciMmio64Size
- gArmTokenSpaceGuid.PcdPciMmio64Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 5/9] Platform/ARM: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
` (3 preceding siblings ...)
2021-10-15 7:00 ` [edk2-platforms][PATCH 4/9] Silicon/Styx: " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 6/9] Platform/SabaQemu: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: " Abner Chang
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel; +Cc: Ard Biesheuvel, Thomas Abraham, Sami Mujawar, Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Thomas Abraham <thomas.abraham@arm.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Platform/ARM/SgiPkg/SgiPlatform.dsc.inc | 4 ++--
.../Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf | 4 ++--
.../ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
index 6679939d3b..4fe3ccf9a5 100644
--- a/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
+++ b/Platform/ARM/SgiPkg/SgiPlatform.dsc.inc
@@ -152,8 +152,8 @@
gArmTokenSpaceGuid.PcdPciIoBase|0x0
gArmTokenSpaceGuid.PcdPciIoSize|0x00800000
gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x77800000
- gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
- gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize|24
## PL011 - Serial Terminal
diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
index fb513d7b3d..f448803fda 100644
--- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
+++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/JunoPciHostBridgeLib.inf
@@ -55,10 +55,10 @@
gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation
gArmTokenSpaceGuid.PcdPciMmio32Base
gArmTokenSpaceGuid.PcdPciMmio32Size
- gArmTokenSpaceGuid.PcdPciMmio32Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
gArmTokenSpaceGuid.PcdPciMmio64Base
gArmTokenSpaceGuid.PcdPciMmio64Size
- gArmTokenSpaceGuid.PcdPciMmio64Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation
gArmJunoTokenSpaceGuid.PcdPcieControlBaseAddress
gArmJunoTokenSpaceGuid.PcdPcieRootPortBaseAddress
diff --git a/Platform/ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf b/Platform/ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
index a9fdd874d0..0f53d67bc0 100644
--- a/Platform/ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
+++ b/Platform/ARM/SgiPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
@@ -46,7 +46,7 @@
gArmTokenSpaceGuid.PcdPciIoSize
gArmTokenSpaceGuid.PcdPciMmio32Base
gArmTokenSpaceGuid.PcdPciMmio32Size
- gArmTokenSpaceGuid.PcdPciMmio32Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
gArmTokenSpaceGuid.PcdPciMmio64Base
gArmTokenSpaceGuid.PcdPciMmio64Size
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 6/9] Platform/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
` (4 preceding siblings ...)
2021-10-15 7:00 ` [edk2-platforms][PATCH 5/9] Platform/ARM: " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: " Abner Chang
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki,
Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
index d404e08a67..1d1a25196e 100644
--- a/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
+++ b/Platform/Qemu/SbsaQemu/SbsaQemu.dsc
@@ -487,8 +487,8 @@ DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciExpressBarLimit|0xFFFFFFFF
gEfiMdePkgTokenSpaceGuid.PcdPciIoTranslation|0x7fff0000
- gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
- gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
## If TRUE, OvmfPkg/AcpiPlatformDxe will not wait for PCI
# enumeration to complete before installing ACPI tables.
gEfiMdeModulePkgTokenSpaceGuid.PcdPciDisableBusEnumeration|FALSE
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
` (5 preceding siblings ...)
2021-10-15 7:00 ` [edk2-platforms][PATCH 6/9] Platform/SabaQemu: " Abner Chang
@ 2021-10-15 7:00 ` Abner Chang
6 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 7:00 UTC (permalink / raw)
To: devel
Cc: Ard Biesheuvel, Leif Lindholm, Graeme Gregory, Radoslaw Biernacki,
Daniel Schaefer
Compliant with BZ: #3665
https://bugzilla.tianocore.org/show_bug.cgi?id=3665
PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
by both ARM and RISC-V arch. This patch uses the one from MdePkg
instead the one under ArmVirtPkg.
Signed-off-by: Abner Chang <abner.chang@hpe.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Graeme Gregory <graeme@nuviainc.com>
Cc: Radoslaw Biernacki <rad@semihalf.com>
Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
---
Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 ++--
.../SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf b/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
index 0ad9cc7ce4..176d8fab83 100644
--- a/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
+++ b/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf
@@ -56,12 +56,12 @@
gArmTokenSpaceGuid.PcdPciMmio32Base
gArmTokenSpaceGuid.PcdPciMmio32Size
- gArmTokenSpaceGuid.PcdPciMmio32Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation
gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciMmio32Limit
gArmTokenSpaceGuid.PcdPciMmio64Base
gArmTokenSpaceGuid.PcdPciMmio64Size
- gArmTokenSpaceGuid.PcdPciMmio64Translation
+ gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation
gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPciMmio64Limit
gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress
diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c
index 5021b096f7..9739c7500d 100644
--- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c
+++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuPciHostBridgeLib/SbsaQemuPciHostBridgeLib.c
@@ -96,7 +96,7 @@ STATIC PCI_ROOT_BRIDGE mRootBridge = {
/* PCI_ROOT_BRIDGE_APERTURE Mem; MMIO aperture below 4GB which can be used by
the root bridge
- (gArmTokenSpaceGuid.PcdPciMmio32Translation as 0x0) */
+ (gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation as 0x0) */
{
FixedPcdGet32 (PcdPciMmio32Base),
FixedPcdGet32 (PcdPciMmio32Base) + FixedPcdGet32 (PcdPciMmio32Size) - 1,
@@ -104,7 +104,7 @@ STATIC PCI_ROOT_BRIDGE mRootBridge = {
/* PCI_ROOT_BRIDGE_APERTURE MemAbove4G; MMIO aperture above 4GB which can be
used by the root bridge.
- (gArmTokenSpaceGuid.PcdPciMmio64Translation as 0x0) */
+ (gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation as 0x0) */
{
FixedPcdGet64 (PcdPciMmio64Base),
FixedPcdGet64 (PcdPciMmio64Base) + FixedPcdGet64 (PcdPciMmio64Size) - 1
--
2.17.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
@ 2021-10-15 7:59 ` Ard Biesheuvel
2021-10-15 8:13 ` [edk2-devel] " Abner Chang
0 siblings, 1 reply; 10+ messages in thread
From: Ard Biesheuvel @ 2021-10-15 7:59 UTC (permalink / raw)
To: Abner Chang
Cc: edk2-devel-groups-io, Ard Biesheuvel, Leif Lindholm,
Daniel Schaefer
On Fri, 15 Oct 2021 at 09:58, Abner Chang <abner.chang@hpe.com> wrote:
>
> Compliant with BZ: #3665
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
> by both ARM and RISC-V arch. This patch uses the one from MdePkg
> instead the one under ArmVirtPkg.
>
ArmVirtPkg??
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 91b8c7792e..af20739120 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -403,11 +403,11 @@ DEFINE X64EMU_ENABLE = FALSE
>
> gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
> gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
> - gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
>
> gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
> gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
> - gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
>
> ## Use PCI emulation for ATA PassThru
> # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
2021-10-15 7:59 ` Ard Biesheuvel
@ 2021-10-15 8:13 ` Abner Chang
0 siblings, 0 replies; 10+ messages in thread
From: Abner Chang @ 2021-10-15 8:13 UTC (permalink / raw)
To: devel@edk2.groups.io, ardb@kernel.org
Cc: Ard Biesheuvel, Leif Lindholm, Schaefer, Daniel
[-- Attachment #1: Type: text/plain, Size: 2182 bytes --]
sigh... typo. Should be ArmPkg, will send V3.
Abner
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Ard Biesheuvel <ardb@kernel.org>
Sent: Friday, October 15, 2021 3:59 PM
To: Chang, Abner (HPS SW/FW Technologist) <abner.chang@hpe.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm <leif@nuviainc.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD from MdePkg
On Fri, 15 Oct 2021 at 09:58, Abner Chang <abner.chang@hpe.com> wrote:
>
> Compliant with BZ: #3665
> https://bugzilla.tianocore.org/show_bug.cgi?id=3665
>
> PcdPciMmio(32)64Translation PCD is relocated to MdePkg that leveraged
> by both ARM and RISC-V arch. This patch uses the one from MdePkg
> instead the one under ArmVirtPkg.
>
ArmVirtPkg??
> Signed-off-by: Abner Chang <abner.chang@hpe.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
> ---
> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> index 91b8c7792e..af20739120 100644
> --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
> @@ -403,11 +403,11 @@ DEFINE X64EMU_ENABLE = FALSE
>
> gArmTokenSpaceGuid.PcdPciMmio32Base|0x40000000
> gArmTokenSpaceGuid.PcdPciMmio32Size|0x80000000
> - gArmTokenSpaceGuid.PcdPciMmio32Translation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation|0x0
>
> gArmTokenSpaceGuid.PcdPciMmio64Base|0x100000000
> gArmTokenSpaceGuid.PcdPciMmio64Size|0x7F00000000
> - gArmTokenSpaceGuid.PcdPciMmio64Translation|0x0
> + gEfiMdePkgTokenSpaceGuid.PcdPciMmio64Translation|0x0
>
> ## Use PCI emulation for ATA PassThru
> # gEfiMdeModulePkgTokenSpaceGuid.PcdAtaPassThruPciEmulation|TRUE
> --
> 2.17.1
>
[-- Attachment #2: Type: text/html, Size: 4071 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-10-15 8:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 6:59 [edk2-platforms][PATCH 0/9] Use PcdPciMmio(32)64Translation PCDs from MdePkg Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 1/9] Platform/OverdriveBoard: Use PcdPciMmio(32)64Translation PCD " Abner Chang
2021-10-15 7:59 ` Ard Biesheuvel
2021-10-15 8:13 ` [edk2-devel] " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 2/9] Platform/CelloBoard: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 3/9] Platform/Overdrive1000Board: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 4/9] Silicon/Styx: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 5/9] Platform/ARM: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 6/9] Platform/SabaQemu: " Abner Chang
2021-10-15 7:00 ` [edk2-platforms][PATCH 7/9] Silicon/SabaQemu: " Abner Chang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox