Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

["Leif Lindholm" <leif@nuviainc.com>]

On Thu, Oct 14, 2021 at 06:05:59 -0600, Rebecca Cran wrote:
> Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>

Acked-by: Leif Lindholm <leif@nuviainc.com>

Merged as 7e43d3e08611.

Thanks!

/
    Leif

> 
> On 10/14/21 1:23 AM, Ming Huang wrote:
> > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
> > for 64K granularity.
> > 
> > Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
> > ---
> >   ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > index fb484086a4..4b409ff745 100644
> > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation (
> >       CacheSize32 = CacheSize16;
> >     } else if ((CacheSize64 / 64) < MAX_INT16) {
> >       CacheSize16 = (1 << 15) | (CacheSize64 / 64);
> > -    CacheSize32 = CacheSize16;
> > +    CacheSize32 = (1 << 31) | (CacheSize64 / 64);
> >     } else {
> >       if ((CacheSize64 / 1024) <= 2047) {
> >         CacheSize32 = CacheSize64;