From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54])
 by mx.groups.io with SMTP id smtpd.web12.7684.1634295136213948876
 for <devel@edk2.groups.io>;
 Fri, 15 Oct 2021 03:52:16 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@nuviainc-com.20210112.gappssmtp.com header.s=20210112 header.b=RcKVTI05;
 spf=pass (domain: nuviainc.com, ip: 209.85.128.54, mailfrom: leif@nuviainc.com)
Received: by mail-wm1-f54.google.com with SMTP id v127so2182774wme.5
        for <devel@edk2.groups.io>; Fri, 15 Oct 2021 03:52:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=nuviainc-com.20210112.gappssmtp.com; s=20210112;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to;
        bh=XAARn32nN5AkkDEJrMR7yZrc/wklCFE2HrM9vtDIOXg=;
        b=RcKVTI05IG5m986p+SEgCDNfS1DZ5gTFj0vHSiRYPuuNC0uPwr81NN1i+z9nT9TwrU
         FJlUX75cwuKMoyCmlsNZ2K8R7rtvSJKaYIlPS0y7vFlPYXcqBedQky5HGO1jkBgXEA5T
         9+BWti3mNdiuCnoBsT8EuA2K3SNaXwMl9q4CkpF6qFEyJCWODj+7+jOtKMipeMKZjl8I
         5z7HasrA4bDvQMX5v0tm3qVHF08JVFEp+yRT4zaU/y3PhLCYUPuynsI1jooOfuKcAewo
         69oQeGoe3UnW8a+gvJL66/6Z/yX6uEGzF2wnmWOGSjo6e0qOzHqC7qn33egY0n/uwzXf
         MHVw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to;
        bh=XAARn32nN5AkkDEJrMR7yZrc/wklCFE2HrM9vtDIOXg=;
        b=1sviAAZUxvUeE3A3yGcvSGa6ShQS3jxV0Te1xO27RPjNV29zSKNlvgslR6FmBZDGpt
         1sx9aSumZAYgOwy/Pm1uVddKWshuVbw+Pp/ZC225JYWaABPdERWQxgBs30QslMq5t0FN
         zatiAUAgY+yyoRPimxOmVbniDY4jazgkrft6Xq7OddKLyIHnKe1svcji04Es6s8olohG
         xQSHHvZ1IG7KdLeNbqpVQwiQ9mHX3+STOR43t2islreLpeCFfxgToykPqzsjRyJPBuJH
         jbfBy+dTC6UA8gomF0FYRuVeB1QUSoGkD4yysv213CdAvaXe9r7VvnF+5MnzVEQPAmhL
         yYfA==
X-Gm-Message-State: AOAM5325mIIqEnU9fSOk4esQPX1XIh3KZYpWIbAdrqu4YYAbAE8tpEvc
	QGgLeIXqu5vGB32IJQEYKBOM5A==
X-Google-Smtp-Source: ABdhPJy5VsygXSn2MzaztDVXzPxJ4TpnsCrywPFC2oMSXP2UzB+plnXrFveOk2U4D3ROEzJqrs1bIw==
X-Received: by 2002:a7b:c94d:: with SMTP id i13mr11782023wml.121.1634295134820;
        Fri, 15 Oct 2021 03:52:14 -0700 (PDT)
Return-Path: <leif@nuviainc.com>
Received: from leviathan (cpc92314-cmbg19-2-0-cust559.5-4.cable.virginm.net. [82.11.186.48])
        by smtp.gmail.com with ESMTPSA id d9sm4607239wrm.96.2021.10.15.03.52.13
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 15 Oct 2021 03:52:14 -0700 (PDT)
Date: Fri, 15 Oct 2021 11:52:12 +0100
From: "Leif Lindholm" <leif@nuviainc.com>
To: Rebecca Cran <rebecca@nuviainc.com>
Cc: devel@edk2.groups.io, huangming@linux.alibaba.com,
	ardb+tianocore@kernel.org, ming.huang-@outlook.com
Subject: Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue
Message-ID: <20211015105212.ancd2gnofbaeifrw@leviathan>
References: <20211014072314.54891-1-huangming@linux.alibaba.com>
 <89a4aecb-12d5-ddc1-e5a5-0055e8e04aee@nuviainc.com>
MIME-Version: 1.0
In-Reply-To: <89a4aecb-12d5-ddc1-e5a5-0055e8e04aee@nuviainc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 14, 2021 at 06:05:59 -0600, Rebecca Cran wrote:
> Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>

Acked-by: Leif Lindholm <leif@nuviainc.com>

Merged as 7e43d3e08611.

Thanks!

/
    Leif

> 
> On 10/14/21 1:23 AM, Ming Huang wrote:
> > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1
> > for 64K granularity.
> > 
> > Signed-off-by: Ming Huang <huangming@linux.alibaba.com>
> > ---
> >   ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > index fb484086a4..4b409ff745 100644
> > --- a/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > +++ b/ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c
> > @@ -219,7 +219,7 @@ ConfigureCacheArchitectureInformation (
> >       CacheSize32 = CacheSize16;
> >     } else if ((CacheSize64 / 64) < MAX_INT16) {
> >       CacheSize16 = (1 << 15) | (CacheSize64 / 64);
> > -    CacheSize32 = CacheSize16;
> > +    CacheSize32 = (1 << 31) | (CacheSize64 / 64);
> >     } else {
> >       if ((CacheSize64 / 1024) <= 2047) {
> >         CacheSize32 = CacheSize64;