From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web09.5140.1634615357131233158 for ; Mon, 18 Oct 2021 20:49:24 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=BOQcyxHl; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=092675a635=daniel.schaefer@hpe.com) Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19ILhQZa003763; Tue, 19 Oct 2021 03:49:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : content-transfer-encoding : content-type : mime-version; s=pps0720; bh=dnVn8GP/AIYGok/7XOyV5Dcg/hrzOdCjibwtkNwdejY=; b=BOQcyxHlFrZKvphmbXoiydTjzIwO3pmt7J3HgqMjPDij8y2oF7thqVEel0lC2hDsko1g dNMF9gCZ4tjKAiZUtfGxE4Gmso6X+cgQXWAaS/5+xrN+ptvISsTGc1r1BsTMLZ/HDoQl 3macClrNseXolz+ad6PisoblCsu8eJAzLIVqPue38efsoFX3h1A8uivOf/8Rx2YKDI5Q DiSxYfj5dLgQ3Thuxy+0DegMljgvZ2lTXhrATpmtarBtIWO3u0a4bI1A1Ev0pFA0sFEL yMxKqp2OZpDqs+bTtDZR08P8auJJUE47VVleq4oS4z9AQOz1ytBqxVZXSe83J9tzFZUa Pw== Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 3bsbpkccus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Oct 2021 03:49:16 +0000 Received: from G9W9210.americas.hpqcorp.net (g9w9210.houston.hpecorp.net [16.220.66.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g9t5009.houston.hpe.com (Postfix) with ESMTPS id 6115B51; Tue, 19 Oct 2021 03:49:15 +0000 (UTC) Received: from G4W10204.americas.hpqcorp.net (2002:10cf:5210::10cf:5210) by G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 19 Oct 2021 03:49:15 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (15.241.52.10) by G4W10204.americas.hpqcorp.net (16.207.82.16) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Tue, 19 Oct 2021 03:49:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbDXhy9+/exEXpezI2dbTyiAH7/rG9jBk7eZEiCO1kb3hwxTL7+tb0fKBge1JsLopOBKvMttelCOBmTVC4gb978NH0F5/0s84AaFsPCNYkXwrIt3GA2jEPIOYl6yvNDeKYYo+OZXUTiZ1w7Sut7oRNqDObWYloCa2+dkWan1RBOwWZap+wORSsLyRxLFQPZjn1XAVpzBH4rIM+Un6hGg9SvoN+rGphRHZj2bOnR+uSLlqTjrpF0CloBqLIzWgE64SvL0c0HDrl7Kev3ms8+/BO4918R/K8noY0iCKdc4WG3XQymqCCmKUfWnDlESzqVt4SJKVLFpvV05VBv8tEaSGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dnVn8GP/AIYGok/7XOyV5Dcg/hrzOdCjibwtkNwdejY=; b=CbgPpdfZgxZQ97wi76eHvJZIEZr5GFRGLLG2JL+JhhoJLuBmKuh4rSyJDSbSNfnm/W75N4nNf+RsPoXB4a4fva7q4+0X53KFtw3okrpeJUnzI7cfe061jaFIRsG8RKPskHCsBcaR+jee7kKo1Z1j1H6Hyxki7r1c7xPzIELcq5I1A+4k970VuYIf5/bl+WdpRhshWCZ6JcuJsaQfTpLa9bFpf9LYtKrCBfvgTpp2mZTGdR10+LlO/V5l6MhXIOq6Wmd/2RwB9cqOiAX4qw+fnsFowysooHNpf+tHL09gVZ0kagirMSvAUHfDz0MHu5xjq+mBfH84ViHf51ROLKnyOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB1321.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7613::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 03:49:14 +0000 Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469%3]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 03:49:14 +0000 From: "Daniel Schaefer" To: CC: Daniel Schaefer , Abner Chang , Sunil V L Subject: [edk2-platforms] [PATCH v3 02/14] RISC-V: Split SMBIOS out of PlatformPei Date: Tue, 19 Oct 2021 11:48:37 +0800 Message-ID: <20211019034849.16847-3-daniel.schaefer@hpe.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211019034849.16847-1-daniel.schaefer@hpe.com> References: <20211019034849.16847-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: SG2PR03CA0134.apcprd03.prod.outlook.com (2603:1096:4:c8::7) To DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) MIME-Version: 1.0 Received: from zbook-nix.wireless.hpe.com (15.211.146.34) by SG2PR03CA0134.apcprd03.prod.outlook.com (2603:1096:4:c8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.11 via Frontend Transport; Tue, 19 Oct 2021 03:49:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5f84c22-98b5-4060-4785-08d992b36ac1 X-MS-TrafficTypeDiagnostic: DF4PR8401MB1321: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +D4IjheZSyW3SiBOE/lw+JXJdGumbP3eVge896WR4TQTX+U3QPA3zcDC/Ua89K1+MNqxZ2UbC3DDN3wpAEwh82g3TzyEjiwBVZxVc9RfDYe4kZD4tDZVwZH9ChrVYFHXaARaeViZgAnZllqq8ypNelsZJHAtsDotlLfcYXfdfczqFuXOSZgeAMefyXm67Ri1mDeVLnznEszu/HZOey1YVCOixKsQfKKOBdnY0R0ZbFfeFH7zLF27jNebE0HLdh8TKdpGJIkfne+avpGjHt/Z85SKMWIMeYvMtB6ue2S9k4evgWPCX4yRlyosm+jWlnlL3Dy9DKGbShVq2y1HoDBriYXquOQR7FbIgju552p8ADUbYG+ofEikBZogLgkIlIuaXz9npPpgFPoPhThfdw1AFk8r2jxANGh3yzEIT1xKk/xXobd5jx+YhO73CCNYv2Iw5QWyAlzIloAWmbDsxzjXlt3FHAzzRjAUJhYCkkw9jwZzt35BBASMJ2Im3zmJmx7PhxDEA7gkN82qTqVxm1EB3uOxYM1Bp2OIgApZ9ygPzHoh3YY+LF8XojdJI1Kh3KDntkufnqOnS9adS38ExoFwCTCoCfFEZWNzX6Olkgq8ujZZAfI0t7KM5ZoBkVbE6L9l/CvZ6m/rt9cURs1JIQTQODz23Gc+nUyFJxifj/HgIte0Qnwdjaajos1/xIyr8jvkTKmr3x73y7VqsW1901LPPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(1076003)(83380400001)(6486002)(36756003)(44832011)(316002)(5660300002)(6916009)(8936002)(6666004)(2906002)(26005)(54906003)(38100700002)(38350700002)(2616005)(956004)(86362001)(52116002)(7696005)(8676002)(66476007)(19627235002)(4326008)(508600001)(66556008)(186003)(82960400001)(66946007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zr5/yQUhDzwOriIzdEyZszieqOs/jRNhFcd8aUQ3Xk5S2SHdkyEIZU1fcYDs?= =?us-ascii?Q?zxhm4o0B3034O6dAvZDfyRYwtfMGJl+BTxbVYnA+NOdPmK3pEnQlGHa6gpzG?= =?us-ascii?Q?MW0hXAT9+c2Q27U3HOHg0TzZFAMLwkoXI1EfgI0o3EcF8KrdRFvZDm1sa3qb?= =?us-ascii?Q?iGzF91C/X+QN+jeFj99jSmjK2xVO7f4cBEgEpNDLYCNJ/KejS03N7KOPCIqh?= =?us-ascii?Q?uqwVUEMQEkEnmF8jvI1hHZdbV8pBwLANG8xWD+ddVg08qHiU0MTAHDrXOCxm?= =?us-ascii?Q?waCUXrdIfSDIaTlUi2UtwPMgnbXPKMuzehWJJn2uBVZNwDS45Y/FeBEYycqc?= =?us-ascii?Q?JHxcX96Q/QkGlAMzhnve23Vf58DVoXbjjLwnWSDIkypaDy1eLCIX3uy8g5dl?= =?us-ascii?Q?Lp0t/Fdnjb2SqHJ3wxPVfdw6SA7Z6xC6sTnLmd53N4Ol54b9yoNyCjlNRFKi?= =?us-ascii?Q?nnZcUTB/67B646bG4WTEnigTaPbxf1ry90C+x3UxxWo249ujLk2i7L1PYx/Q?= =?us-ascii?Q?5qMAm689n8eEmD4BK4AcUIOmltrAc+lohwOJsmmmygxbcC5X155h75yGJsuk?= =?us-ascii?Q?IAAD0WjjO095/CofJ1oI/g3AbW1pvJdUF3qimepAUYKTZu9tZc/Zgazpi3/w?= =?us-ascii?Q?IJfNtKEhKht/hZrbW4MWbVW30Zaq3E6Y0Hns9/2d8RpHPhtwzl7oPw9gOfLB?= =?us-ascii?Q?a5OitIr19oF+sIxdcXhd8RngG+qsqyfd9oTdIxxfMQy0oiUOe8fcDQE51eLg?= =?us-ascii?Q?KnDEdEQTsxkMcgIPjhvKbwcfrxFwbKN0eGl4VBHArH/ofTD896KoiyFaXje+?= =?us-ascii?Q?OnAShxuh0KNcb67YdWLxwwVl2C6oxQOVpLeo5bPndJcAT3VVD5AOPrGZ7scZ?= =?us-ascii?Q?82x1ed+fdXymx/ZBgDHBJS7ao9fiEp77Ql6jIr8AG310DU0Tkd7y7tBKgmko?= =?us-ascii?Q?Cm40M1CLprZLtd9BR7d0tw9UEfp+FxRzTWG6vlb9YRjRXuDJF50vNKVcVu0H?= =?us-ascii?Q?0343/inIu4XSYTFZTeTqcRvMxc7KtvoQp/lBmNj9EBYjhDezsh9ibpaqLpuO?= =?us-ascii?Q?11eD6byDB9HG0vwtfXN1fk8O5aRtbj0HYQK3kGeUaPPa5UpjSfK8Va8JbZ7e?= =?us-ascii?Q?Kla9iONUjnTWFqJWKuGCTqR5Z4nww8SfgAjexwDtmhJRTVXV0RUMdUqZAZ6C?= =?us-ascii?Q?BAmkclyeabTCMeT+sW1La7brZceEhR60dEPsz4zspYm556894C9wQHyQeGmQ?= =?us-ascii?Q?gTcMEDnM043l4xdRD2N+t8pJbb7DONZw4xkspMIBXjRue7RxjwNCTkxIFGwU?= =?us-ascii?Q?urTGuE7a93bGc59aBNjpF4Gm?= X-MS-Exchange-CrossTenant-Network-Message-Id: b5f84c22-98b5-4060-4785-08d992b36ac1 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 03:49:14.0987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mxKxK7QO/2hM3gaFoPs0kM5m1I8ffPlRTN7NTpPFwBjbbH3AQ9+2UejDxd5BfT+pPamygpHqb2uq+Vhh9R+r8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB1321 X-OriginatorOrg: hpe.com X-Proofpoint-GUID: V_OyNEh46LUVwQviUmCMeYfE9y5aFcBc X-Proofpoint-ORIG-GUID: V_OyNEh46LUVwQviUmCMeYfE9y5aFcBc X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-18_07,2021-10-18_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110190019 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h | 33 += +++---------------- Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c | 17 += --------- Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c | 32 += +++++++++++++++++- 3 files changed, 38 insertions(+), 44 deletions(-) diff --git a/Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h b/Pla= tform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h index 5d70e26f8359..363b34a8f1ac 100644 --- a/Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h +++ b/Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h @@ -1,7 +1,7 @@ /** @file=0D SiFive U54 Coreplex library definitions.=0D =0D - Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All right= s reserved.
=0D + Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All right= s reserved.
=0D =0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D @@ -17,35 +17,14 @@ #define SIFIVE_U5MC_COREPLEX_MC_HART_ID 0=0D =0D /**=0D - Build up U5MC coreplex processor core-specific information.=0D + Build processor and platform information for the U5 platform=0D =0D - @param UniqueId U5MC unique ID.=0D -=0D - @return EFI_STATUS=0D + @return EFI_SUCCESS Status.=0D =0D **/=0D EFI_STATUS=0D -EFIAPI=0D -CreateU5MCCoreplexProcessorSpecificDataHob (=0D - IN UINTN UniqueId=0D - );=0D -=0D -/**=0D - Function to build processor related SMBIOS information. RISC-V SMBIOS DX= E driver collect=0D - this information and build SMBIOS Type4 and Type7 record.=0D -=0D - @param ProcessorUid Unique ID of pysical processor which owns th= is core.=0D - @param SmbiosDataHobPtr Pointer to receive RISC_V_PROCESSOR_SMBIOS_D= ATA_HOB. The pointers=0D - maintained in this structure is only valid b= efore memory is discovered.=0D - Access to those pointers after memory is ins= talled will cause unexpected issues.=0D +BuildRiscVSmbiosHobs (=0D + VOID=0D +);=0D =0D - @return EFI_SUCCESS The PEIM initialized successfully.=0D -=0D -**/=0D -EFI_STATUS=0D -EFIAPI=0D -CreateU5MCProcessorSmbiosDataHob (=0D - IN UINTN ProcessorUid,=0D - OUT RISC_V_PROCESSOR_SMBIOS_HOB_DATA **SmbiosDataHobPtr=0D - );=0D #endif=0D diff --git a/Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform= .c b/Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c index 24192c692ba7..8586a94b6285 100644 --- a/Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c +++ b/Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c @@ -254,22 +254,7 @@ BuildCoreInformationHob ( VOID=0D )=0D {=0D - EFI_STATUS Status;=0D - RISC_V_PROCESSOR_SMBIOS_HOB_DATA *SmbiosHobPtr;=0D -=0D - // TODO: Create SMBIOS libs for non-U540 platforms=0D - Status =3D CreateU5MCCoreplexProcessorSpecificDataHob (0);=0D - if (EFI_ERROR (Status)) {=0D - ASSERT(FALSE);=0D - }=0D - Status =3D CreateU5MCProcessorSmbiosDataHob (0, &SmbiosHobPtr);=0D - if (EFI_ERROR (Status)) {=0D - ASSERT(FALSE);=0D - }=0D -=0D - DEBUG ((DEBUG_INFO, "U5 MC Coreplex SMBIOS DATA HOB at address 0x%x\n", = SmbiosHobPtr));=0D -=0D - return EFI_SUCCESS;=0D + return BuildRiscVSmbiosHobs ();=0D }=0D =0D /**=0D diff --git a/Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfo= Hob.c b/Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c index b2f74c2a743b..bc1b252946d9 100644 --- a/Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c +++ b/Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c @@ -1,7 +1,7 @@ /**@file=0D Build up platform processor information.=0D =0D - Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All right= s reserved.
=0D + Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All right= s reserved.
=0D =0D SPDX-License-Identifier: BSD-2-Clause-Patent=0D =0D @@ -32,6 +32,7 @@ @return EFI_SUCCESS The PEIM initialized successfully.=0D =0D **/=0D +STATIC=0D EFI_STATUS=0D EFIAPI=0D CreateU5MCCoreplexProcessorSpecificDataHob (=0D @@ -96,6 +97,7 @@ CreateU5MCCoreplexProcessorSpecificDataHob ( @return EFI_SUCCESS The SMBIOS Hobs were created successfully.=0D =0D **/=0D +STATIC=0D EFI_STATUS=0D EFIAPI=0D CreateU5MCProcessorSmbiosDataHob (=0D @@ -163,3 +165,31 @@ CreateU5MCProcessorSmbiosDataHob ( =0D return EFI_SUCCESS;=0D }=0D +=0D +/**=0D + Build processor and platform information for the U5 platform=0D +=0D + @return EFI_SUCCESS Status.=0D +=0D +**/=0D +EFI_STATUS=0D +BuildRiscVSmbiosHobs (=0D + VOID=0D +)=0D +{=0D + EFI_STATUS Status;=0D + RISC_V_PROCESSOR_SMBIOS_HOB_DATA *SmbiosHobPtr;=0D +=0D + Status =3D CreateU5MCCoreplexProcessorSpecificDataHob (0);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT(FALSE);=0D + }=0D + Status =3D CreateU5MCProcessorSmbiosDataHob (0, &SmbiosHobPtr);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT(FALSE);=0D + }=0D +=0D + DEBUG ((DEBUG_INFO, "U5 MC Coreplex SMBIOS DATA HOB at address 0x%x\n", = SmbiosHobPtr));=0D +=0D + return EFI_SUCCESS;=0D +}=0D --=20 2.31.1