From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (NAM12-DM6-obe.outbound.protection.outlook.com [40.107.243.71]) by mx.groups.io with SMTP id smtpd.web11.14915.1634672410029421003 for ; Tue, 19 Oct 2021 12:40:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=1JQnRSl3; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.243.71, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CaJsT14PlhEegVmdZUzaavfFW2Vhk87yAvnr973bDUgvLj0O1NNlOnnoMeF/041ik/YFkxF00m4ytzzlYJl+CXqmT9kPP7/MI41R94e9oZqmf+z+YCXujYb83jZrrxH/KAw4DMv/NASMcs+ppjzcJL/M0pkGNU9PAGIiObcCK1/+l+JoyGJwNUd4IlpzjmpbPXUPg77F1SWPcGQYdbt/7wFFMbHJ3Q5PEG+YEfyptMNLACMIaUgmIYOwJvUqzGMeGhlt3CTiBApA4/GuzOr1FxDJ/sI0jIPMEPIskZJMZ4IC8UIO2rLKWfWZn2hzdNRDYujY1RWKkQJtaRJUcOTn+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SdqEi/hiG4DrOwBF9Lc+IoqBY5pXJOfBTErpOqjvO4c=; b=lpbCousNrr4ZK3qkQfCj2FkHfU/QuhAUuV3o1rD2YhUQSCFbXSIvYSe0jH5spX7ouROQ/PQzf071MN67aVh+yrY+zaEkq04G6WU6uvAm8bxoAZhQI54EWvPemD6gDn0etwaGET+ZVEVpUSA8pVGZ9EMWNwzzcsVJ724U8XET+gDNb+fQziiQGleKpeWO9babfpnz99aW8+Gh/v3NCwa5gOYspZtNlkPGP0+SG9CqSSXnKzTDFubP5j3lIUKZQlBKW4RfIOE5mOAorRuZXQDaO4QD5cf+UClKjHZ1PvF7S9IpLTUrwq6IC/LW1CwnVAAiAc2y4Gl4UjWKOwA6JkWhMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdqEi/hiG4DrOwBF9Lc+IoqBY5pXJOfBTErpOqjvO4c=; b=1JQnRSl3xkCoTsvgpEXl9aQr9Qe/EG4V9D7ET4C1O4l+3rVBgjeoyOzNDLbAH7rSr85umZQI2yUD7fAgj99BeiHD6xORMSMPmo6DAcDn4uPWZFBdmQ1X8WiT9NScto8RZ4zyI+stJyicccbBN7/M7FVGwYX6QGoYKuVa1ratyV0= Received: from MWHPR14CA0050.namprd14.prod.outlook.com (2603:10b6:300:81::12) by DM6PR12MB4975.namprd12.prod.outlook.com (2603:10b6:5:1bd::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Tue, 19 Oct 2021 19:40:08 +0000 Received: from CO1NAM11FT004.eop-nam11.prod.protection.outlook.com (2603:10b6:300:81:cafe::e9) by MWHPR14CA0050.outlook.office365.com (2603:10b6:300:81::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 19:40:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT004.mail.protection.outlook.com (10.13.175.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4608.15 via Frontend Transport; Tue, 19 Oct 2021 19:40:07 +0000 Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Tue, 19 Oct 2021 14:40:02 -0500 From: "Brijesh Singh" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , Brijesh Singh , Michael Roth Subject: [PATCH v10 15/32] OvmfPkg/MemEncryptSevLib: add function to check the VMPL0 Date: Tue, 19 Oct 2021 14:39:17 -0500 Message-ID: <20211019193934.1052465-16-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211019193934.1052465-1-brijesh.singh@amd.com> References: <20211019193934.1052465-1-brijesh.singh@amd.com> MIME-Version: 1.0 Return-Path: brijesh.singh@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2882c03b-81ec-4426-1ce3-08d9933841af X-MS-TrafficTypeDiagnostic: DM6PR12MB4975: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HdHu7clRlxwlan7OmzkF5owpOTJ1vr2xaWhU3JfTtwIrEhvW7Y+1xNfHpSdXG5ouk1m43f1vXgik1sBddkjuGhq4Tiky4KwZ2ckAQrtoRJCYor5QueLsI0Amtme0SorZEnfpwV6JF60+Y+ktGx8zSvqAvaatmd3Ij9pfVvZwiU+73/ZjweUwAJRus1NR6JFQ4IF8FmUSNIy3BEaYcwStrnANnm6CYlJ9i0ToAZILHkjcR98+ApXA8+zB2ZG8EGqVolbKS5y3l8FJYAOUkEvnA8rNJRjj8lVCCAvgJVPV8X+84HqucfbtCdSwmQZYNR+7dJmGS5WOW/kzXEyDt6qMJmYZy+4fCACV4K1URIVczaF9iU+/S/w7keNEq9CKmrSEYS84CV/Nc+Yb6LnXms14e+Hn9yy9wDVtvjePR/hO0Qio+zzXesNTh2T13IY6y9v3hH2LD1RMbqi2aRXUIN/4WwGrO8DufgMmECRc1/gjEQjHP0/irzT98jEcgnbl/Eky6RcjMLyZzZrWAUmb27ABhq18WiSy0o5PUFYjg4kWSDBp29qYaSoL1EgyD7OHbzaTqVDUqtKAkLiqPBkmRY+wQG0B0iUG3AkrsMP8stilgWOK8aVNacBzT2DLcq5ctKcBu72ZAFX77Xso8ouDdDd4GyVROJZ2DHCiLSxfBZbglQjyNgmZG8lYY+m8r8nvFxYQkuI26Jm0TUdU0oc3oraaaKX63307mowc6ISMEjCahRI0r+FOTI1r0fFkOin0CpispTsFrPZHnufdHclEsY6nPfR5IJ96iKNbtcLz9UXybLYjzsaNPw6gu/yX5azH0lkw X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(7696005)(4326008)(8676002)(26005)(2616005)(6666004)(83380400001)(1076003)(36860700001)(54906003)(426003)(19627235002)(2906002)(356005)(6916009)(5660300002)(82310400003)(508600001)(70206006)(316002)(8936002)(336012)(86362001)(44832011)(47076005)(36756003)(966005)(186003)(81166007)(70586007)(16526019)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Oct 2021 19:40:07.7523 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2882c03b-81ec-4426-1ce3-08d9933841af X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT004.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4975 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Virtual Machine Privilege Level (VMPL) feature in the SEV-SNP architecture allows a guest VM to divide its address space into four levels. The level can be used to provide the hardware isolated abstraction layers with a VM. The VMPL0 is the highest privilege, and VMPL3 is the least privilege. Certain operations must be done by the VMPL0 software, such as: * Validate or invalidate memory range (PVALIDATE instruction) * Allocate VMSA page (RMPADJUST instruction when VMSA=3D1) The initial SEV-SNP support assumes that the guest is running on VMPL0. Let's add function in the MemEncryptSevLib that can be used for checking whether guest is booted under the VMPL0. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Brijesh Singh --- .../X64/SnpPageStateChange.h | 5 ++ .../X64/SecSnpSystemRamValidate.c | 46 +++++++++++++++++++ .../X64/SnpPageStateChangeInternal.c | 1 - 3 files changed, 51 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h = b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h index 8bbdf06468b9..cc1318075523 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h @@ -28,4 +28,9 @@ InternalSetPageState ( IN BOOLEAN UseLargeEntry ); =20 +VOID +SnpPageStateFailureTerminate ( + VOID + ); + #endif diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValida= te.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c index 64aab7f45b6d..3394094a65e5 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c @@ -14,6 +14,43 @@ =20 #include "SnpPageStateChange.h" =20 +// +// The variable used for the VMPL check. +// +STATIC UINT8 gVmpl0Data[4096]; + +/** + The function checks whether SEV-SNP guest is booted under VMPL0. + + @retval TRUE The guest is booted under VMPL0 + @retval FALSE The guest is not booted under VMPL0 + **/ +STATIC +BOOLEAN +SevSnpIsVmpl0 ( + VOID + ) +{ + UINT64 Rdx; + EFI_STATUS Status; + + // + // There is no straightforward way to query the current VMPL level. + // The simplest method is to use the RMPADJUST instruction to change + // a page permission to a VMPL level-1, and if the guest kernel is + // launched at a level <=3D 1, then RMPADJUST instruction will return + // an error. + // + Rdx =3D 1; + + Status =3D AsmRmpAdjust ((UINT64) gVmpl0Data, 0, Rdx); + if (EFI_ERROR (Status)) { + return FALSE; + } + + return TRUE; +} + /** Pre-validate the system RAM when SEV-SNP is enabled in the guest VM. =20 @@ -32,5 +69,14 @@ MemEncryptSevSnpPreValidateSystemRam ( return; } =20 + // + // The page state change uses the PVALIDATE instruction. The instruction + // can be run on VMPL-0 only. If its not VMPL-0 guest then terminate + // the boot. + // + if (!SevSnpIsVmpl0 ()) { + SnpPageStateFailureTerminate (); + } + InternalSetPageState (BaseAddress, NumPages, SevSnpPagePrivate, TRUE); } diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInt= ernal.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeIntern= al.c index 506df12d4e51..653151d4a422 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInternal.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInternal.c @@ -40,7 +40,6 @@ MemoryStateToGhcbOp ( return Cmd; } =20 -STATIC VOID SnpPageStateFailureTerminate ( VOID --=20 2.25.1