* [PATCH] DynamicTablesPkg: Fix unitialized variable use
@ 2021-10-20 5:21 Moritz Fischer
2021-10-20 9:40 ` Sami Mujawar
0 siblings, 1 reply; 3+ messages in thread
From: Moritz Fischer @ 2021-10-20 5:21 UTC (permalink / raw)
To: devel; +Cc: Sami Mujawar, Alexei Fedorov
In the success case we should return EFI_SUCCESS rather than returning
a potentially unitialized value of Status.
Cc: Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
Signed-off-by: Moritz Fischer <moritzf@google.com>
---
.../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
index 0bdb6c24c5bb..e9e1a85ede63 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
@@ -91,7 +91,7 @@ LinkRdNode (
*NewRdNode = RdNode;
}
- return Status;
+ return EFI_SUCCESS;
error_handler:
Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);
--
2.33.0.1079.g6e70778dc9-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] DynamicTablesPkg: Fix unitialized variable use
2021-10-20 5:21 [PATCH] DynamicTablesPkg: Fix unitialized variable use Moritz Fischer
@ 2021-10-20 9:40 ` Sami Mujawar
2021-10-20 10:10 ` Sami Mujawar
0 siblings, 1 reply; 3+ messages in thread
From: Sami Mujawar @ 2021-10-20 9:40 UTC (permalink / raw)
To: Moritz Fischer, devel; +Cc: Alexei Fedorov, nd
Hi Moritz,
Thank you for this fix.
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
Regards,
Sami Mujawar
On 20/10/2021 06:21 AM, Moritz Fischer wrote:
> In the success case we should return EFI_SUCCESS rather than returning
> a potentially unitialized value of Status.
>
> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> Signed-off-by: Moritz Fischer <moritzf@google.com>
> ---
> .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> index 0bdb6c24c5bb..e9e1a85ede63 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
> @@ -91,7 +91,7 @@ LinkRdNode (
> *NewRdNode = RdNode;
> }
>
> - return Status;
> + return EFI_SUCCESS;
>
> error_handler:
> Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] DynamicTablesPkg: Fix unitialized variable use
2021-10-20 9:40 ` Sami Mujawar
@ 2021-10-20 10:10 ` Sami Mujawar
0 siblings, 0 replies; 3+ messages in thread
From: Sami Mujawar @ 2021-10-20 10:10 UTC (permalink / raw)
To: Moritz Fischer, devel; +Cc: Alexei Fedorov, nd
Merged as 37a33f02aa1a..4fdf843c75d2
Thanks.
Regards,
Sami Mujawar
On 20/10/2021 10:40 AM, Sami Mujawar wrote:
> Hi Moritz,
>
> Thank you for this fix.
>
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
>
> Regards,
>
> Sami Mujawar
>
> On 20/10/2021 06:21 AM, Moritz Fischer wrote:
>> In the success case we should return EFI_SUCCESS rather than returning
>> a potentially unitialized value of Status.
>>
>> Cc: Sami Mujawar <Sami.Mujawar@arm.com>
>> Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
>> Signed-off-by: Moritz Fischer <moritzf@google.com>
>> ---
>> .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
>> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
>>
>> index 0bdb6c24c5bb..e9e1a85ede63 100644
>> ---
>> a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
>> +++
>> b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c
>> @@ -91,7 +91,7 @@ LinkRdNode (
>> *NewRdNode = RdNode;
>> }
>> - return Status;
>> + return EFI_SUCCESS;
>> error_handler:
>> Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-20 10:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 5:21 [PATCH] DynamicTablesPkg: Fix unitialized variable use Moritz Fischer
2021-10-20 9:40 ` Sami Mujawar
2021-10-20 10:10 ` Sami Mujawar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox