From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.55]) by mx.groups.io with SMTP id smtpd.web08.6401.1634726965573362134 for ; Wed, 20 Oct 2021 03:49:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=AAfF+Z8u; spf=pass (domain: arm.com, ip: 40.107.21.55, mailfrom: christopher.jones@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ujkkf4KbIT1aV7gtURELHdR82CprSowGysDHST669DM=; b=AAfF+Z8u30KD7d5SwLXMSv1s2IAEcG8uCzGbJZpSuhieSuXUHsMJHpGKkaMYcLvRRfsnOtAWaAsZuIkGWbwrUlbGcHrROWJ/zJC1ArKBM6M6ii8SDoM3157Qy0YdCsNV3cuKEiAV9doqRWMWgZbawBpZ6ruScbp0xqVn8lJxJRg= Received: from DB6PR0601CA0013.eurprd06.prod.outlook.com (2603:10a6:4:7b::23) by PR2PR08MB4779.eurprd08.prod.outlook.com (2603:10a6:101:1e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 10:49:22 +0000 Received: from DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::e5) by DB6PR0601CA0013.outlook.office365.com (2603:10a6:4:7b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 10:49:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT014.mail.protection.outlook.com (10.152.20.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 20 Oct 2021 10:49:22 +0000 Received: ("Tessian outbound 2e7020cc8961:v103"); Wed, 20 Oct 2021 10:49:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: eec1585cf2d52df6 X-CR-MTA-TID: 64aa7808 Received: from 450b76b7d42d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 07C0326F-3CB6-4D16-A56A-B333FDAE1C0C.1; Wed, 20 Oct 2021 10:47:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 450b76b7d42d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Oct 2021 10:47:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDIiUzwRN0knh8d2OEiWTU4sXfe08svivs2aXv51n2q/CIiQhgxe23nPaj+ycVo4BIKv2MERjL58Qh5sQfKxK3u2h/QF9BPiSpgCsS8cfyRuqTaKnz2OqEgj2lqgQs7NvIVSAr6LXk0CLXGwVfmugyauEw/gPN16SdtqGIKMli/1/XJ8mpUsds9V1NUqOe3rm6ByKPOsAkdAhChSo7GOSMume8BRaG+3gRTvzYIzPwWShwV4+2A7fZrOA9yAJxvMHBi/g74oQHXtQwDuXEkM5ZaLZyB4tjzcYadwOBHZm4GLWqYI+wISdh9Qse+iegGtLOjl/UjiUsAi73ofA22zUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ujkkf4KbIT1aV7gtURELHdR82CprSowGysDHST669DM=; b=NRRowq5EwnIlvBP/Fx4RhMbXWyOS4MCJEH1Oj0+3gOI0Mp9zU6lhMd3oKpyrdSIVgI2gnlx2KPyfYGFTpMRwLRI/+AlI4U7YgKwMZrKeS/rmnlW2ddUgb9e92Ol4A4Ax+ZZyzAs7NEP2ZaBmuR4CTLkrXeFiHAptoBocj+UvvTD7bUxZEvjtOKmAkz9dDpDOUNYqV+Mw7s/6TVJ6JgMLZnuNUaQXCKn35A0U7elVzx8Hx3xFOBKS/6+9FiQZ9fq2437c+1+3cEPj3JQ7R/IntDqVJU1RIQs9X5idrLkRdDjMjn7mCAdyFCuelHALu16l5IiybfXkd8nxstinIIxt0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ujkkf4KbIT1aV7gtURELHdR82CprSowGysDHST669DM=; b=AAfF+Z8u30KD7d5SwLXMSv1s2IAEcG8uCzGbJZpSuhieSuXUHsMJHpGKkaMYcLvRRfsnOtAWaAsZuIkGWbwrUlbGcHrROWJ/zJC1ArKBM6M6ii8SDoM3157Qy0YdCsNV3cuKEiAV9doqRWMWgZbawBpZ6ruScbp0xqVn8lJxJRg= Received: from AM7PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:20b:100::31) by DB6PR08MB2807.eurprd08.prod.outlook.com (2603:10a6:6:19::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.17; Wed, 20 Oct 2021 10:47:30 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::b5) by AM7PR02CA0021.outlook.office365.com (2603:10a6:20b:100::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 10:47:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4628.16 via Frontend Transport; Wed, 20 Oct 2021 10:47:29 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.14; Wed, 20 Oct 2021 10:47:19 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Wed, 20 Oct 2021 10:47:18 +0000 Received: from e125153.arm.com (10.57.27.61) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2308.14 via Frontend Transport; Wed, 20 Oct 2021 10:47:18 +0000 From: "Chris Jones" To: CC: , , , Subject: [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation Date: Wed, 20 Oct 2021 11:47:18 +0100 Message-ID: <20211020104718.13106-1-christopher.jones@arm.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86650f4d-4d89-485c-730e-08d993b74689 X-MS-TrafficTypeDiagnostic: DB6PR08MB2807:|PR2PR08MB4779: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6790;OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: t/aZNdrFpLZmXzIY2QH2zZgFoapx+vxNTbugMJeC5+PaHu4sdJ/0dn1C98JRtMZkIPdqO+64XGxftYTKT72EyHAGmZCrlBGesEdmBtdXN3+paDr9/+SA6PFbC5vpr8H5xvFEq1RAb2ZB6ZSroBgW7f8VJkQ9kCol8vjCcBLEc+DnK9HiXOBWffAGBDVr4U9Zo8iEKEYNL9Zr5GtMyT4zX/9N52R6eqcRXUeJSVhNSb3xFIOXBw13AuEuFeKfFAnv0CnA2qEN8LfBo8Xw//VgbORF9zU/fBcF9gCwFfdXlvn2W9i2A73zMzg25V+nhT2cHPQZm0Di99eil0bXSTHDp4AnZYfBfXKEanikSVMkzXyRPEBw3l97try27Ji5oPXQn0+Nxjl55q+avls0OGJYlcWTpvD/GN1VoBN6ujYFQUIOoB9v+v/obKiLnwIGI4IAI29GJcDYkykVRYgjl+nrn3P1w1FcEDx4NCt4V+Ku3hM4o+GPargP7fZqUgrWl32DwgyzZF5UzB7SMze7atnkAnll/ERQLuwIku3SKPL0PYWthV2I9NoDv4KwVm+ylmj/cHVtmCGi/X8iQf8dEKWGN85rLU7e+rWZlUssuc9/mZtTXdgdKRnrCvpfS/qIz4amR2S6O9XKqP7LQcvFnEyWH0clFjfw9Z9RK5m4W9LRy/dYCTar6qGU6uoAyKim+ztoOZeTRcrlZ3IFSfmf8WmSBqddJR3inLQ8HoDHPB+vnn8= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(36840700001)(46966006)(8676002)(6916009)(26005)(8936002)(4326008)(54906003)(508600001)(70206006)(86362001)(47076005)(81166007)(356005)(36756003)(1076003)(82310400003)(2906002)(83380400001)(336012)(186003)(2616005)(5660300002)(36860700001)(426003)(316002)(70586007)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2807 Return-Path: Christopher.Jones@arm.com X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9565c82c-0b56-43d6-c0da-08d993b70392 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Z8Ial9CvQBuhJGZWpmuiE7hwOOVTE7ZqN7EP0x2bTnVvj35zSFrkD48NJbDKzRLBkORlWJZzjAW2+gLPeKHFS4Vm5ej5lTEf1zL5oEYuQrCXsuWFqn1rKiZ4rYGQ44v3tKJNav/dM1Fh/u7gZ5NXlnN4GQPj0J+ryp7HREosvnNDlW7X+8Uw7SMq6+pJS4e4VrCt6hzxaV1rpku607GtV5y8FMJ0KPYgfkzxkEtUU8RF21VHx5TDiDEBl77OlatargQj+Bw5V5TCRAQUHfyt/Xb8QSw+5ep2COV3pVHnNZarISp0kSvoMxbabQjs2bkjFXZO2aWJagyfeWcIyIbGO3HvuB+UPVbSAUqRwxTAlCCR31P7Uc4sBuUmTNhhAv7FnBuLMRoYrSxoxOxuOpiKyUNamyu+USC/rmDcTj8NuOLcg5Vy5cynSr1zFJLxxHPd82msG0h2KWQaek6meHVPaHSWGIsEmnA8+0wyc0Iq2cPF/q9SphCy5pUDcLg8XjW0+DMkQKeFwap5zN8i6ztxlZW5uV0s6nTHnVbDIOIYO5fkd9yytEshmp//NsobD/LmwnewT5dixEFLD4I2MXGg1h8ZL+KfzrAkO3WyXR4KL/+gs+ChEZhJ/r9RrIptI4IW9BT6vPEtmk6edctxcqZUPdjqRf1W84D+weiPG7jVzvKF9eSDNbwc4zSUPQYV7zUjDCTyHjT4by0orST1rpE24g== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(82310400003)(47076005)(186003)(1076003)(336012)(5660300002)(8936002)(36860700001)(4326008)(83380400001)(426003)(2906002)(86362001)(70586007)(36756003)(70206006)(81166007)(2616005)(508600001)(6916009)(316002)(26005)(7696005)(8676002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Oct 2021 10:49:22.1277 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 86650f4d-4d89-485c-730e-08d993b74689 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4779 Content-Type: text/plain Add a comment to clarify that in Acpiview the ItemPtr is not set until after the FieldValidator has been called. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h index 0b7726b9d5807ad2f5c5447408c4c5451718938b..5e34a70c8baeaaa05ecd797d405f1fc62a44a305 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h @@ -283,7 +283,9 @@ typedef struct AcpiParser { FNPTR_PRINT_FORMATTER PrintFormatter; /// Optional pointer which may be set to request the parser to update - /// a pointer to the field data. If unused this must be set to NULL. + /// a pointer to the field data. This value is set after the FieldValidator + /// has been called and therefore should not be used by the FieldValidator. + /// If unused this must be set to NULL. VOID** ItemPtr; /// Optional pointer to a field validator function. -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")