From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Min Xu <min.m.xu@intel.com>
Cc: devel@edk2.groups.io, Ard Biesheuvel <ardb+tianocore@kernel.org>,
Jordan Justen <jordan.l.justen@intel.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Erdem Aktas <erdemaktas@google.com>,
James Bottomley <jejb@linux.ibm.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH V10 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm
Date: Thu, 21 Oct 2021 11:28:54 +0200 [thread overview]
Message-ID: <20211021092854.emghtoeawp6v62i5@sirius.home.kraxel.org> (raw)
In-Reply-To: <3659452251fb91060601f8a4b96fb64b82549fa2.1634774871.git.min.m.xu@intel.com>
On Thu, Oct 21, 2021 at 08:17:32AM +0800, Min Xu wrote:
> RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> Previously WORK_AREA_GUEST_TYPE was cleared in SetCr3ForPageTables64.
> This is workable for Legacy guest and SEV guest. But it doesn't work
> after Intel TDX is introduced. It is because all TDX CPUs (BSP and APs)
> start to run from 0xfffffff0, thus WORK_AREA_GUEST_TYPE will be cleared
> multi-times if it is TDX guest. So the clearance of WORK_AREA_GUEST_TYPE
> is moved to Main16 entry point in Main.asm.
> Note: WORK_AREA_GUEST_TYPE is only defined for ARCH_X64.
>
> For Intel TDX, its corresponding entry point is Main32 (which will be
> introduced in next commit in this patch-set). WORK_AREA_GUEST_TYPE will
> be cleared there.
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
next prev parent reply other threads:[~2021-10-21 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 0:17 [PATCH V10 0/4] Add Intel TDX support in OvmfPkg/ResetVector Min Xu
2021-10-21 0:17 ` [PATCH V10 1/4] OvmfPkg: Copy Main.asm from UefiCpuPkg to OvmfPkg's ResetVector Min Xu
2021-10-21 0:17 ` [PATCH V10 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm Min Xu
2021-10-21 9:28 ` Gerd Hoffmann [this message]
2021-10-21 0:17 ` [PATCH V10 3/4] OvmfPkg: Add IntelTdxMetadata.asm Min Xu
2021-10-21 0:17 ` [PATCH V10 4/4] OvmfPkg: Enable TDX in ResetVector Min Xu
2021-10-21 9:32 ` Gerd Hoffmann
2021-10-21 0:45 ` [PATCH V10 0/4] Add Intel TDX support in OvmfPkg/ResetVector Yao, Jiewen
2021-10-24 2:11 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021092854.emghtoeawp6v62i5@sirius.home.kraxel.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox