[edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

[edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

[Vu Nguyen]

Create edk2-non-osi component holder for Ampere Libraries. This patchset
also adds PciePhyLib which provides function to initialize PCIe PHY on
Ampere Altra processor.

Commits in this patchset can be found at:
https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib

Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Phong Vo <phong@os.amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>

Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>

Change since v3:
  Add wrapper function to hide the initialization code.
  Update header file.

Change since v2:
  Remove unused macros and function prototypes from the header file.
  Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.

Change since v1:
  Remove PciePhyLib.lib binary from the commit.
  Update header guard to align with coding standard.

Vu Nguyen (2):
  AmpereAltraBinPkg: Add PciePhyLib library
  edk2-non-osi: Add AmpereAltraBinPkg maintainers

 Maintainers.txt                               |  4 +++
 Silicon/Ampere/License.txt                    | 25 +++++++++++++++++++
 .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   | 16 ++++++++++++
 .../Library/PciePhyLib/PciePhyLib.inf         | 23 +++++++++++++++++
 .../Include/Library/PciePhyLib.h              | 25 +++++++++++++++++++
 5 files changed, 93 insertions(+)
 create mode 100644 Silicon/Ampere/License.txt
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
 create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h

-- 
2.17.1

[edk2-non-osi][PATCH v4 1/2] AmpereAltraBinPkg: Add PciePhyLib library

[Vu Nguyen]

Provide function to initialize the PCIe PHY on Ampere Altra processor.

Cc: Thang Nguyen <thang@os.amperecomputing.com>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
---
 Silicon/Ampere/License.txt                                         | 25 ++++++++++++++++++++
 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec             | 16 +++++++++++++
 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf | 23 ++++++++++++++++++
 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h      | 25 ++++++++++++++++++++
 4 files changed, 89 insertions(+)

diff --git a/Silicon/Ampere/License.txt b/Silicon/Ampere/License.txt
new file mode 100644
index 000000000000..27b640bf5ce2
--- /dev/null
+++ b/Silicon/Ampere/License.txt
@@ -0,0 +1,25 @@
+Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions
+are met:
+
+1. Redistributions of source code must retain the above copyright
+   notice, this list of conditions and the following disclaimer.
+2. Redistributions in binary form must reproduce the above copyright
+   notice, this list of conditions and the following disclaimer in
+   the documentation and/or other materials provided with the
+   distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
+FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
+COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
+INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
+BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
+LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
+LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
+ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
diff --git a/Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec b/Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
new file mode 100644
index 000000000000..32fcd6f6b9d4
--- /dev/null
+++ b/Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
@@ -0,0 +1,16 @@
+## @file
+#
+# Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  DEC_SPECIFICATION              = 0x0001001B
+  PACKAGE_NAME                   = AmpereAltraBinPkg
+  PACKAGE_GUID                   = 04F7CB64-0F97-4D05-86B8-34987F4E1B21
+  PACKAGE_VERSION                = 0.1
+
+[Includes]
+  Include
diff --git a/Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf b/Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
new file mode 100644
index 000000000000..a963b8910649
--- /dev/null
+++ b/Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
@@ -0,0 +1,23 @@
+## @file
+#
+# Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
+#
+# SPDX-License-Identifier: BSD-2-Clause-Patent
+#
+##
+
+[Defines]
+  INF_VERSION                    = 0x0001001B
+  BASE_NAME                      = PciePhyLib
+  FILE_GUID                      = F2AD0AD0-D4B6-11E3-9C1A-0800200C9A66
+  MODULE_TYPE                    = BASE
+  VERSION_STRING                 = 1.0
+  LIBRARY_CLASS                  = PciePhyLib
+
+[Binaries.AArch64]
+  LIB|PciePhyLib.lib|*
+
+[Packages]
+  MdePkg/MdePkg.dec
+  ArmPkg/ArmPkg.dec
+  ArmPlatformPkg/ArmPlatformPkg.dec
diff --git a/Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h b/Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
new file mode 100644
index 000000000000..aead1ed68379
--- /dev/null
+++ b/Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
@@ -0,0 +1,25 @@
+/** @file
+
+  Copyright (c) 2020 - 2021, Ampere Computing LLC. All rights reserved.<BR>
+
+  SPDX-License-Identifier: BSD-2-Clause-Patent
+
+**/
+
+#ifndef PCIE_PHY_LIB_H_
+#define PCIE_PHY_LIB_H_
+
+/**
+  Initialize the PCIe PHY.
+
+  @param[in] PhyBase           Base address of the PCIe PHY.
+
+  @retval RETURN_SUCCESS       PCIe PHY has been initialized successfully.
+  @retval RETURN_DEVICE_ERROR  Failed to initialize the PCIe PHY.
+**/
+RETURN_STATUS
+PciePhyInit (
+  IN PHYSICAL_ADDRESS   PhyBase
+  );
+
+#endif /* PCIE_PHY_LIB_H_ */
-- 
2.17.1

[edk2-non-osi][PATCH v4 2/2] edk2-non-osi: Add AmpereAltraBinPkg maintainers

[Vu Nguyen]

Cc: Thang Nguyen <thang@os.amperecomputing.com>
Cc: Chuong Tran <chuong@os.amperecomputing.com>
Cc: Phong Vo <phong@os.amperecomputing.com>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
---
 Maintainers.txt | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 6ac132cdf096..e3267eb6cfc3 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -58,6 +58,10 @@ Platform/Intel/CometlakeSiliconBinPkg
 M: Kathappan Esakkithevar <kathappan.esakkithevar@intel.com>
 M: Sai Chaganty <rangasai.v.chaganty@intel.com>
 
+Silicon/Ampere/AmpereAltraBinPkg
+M: Nhi Pham <nhi@os.amperecomputing.com>
+M: Vu Nguyen <vunguyen@os.amperecomputing.com>
+
 Silicon/Intel/ElkhartlakeSiliconBinPkg
 M: Nate DeSimone <nathaniel.l.desimone@intel.com>
 M: Sai Chaganty <rangasai.v.chaganty@intel.com>
-- 
2.17.1

Re: [edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

[Leif Lindholm]

On Fri, Oct 22, 2021 at 12:56:02 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides function to initialize PCIe PHY on
> Ampere Altra processor.
> 
> Commits in this patchset can be found at:
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> 
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>

For this series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

(But I'll still hold back on pushing until the main platform port goes
in.)

/
    Leif

> Change since v3:
>   Add wrapper function to hide the initialization code.
>   Update header file.
> 
> Change since v2:
>   Remove unused macros and function prototypes from the header file.
>   Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
> 
> Change since v1:
>   Remove PciePhyLib.lib binary from the commit.
>   Update header guard to align with coding standard.
> 
> Vu Nguyen (2):
>   AmpereAltraBinPkg: Add PciePhyLib library
>   edk2-non-osi: Add AmpereAltraBinPkg maintainers
> 
>  Maintainers.txt                               |  4 +++
>  Silicon/Ampere/License.txt                    | 25 +++++++++++++++++++
>  .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   | 16 ++++++++++++
>  .../Library/PciePhyLib/PciePhyLib.inf         | 23 +++++++++++++++++
>  .../Include/Library/PciePhyLib.h              | 25 +++++++++++++++++++
>  5 files changed, 93 insertions(+)
>  create mode 100644 Silicon/Ampere/License.txt
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
> 
> -- 
> 2.17.1
> 

Re: [edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

[Leif Lindholm]

Reviewed-by: Leif Lindholm <quic_llindhol@quicinc.com>

Pushed as 0320db977fb2..7dcfcf88b8a9 in preparation of pushing the
edk2-platforms set.

On Fri, Oct 22, 2021 at 12:56:02 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides function to initialize PCIe PHY on
> Ampere Altra processor.
> 
> Commits in this patchset can be found at:
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> 
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>
> 
> Change since v3:
>   Add wrapper function to hide the initialization code.
>   Update header file.
> 
> Change since v2:
>   Remove unused macros and function prototypes from the header file.
>   Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
> 
> Change since v1:
>   Remove PciePhyLib.lib binary from the commit.
>   Update header guard to align with coding standard.
> 
> Vu Nguyen (2):
>   AmpereAltraBinPkg: Add PciePhyLib library
>   edk2-non-osi: Add AmpereAltraBinPkg maintainers
> 
>  Maintainers.txt                               |  4 +++
>  Silicon/Ampere/License.txt                    | 25 +++++++++++++++++++
>  .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   | 16 ++++++++++++
>  .../Library/PciePhyLib/PciePhyLib.inf         | 23 +++++++++++++++++
>  .../Include/Library/PciePhyLib.h              | 25 +++++++++++++++++++
>  5 files changed, 93 insertions(+)
>  create mode 100644 Silicon/Ampere/License.txt
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
> 
> -- 
> 2.17.1
>