From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web11.4806.1634884802468210199
 for <devel@edk2.groups.io>;
 Thu, 21 Oct 2021 23:40:02 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZA95tToZ;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1634884800;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=ytjwof0rODyfORySfZDUtk9hR/HY1CmPuVTdV8xrYIA=;
	b=ZA95tToZAXSRAeuUfszjxjCJcGDagng6P+2rCbcK/kpsGlYpTV3bbv2nyzfQX++YwDiBmg
	7f2rSx4cgGR+b319pT/N/fZ9Z8PjLsKctygp1C+HLM6tS8LC2asu9IsFC7rgzA60t0Eu7U
	LeMQRODCaWpSiZNbIbm6622XWtu//4U=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-45-9W3LImytMkiVYYRz4Ks0bQ-1; Fri, 22 Oct 2021 02:39:55 -0400
X-MC-Unique: 9W3LImytMkiVYYRz4Ks0bQ-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EA49810A8E03;
	Fri, 22 Oct 2021 06:39:53 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.192.23])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 973A65DA61;
	Fri, 22 Oct 2021 06:39:50 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id E446E180060F; Fri, 22 Oct 2021 08:39:48 +0200 (CEST)
Date: Fri, 22 Oct 2021 08:39:48 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: devel@edk2.groups.io, James Bottomley <jejb@linux.ibm.com>,
	Min Xu <min.m.xu@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Erdem Aktas <erdemaktas@google.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	=?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option
Message-ID: <20211022063948.mratwrzgponwiulg@sirius.home.kraxel.org>
References: <20211021122003.2008499-1-kraxel@redhat.com>
 <20211021122003.2008499-5-kraxel@redhat.com>
 <03a75199-000f-5575-8898-6d9b113f2bee@linux.ibm.com>
MIME-Version: 1.0
In-Reply-To: <03a75199-000f-5575-8898-6d9b113f2bee@linux.ibm.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 21, 2021 at 09:24:55AM -0400, Stefan Berger wrote:
> 
> On 10/21/21 8:20 AM, Gerd Hoffmann wrote:
> > Allows to compile OVMF without HashInstanceLibSha1,
> > i.e. no SHA1 hash support in TPM/TCG modules.
> 
> Does that then mean that the SHA1 bank in a TPM 2 stays untouched, meaning
> the PCRs there won't get extended even though the bank is there and active?

Not fully sure.  The tcg2 config menu looks like this:

[ ... ]
   TPM2 Active PCR Hash       SHA1, SHA256
   Algorithm
   TPM2 Hardware Supported    SHA1, SHA256, SHA384,
   Hash Algorithm             SHA512
   BIOS Supported Hash        SHA256, SHA384, SHA512
   Algorithm
[ ... ]
   TCG2 Protocol Configuration
   Supported Event Log Format TCG_2
   Hash Algorithm Bitmap      SHA256, SHA384, SHA512
   Number of PCR Banks        3
   Active PCR Banks           SHA256

     PCR Bank: SHA1           [ ]
     PCR Bank: SHA256         [X]
     PCR Bank: SHA384         [ ]
     PCR Bank: SHA512         [ ]
[ ... ]

Which looks correct to me (SHA1 bank present but not active).

take care,
  Gerd