From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (NAM11-BN8-obe.outbound.protection.outlook.com [40.107.236.69]) by mx.groups.io with SMTP id smtpd.web09.2789.1634962477771161719 for ; Fri, 22 Oct 2021 21:14:38 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=udyEg18E; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.236.69, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NFARmjvFWvngS1GV0PH6369bTxCtDaSqUeG43NCaNpPsjCvCsb2FaVon50xp7HCwkuDkrl11kfSa8rNuwBCrm3AXXU1S5b5FqU1j0bIqyMFNcdEK48CS6hikfKp2t4EHZCcKOcUfsVbJxx9MtdhYXTBQMNgTNy61yEahK3Lgj8JMf3FZWlee4OwT54zUCUaDeRljpBTJnRG/YTzpQS8k4A8mI+I/8gouQaYvXnv5SOc9Vrd/YusI9hicQYQ6/pXu9TEyjUZi99fZaV7PxMysF7d/oqytREwuZJsGPwjmxyKd7Hyr7hRqSxSc1jOA+g5bOtK8Hy+y6zrZ7P6U6bX+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gqmcH/XH1iKjEQq4jwe5bvc0FS4PxpOdaseRluLWgDg=; b=oHVQnB6XN2rBx1OQLYHYKG4RCBxJdOi/3NoV75fZ8xc2sVP4jZCxc9L+dsS4aV2fvTd8ll1CMoX4tOhQqV5k2qbgE3oGoDeNntxnjFNY8kbZk8E/G7PExJVxDkI5w5UaqI72mOiyBuK3N5ZbzQGbKJla5VNGFbUQItWl5eo0b3RJvtMIX+/r30E6Y5aHTwqlmfd787rbyx94YUsj8oHEE20Ja3i3ahL+6OBOok1M96fcqfc13IB35TIB8hZjQxYuN+6t9zwUieeDRV1vcbpi595XlWDm2N4rvLKg46Z4bjI7VpK0p4GfXXuXyM45c+mUkEvEakkCiT71jOQd+WqrPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqmcH/XH1iKjEQq4jwe5bvc0FS4PxpOdaseRluLWgDg=; b=udyEg18ELdHHbljMNmKPUPDT5lHSgRWcp8yvpX8HJ5JvAQzxPrcEM35FxHxmTQ0vWYdWv+bf7p9VQBao6wxfdBcFcz1Z/kSX0D89nNUHiXPQALQQlOzEaYzYC/3693F7RVeovWebNrZTqQrhkmU2f+B6gRJZq0eggX7W4JqUiaY= Received: from DM5PR19CA0062.namprd19.prod.outlook.com (2603:10b6:3:116::24) by MWHPR12MB1824.namprd12.prod.outlook.com (2603:10b6:300:113::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Sat, 23 Oct 2021 04:14:33 +0000 Received: from DM6NAM11FT045.eop-nam11.prod.protection.outlook.com (2603:10b6:3:116:cafe::7f) by DM5PR19CA0062.outlook.office365.com (2603:10b6:3:116::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15 via Frontend Transport; Sat, 23 Oct 2021 04:14:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT045.mail.protection.outlook.com (10.13.173.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4628.16 via Frontend Transport; Sat, 23 Oct 2021 04:14:32 +0000 Received: from sbrijesh-desktop.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.15; Fri, 22 Oct 2021 23:14:29 -0500 From: "Brijesh Singh" To: CC: James Bottomley , Min Xu , "Jiewen Yao" , Tom Lendacky , "Jordan Justen" , Ard Biesheuvel , Erdem Aktas , "Michael Roth" , Gerd Hoffmann , Brijesh Singh , Michael Roth Subject: [PATCH v11 15/32] OvmfPkg/MemEncryptSevLib: add function to check the VMPL0 Date: Fri, 22 Oct 2021 23:13:32 -0500 Message-ID: <20211023041349.1263726-16-brijesh.singh@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211023041349.1263726-1-brijesh.singh@amd.com> References: <20211023041349.1263726-1-brijesh.singh@amd.com> MIME-Version: 1.0 Return-Path: brijesh.singh@amd.com X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f67c094-1d98-47ce-c5e6-08d995db9db1 X-MS-TrafficTypeDiagnostic: MWHPR12MB1824: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IwCeqc8KGnUJ67mkYG5q07MZQWKZcewBGPhZIpB1XkCa7rfeMbTtD+aFVGiV7cSq1lZZ9mkMXem2J9u4Y+kKg/StQ9+hZ5grZVge7k5e8HgeYoqe0Iw0KWZzz8c90auoChEzDvW+J7KRGmVB7DHin4Ye1BUwyaM4QcFwixzfXfccXsQ5SEf6Thl/RfUE5zuHwnBRXDDcBkgIUvYiAuJT/UfTA+n9CEjOvjtTuCuTbODLcVGPqrHrhEmkvx+OUIaRkaaa18SbiSSZtMveEghRzlaKz/fkyaKhind3zWUbbcuK+pcX5bq884l9wDBhpjF7Q0aSGYlmDl9smRWsk0RVA1CK/m2qTnYiqAts7MdmvVy8v9K4pgeBMGx8NzyLeMZ0JseMDWET+evUizyp/zss2PIf0zBGrPl10YNKtoFpU1oeaw65BmhsoNXEtJa43Lp35Qr/qHYvyUrsqDiFpDFDsutNGoVBDYTYxBtxuYf+rAXTebWkiNTYdFjh1DWcVK0q22i0zhd6+S059p3rWBgfCaChVG1Zu/0R8J25BEMM7Z8l13nYr+VLZqyHv8OSYLD+00FjaOq4LERCDk/ldDj+be/VOSz4Tdp5rfb7jfHNDjdcLYmZ9z4Fn/CUZ4TZkAAhz4CyhZJ7r+1Fp9CUrZ04jj9526y87EXhcm7XX3QuQfoZc5jfoV+m80gfVda9n5/L8S+O4bpghG8hMoI8AkpClMxUJ5S+j6bcWy2N59XdN8L/jhPj9gyoLZMtOkM6Jtj8Nm+3hM8EJpeXOsm5jW2IqeC4+SEHD9Ps6+izcuuUjXYW8pmE22S+ZTJSmLnm2RNA X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(2616005)(36756003)(8936002)(83380400001)(6916009)(2906002)(82310400003)(508600001)(36860700001)(7696005)(356005)(86362001)(966005)(44832011)(54906003)(426003)(8676002)(19627235002)(1076003)(4326008)(81166007)(70206006)(336012)(316002)(47076005)(16526019)(5660300002)(26005)(70586007)(186003)(6666004)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2021 04:14:32.4606 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f67c094-1d98-47ce-c5e6-08d995db9db1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT045.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1824 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3275 Virtual Machine Privilege Level (VMPL) feature in the SEV-SNP architecture allows a guest VM to divide its address space into four levels. The level can be used to provide the hardware isolated abstraction layers with a VM. The VMPL0 is the highest privilege, and VMPL3 is the least privilege. Certain operations must be done by the VMPL0 software, such as: * Validate or invalidate memory range (PVALIDATE instruction) * Allocate VMSA page (RMPADJUST instruction when VMSA=3D1) The initial SEV-SNP support assumes that the guest is running on VMPL0. Let's add function in the MemEncryptSevLib that can be used for checking whether guest is booted under the VMPL0. Cc: Michael Roth Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard Biesheuvel Cc: Erdem Aktas Cc: Gerd Hoffmann Acked-by: Gerd Hoffmann Signed-off-by: Brijesh Singh --- .../X64/SnpPageStateChange.h | 5 ++ .../X64/SecSnpSystemRamValidate.c | 46 +++++++++++++++++++ .../X64/SnpPageStateChangeInternal.c | 1 - 3 files changed, 51 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h = b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h index 8bbdf06468b9..cc1318075523 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChange.h @@ -28,4 +28,9 @@ InternalSetPageState ( IN BOOLEAN UseLargeEntry ); =20 +VOID +SnpPageStateFailureTerminate ( + VOID + ); + #endif diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValida= te.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c index 64aab7f45b6d..3394094a65e5 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SecSnpSystemRamValidate.c @@ -14,6 +14,43 @@ =20 #include "SnpPageStateChange.h" =20 +// +// The variable used for the VMPL check. +// +STATIC UINT8 gVmpl0Data[4096]; + +/** + The function checks whether SEV-SNP guest is booted under VMPL0. + + @retval TRUE The guest is booted under VMPL0 + @retval FALSE The guest is not booted under VMPL0 + **/ +STATIC +BOOLEAN +SevSnpIsVmpl0 ( + VOID + ) +{ + UINT64 Rdx; + EFI_STATUS Status; + + // + // There is no straightforward way to query the current VMPL level. + // The simplest method is to use the RMPADJUST instruction to change + // a page permission to a VMPL level-1, and if the guest kernel is + // launched at a level <=3D 1, then RMPADJUST instruction will return + // an error. + // + Rdx =3D 1; + + Status =3D AsmRmpAdjust ((UINT64) gVmpl0Data, 0, Rdx); + if (EFI_ERROR (Status)) { + return FALSE; + } + + return TRUE; +} + /** Pre-validate the system RAM when SEV-SNP is enabled in the guest VM. =20 @@ -32,5 +69,14 @@ MemEncryptSevSnpPreValidateSystemRam ( return; } =20 + // + // The page state change uses the PVALIDATE instruction. The instruction + // can be run on VMPL-0 only. If its not VMPL-0 guest then terminate + // the boot. + // + if (!SevSnpIsVmpl0 ()) { + SnpPageStateFailureTerminate (); + } + InternalSetPageState (BaseAddress, NumPages, SevSnpPagePrivate, TRUE); } diff --git a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInt= ernal.c b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeIntern= al.c index f9ab804a7edc..cffe703de9dd 100644 --- a/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInternal.c +++ b/OvmfPkg/Library/BaseMemEncryptSevLib/X64/SnpPageStateChangeInternal.c @@ -40,7 +40,6 @@ MemoryStateToGhcbOp ( return Cmd; } =20 -STATIC VOID SnpPageStateFailureTerminate ( VOID --=20 2.25.1