Re: [edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

["Leif Lindholm" <leif@nuviainc.com>]

On Fri, Oct 22, 2021 at 12:56:02 +0700, Vu Nguyen wrote:
> Create edk2-non-osi component holder for Ampere Libraries. This patchset
> also adds PciePhyLib which provides function to initialize PCIe PHY on
> Ampere Altra processor.
> 
> Commits in this patchset can be found at:
> https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib
> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Phong Vo <phong@os.amperecomputing.com>
> Cc: Thang Nguyen <thang@os.amperecomputing.com>
> 
> Signed-off-by: Vu Nguyen <vunguyen@os.amperecomputing.com>

For this series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

(But I'll still hold back on pushing until the main platform port goes
in.)

/
    Leif

> Change since v3:
>   Add wrapper function to hide the initialization code.
>   Update header file.
> 
> Change since v2:
>   Remove unused macros and function prototypes from the header file.
>   Rename Ac01BinPkg.dec to AmpereAltraBinPkg.dec.
> 
> Change since v1:
>   Remove PciePhyLib.lib binary from the commit.
>   Update header guard to align with coding standard.
> 
> Vu Nguyen (2):
>   AmpereAltraBinPkg: Add PciePhyLib library
>   edk2-non-osi: Add AmpereAltraBinPkg maintainers
> 
>  Maintainers.txt                               |  4 +++
>  Silicon/Ampere/License.txt                    | 25 +++++++++++++++++++
>  .../AmpereAltraBinPkg/AmpereAltraBinPkg.dec   | 16 ++++++++++++
>  .../Library/PciePhyLib/PciePhyLib.inf         | 23 +++++++++++++++++
>  .../Include/Library/PciePhyLib.h              | 25 +++++++++++++++++++
>  5 files changed, 93 insertions(+)
>  create mode 100644 Silicon/Ampere/License.txt
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/AmpereAltraBinPkg.dec
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Library/PciePhyLib/PciePhyLib.inf
>  create mode 100644 Silicon/Ampere/AmpereAltraBinPkg/Include/Library/PciePhyLib.h
> 
> -- 
> 2.17.1
>