public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Khasim Mohammed" <khasim.mohammed@arm.com>
To: devel@edk2.groups.io
Cc: nd@arm.com, Khasim Syed Mohammed <khasim.mohammed@arm.com>
Subject: [PATCH v3 0/7] N1Sdp ACPI table and configuration manager support
Date: Tue, 26 Oct 2021 23:02:27 +0530	[thread overview]
Message-ID: <20211026173234.9053-1-khasim.mohammed@arm.com> (raw)

I have incorporated all the review comments and suggestions
on v2 patches.

1) Was able to successfully run the CI on edk2-platforms enabled by Pierre
   https://github.com/PierreARM/edk2-platforms/tree/review/N1Sdp_v2

2) Observed three false positive for Dependency Check
N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf depends on pkg Platform/ARM/N1Sdp/N1SdpPlatform.dec
N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf depends on pkg Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec
N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf depends on pkg Platform/ARM/N1Sdp/N1SdpPlatform.dec

3) Duplicate GUIDs were fixed.

4) Coding style and doxygen related issues were fixed.

5) The build successfully boots on N1SDP in both multi and single chip profiles.

This patch series implements the configuration manager for N1Sdp
platform. It enables support for generating the following
ACPI tables:
             1. FACP
             2. DSDT
             3. GTDT
             4. APIC
             5. SPCR
             6. DBG2
             7. PPTT
             8. IORT
             9. MCFG
            10. SSDT - PCI
            11. SSDT - REMOTE PCI

The changes can be seen at:
https://github.com/khasim/edk2-platforms-n1sdp/tree/n1sdp-upstream

Khasim Syed Mohammed (7):
  Silicon/ARM/NeoverseN1Soc: Fix missing function documentation
  Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map
  Platform/ARM/N1Sdp: Introduce platform DXE driver
  Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations
  Platform/ARM/N1Sdp: Introduce platform specific asl tables
  Platform/ARM/N1Sdp: Configuration Manager for N1Sdp
  Platform/ARM/N1Sdp: Enable ACPI tables and configuration manager

 .../AslTables/Dsdt.asl                        |  482 ++++
 .../AslTables/SsdtPci.asl                     |  252 ++
 .../AslTables/SsdtRemotePci.asl               |  161 ++
 .../ConfigurationManager.c                    | 2199 +++++++++++++++++
 .../ConfigurationManager.h                    |  307 +++
 .../ConfigurationManagerDxe.inf               |  166 ++
 .../ConfigurationManagerDxe/Hmat.c            |  103 +
 .../ConfigurationManagerDxe/Platform.h        |   92 +
 .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.c   |   59 +
 .../N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf |   47 +
 Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h  |   35 +
 Platform/ARM/N1Sdp/N1SdpPlatform.dec          |   99 +
 Platform/ARM/N1Sdp/N1SdpPlatform.dsc          |   47 +-
 Platform/ARM/N1Sdp/N1SdpPlatform.fdf          |   22 +-
 .../Library/PlatformLib/PlatformLib.c         |   46 +-
 .../Library/PlatformLib/PlatformLib.inf       |   28 +-
 .../Library/PlatformLib/PlatformLibMem.c      |   84 +-
 Silicon/ARM/NeoverseN1Soc/NeoverseN1Soc.dec   |   35 +-
 18 files changed, 4233 insertions(+), 31 deletions(-)
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtPci.asl
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtRemotePci.asl
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Hmat.c
 create mode 100644 Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/Platform.h
 create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.c
 create mode 100644 Platform/ARM/N1Sdp/Drivers/PlatformDxe/PlatformDxe.inf
 create mode 100644 Platform/ARM/N1Sdp/Include/N1SdpAcpiHeader.h
 create mode 100644 Platform/ARM/N1Sdp/N1SdpPlatform.dec

-- 
2.17.1


             reply	other threads:[~2021-10-26 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-26 17:32 Khasim Mohammed [this message]
2021-10-26 17:32 ` [PATCH v3 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation Khasim Mohammed
2021-10-26 17:32 ` [PATCH v3 2/7] Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map Khasim Mohammed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211026173234.9053-1-khasim.mohammed@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox